[Rt-commit] rt branch 5.0/fix-find-asset-and-find-group-portlets created. rt-5.0.4-133-gd7f9f60b40

BPS Git Server git at git.bestpractical.com
Tue Aug 29 20:15:50 UTC 2023


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/fix-find-asset-and-find-group-portlets has been created
        at  d7f9f60b400d20f3bda6fe6b82149a0f6db2d693 (commit)

- Log -----------------------------------------------------------------
commit d7f9f60b400d20f3bda6fe6b82149a0f6db2d693
Author: Ronaldo Richieri <ronaldo at bestpractical.com>
Date:   Tue Aug 29 16:43:34 2023 -0300

    Fix Find Asset portlet input size
    
    Find Asset portlet input was not Bootstrap ready. We fixed using the
    same structure as Find portlets.

diff --git a/share/html/Elements/FindAsset b/share/html/Elements/FindAsset
index 2caa92cab2..b8b953dc7f 100644
--- a/share/html/Elements/FindAsset
+++ b/share/html/Elements/FindAsset
@@ -47,7 +47,13 @@
 %# END BPS TAGGED BLOCK }}}
 <&|/Widgets/TitleBox, title => loc('Find an asset') &>
 <form action="<% RT->Config->Get('WebPath') %>/Asset/Search/">
-  <input type="text" name="q" />
-  <input type="submit" value="<&|/l&>Search</&>" class="button" />
+  <div class="form-row justify-content-center">
+    <div class="col-9">
+      <input type="text" class="form-control" name="q" />
+    </div>
+    <div class="col-auto">
+      <input type="submit" value="<&|/l&>Search</&>" class="form-control btn btn-primary button" />
+    </div>
+  </div>
 </form>
 </&>

commit 442d727de90bdd11d7c23d70588e9cb139c178a9
Author: Ronaldo Richieri <ronaldo at bestpractical.com>
Date:   Tue Aug 29 16:40:10 2023 -0300

    Fix Find Group portlet input size
    
    The input had a fixed col-4 size, which was different from the input of
    the Find User portlet. We refactored the GotoGroup element to accept a
    cols parameter the same way GotoUser accepts it.
    
    Adjusted the FindGroup element to pass the cols parameter to the
    GotoGroup element and use the same number of columns as the FindUser.

diff --git a/share/html/Elements/FindGroup b/share/html/Elements/FindGroup
index 7b85b79565..5d09a1368c 100644
--- a/share/html/Elements/FindGroup
+++ b/share/html/Elements/FindGroup
@@ -46,5 +46,5 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 <&|/Widgets/TitleBox, title => loc('Find a group')&>
-<& /Elements/GotoGroup &>
+<& /Elements/GotoGroup, Cols => 9 &>
 </&>
diff --git a/share/html/Elements/GotoGroup b/share/html/Elements/GotoGroup
index 2abe0664a4..7c653df712 100644
--- a/share/html/Elements/GotoGroup
+++ b/share/html/Elements/GotoGroup
@@ -55,7 +55,7 @@ jQuery(function(){
 </script>
 <form name="GroupSearch" method="post" action="<% RT->Config->Get('WebPath') %>/Group/Search.html">
   <div class="form-row justify-content-center">
-    <div class="col-4">
+    <div class="col-<% $Cols %>">
       <input type="text" class="form-control" name="GroupString" value="<% $Default %>" data-autocomplete="Groups" data-autocomplete-return="Name" id="autocomplete-GroupString" />
     </div>
     <div class="col-auto">
@@ -65,4 +65,5 @@ jQuery(function(){
 </form>
 <%ARGS>
 $Default => ''
+$Cols    => 4
 </%ARGS>

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list