[Rt-commit] rt branch 5.0/txn-search-chart updated. rt-5.0.5-79-g72b62bfee4

BPS Git Server git at git.bestpractical.com
Fri Dec 1 18:01:34 UTC 2023


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/txn-search-chart has been updated
       via  72b62bfee4001a0a91b944943179174436eb9c4b (commit)
      from  db344fef685af0b12cda1325cee0671d3b33bc6e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 72b62bfee4001a0a91b944943179174436eb9c4b
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Dec 1 12:54:22 2023 -0500

    Limit lookup type for custom roles in reports
    
    Previously custom roles were only for tickets, but not any more since we
    added assets support.

diff --git a/lib/RT/Report.pm b/lib/RT/Report.pm
index 4e2aee59e7..9b32ef4cdf 100644
--- a/lib/RT/Report.pm
+++ b/lib/RT/Report.pm
@@ -104,6 +104,10 @@ our %GROUPINGS_META = (
                 return () unless $queues;
 
                 my $crs = RT::CustomRoles->new( $self->CurrentUser );
+                $crs->LimitToLookupType( $self->RecordClass->CustomFieldLookupType );
+                # Adding this to avoid returning all records when no queues are available.
+                $crs->LimitToObjectId(0);
+
                 for my $id ( keys %$queues ) {
                     my $queue = RT::Queue->new( $self->CurrentUser );
                     $queue->Load($id);

-----------------------------------------------------------------------

Summary of changes:
 lib/RT/Report.pm | 4 ++++
 1 file changed, 4 insertions(+)


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list