[rt-devel] [PATCH] Alignment on group rights admin page

[Phil Oester]

The alignment on this page is a bit off.  The attached patch fixes it up so that:

1) Current rights are left aligned, so the checkboxes line up

2) Columns use absolute widths so columns between the 3 types of groups are consistent

Phil Oester


diff -ru rt-3-0-1-orig/html/Admin/Elements/SelectRights rt-3-0-1/html/Admin/Elements/SelectRights
--- rt-3-0-1-orig/html/Admin/Elements/SelectRights      Tue Apr 15 11:54:14 2003
+++ rt-3-0-1/html/Admin/Elements/SelectRights   Mon Apr 21 14:47:24 2003
@@ -24,7 +24,7 @@
 <INPUT TYPE=HIDDEN NAME="CheckACL"  VALUE="<%$ACLDesc%>">
      <TABLE BORDER=0>
 <TR>
-<TD valign=top width="50%"> 
+<TD valign=top width="180"> 
 <h3><&|/l&>Current rights</&></h3>
 % if ($ACLObj->Count() > 0) {
 <i>(<&|/l&>Check box to revoke right</&>)</i> <BR>
diff -ru rt-3-0-1-orig/html/Admin/Global/GroupRights.html rt-3-0-1/html/Admin/Global/GroupRights.html
--- rt-3-0-1-orig/html/Admin/Global/GroupRights.html    Tue Apr 15 11:54:14 2003
+++ rt-3-0-1/html/Admin/Global/GroupRights.html Mon Apr 21 14:49:10 2003
@@ -36,8 +36,8 @@
 % $Groups = RT::Groups->new($session{'CurrentUser'});
 % $Groups->LimitToSystemInternalGroups();
 %      while (my $Group = $Groups->Next()) {
-  <TR ALIGN=RIGHT> 
-       <TD VALIGN=TOP>
+  <TR ALIGN=LEFT> 
+       <TD VALIGN=TOP width="20%">
            <% loc($Group->Type) %>
                  </TD>
          <TD>
@@ -52,8 +52,8 @@
 % $Groups = RT::Groups->new($session{'CurrentUser'});
 % $Groups->LimitToRolesForSystem();
 %      while (my $Group = $Groups->Next()) {
-  <TR ALIGN=RIGHT> 
-       <TD VALIGN=TOP>
+  <TR ALIGN=LEFT> 
+       <TD VALIGN=TOP width="20%">
            <% loc($Group->Type) %>
                  </TD>
          <TD>
@@ -68,8 +68,8 @@
 % $Groups = RT::Groups->new($session{'CurrentUser'});
 % $Groups->LimitToUserDefinedGroups();    
 %      while (my $Group = $Groups->Next()) {
-  <TR ALIGN=RIGHT> 
-       <TD VALIGN=TOP>
+  <TR ALIGN=LEFT> 
+       <TD VALIGN=TOP width="20%">
            <% $Group->Name %>
                  </TD>
          <TD>