[rt-devel] [PATCH] Global CustomFields alignment cosmetics

[Jeroen Ruigrok/asmodai]

This patch fixes the Global CustomFields page so that it looks
aesthetically better.

Only thing that needs to be done better is the: ``Checking the box(es)
deletes the value(s)'' text.

Next on my list is to make the SortOrder/Sort key editable.

-- 
Jeroen Ruigrok van der Werven <asmodai(at)wxs.nl> / asmodai / a capoeirista
PGP fingerprint: 2D92 980E 45FE 2C28 9DB7  9D88 97E6 839B 2EAC 625B
http://www.tendra.org/   | http://www.in-nomine.org/~asmodai/diary/
If you think that you know much, you know little... 
-------------- next part --------------
diff -ruN rt-2-1-79/html/Admin/Elements/AddCustomFieldValue rt-2-1-79-new/html/Admin/Elements/AddCustomFieldValue
--- rt-2-1-79/html/Admin/Elements/AddCustomFieldValue	Tue Mar  4 08:08:07 2003
+++ rt-2-1-79-new/html/Admin/Elements/AddCustomFieldValue	Wed Mar  5 00:45:06 2003
@@ -22,9 +22,23 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-<&|/l&>SortOrder</&>: <input name="CustomField-<% $CustomField->Id %>-AddValue-SortOrder" size="5"><BR>
-<&|/l&>Name</&>: <input size=20 name="CustomField-<% $CustomField->Id %>-AddValue-Name"><BR>
-<&|/l&>Description</&>: <input size="60" name="CustomField-<% $CustomField->Id %>-AddValue-Description"><BR>
+<TABLE WIDTH="100%" BORDER="0">
+<TR><TD ALIGN="RIGHT">
+<&|/l&>SortOrder</&>:
+</TD><TD>
+<input name="CustomField-<% $CustomField->Id %>-AddValue-SortOrder" size="5">
+</TD></TR>
+<TR><TD ALIGN="RIGHT">
+<&|/l&>Name</&>:
+</TD><TD>
+<input size=20 name="CustomField-<% $CustomField->Id %>-AddValue-Name">
+</TD></TR>
+<TR><TD ALIGN="RIGHT">
+<&|/l&>Description</&>:
+</TD><TD>
+<input size="60" name="CustomField-<% $CustomField->Id %>-AddValue-Description">
+</TD></TR>
+</TABLE>
 
 <%init>
 </%init>
diff -ruN rt-2-1-79/html/Admin/Elements/EditCustomField rt-2-1-79-new/html/Admin/Elements/EditCustomField
--- rt-2-1-79/html/Admin/Elements/EditCustomField	Tue Mar  4 08:08:07 2003
+++ rt-2-1-79-new/html/Admin/Elements/EditCustomField	Wed Mar  5 00:45:06 2003
@@ -29,19 +29,37 @@
 <INPUT TYPE=HIDDEN NAME="CustomField" VALUE="<%$id %>">
 <INPUT TYPE=HIDDEN name="Queue" value="<%$Queue%>">
 
-<&|/l&>Name</&>: <input name="Name" VALUE="<%$CustomFieldObj->Name%>" SIZE=20><BR>
-<&|/l&>Description</&>: <input name="Description" VALUE="<%$CustomFieldObj->Description%>" SIZE=80><BR>
-<&|/l&>Type</&>: <& /Admin/Elements/SelectCustomFieldType, Name => "Type", Default => $CustomFieldObj->Type &><BR>
+<TABLE WIDTH="100%" BORDER="0">
+<TR><TD ALIGN="RIGHT">
+<&|/l&>Name</&>:
+</TD><TD>
+<input name="Name" VALUE="<%$CustomFieldObj->Name%>" SIZE=20>
+</TD></TR>
+<TR><TD ALIGN="RIGHT">
+<&|/l&>Description</&>:
+</TD><TD>
+<input name="Description" VALUE="<%$CustomFieldObj->Description%>" SIZE=80>
+</TD></TR>
+<TR><TD ALIGN="RIGHT">
+<&|/l&>Type</&>:
+</TD><TD>
+<& /Admin/Elements/SelectCustomFieldType, Name => "Type", Default => $CustomFieldObj->Type &>
+</TD></TR>
+<TR><TD>
+</TD><TD>
 <INPUT TYPE=HIDDEN NAME="SetEnabled" VALUE="1">
 <INPUT TYPE=CHECKBOX NAME="Enabled" VALUE="1" <%$EnabledChecked%>> <&|/l&>Enabled (Unchecking this box disables this custom field)</&>
+</TD></TR>
+</TABLE>
 
 <P>
 % if ($CustomFieldObj->Id and $CustomFieldObj->Type =~ /Select/) {
-<H2><&|/l&>Values</&></H2>
+<& /Elements/TitleBoxStart, title => loc('Values') &>
 <font size=-1>
 <& /Admin/Elements/EditCustomFieldValues, CustomField => $CustomFieldObj &>
 <& /Admin/Elements/AddCustomFieldValue, CustomField => $CustomFieldObj &>
 </font>
+<& /Elements/TitleBoxEnd &>
 % }
 <&/Elements/Submit&>
 </FORM>
diff -ruN rt-2-1-79/html/Admin/Elements/EditCustomFieldValues rt-2-1-79-new/html/Admin/Elements/EditCustomFieldValues
--- rt-2-1-79/html/Admin/Elements/EditCustomFieldValues	Tue Mar  4 08:08:07 2003
+++ rt-2-1-79-new/html/Admin/Elements/EditCustomFieldValues	Wed Mar  5 00:45:06 2003
@@ -28,12 +28,13 @@
 <input type="checkbox" name="CustomField-<%$CustomField->Id%>-DeleteValue" value="<%$v->id%>">
 <%$v->Name%>
 <i>(<%$v->Description%>)</i>
-<font size=-1 color="#cccccc"><&|/l&>Sort key</&>: <%$v->SortOrder%></font></li>
+<font size=-1 color="#336699"><&|/l&>Sort key</&>: <%$v->SortOrder%></font></li>
 % }
 </ul>
 <%init>
 my $values = $CustomField->Values();
 </%init>
+<&|/l&>Checking the box(es) deletes the value(s)</&>
 <%args>
 $CustomField => undef
 </%args>