[Rt-devel] Re: [Rt-commit] r2815 - in rt/branches/3.4-RELEASE: . html/Ticket lib/RT/Action lib/RT/Interface

[Jesse Vincent]

On Fri, Apr 29, 2005 at 03:52:51PM +0200, Florian Weimer wrote:
> > +                $Message->head->replace('References',$old_txn->Message->First->GetHeader('Message-Id'). " ".$old_txn->Message->First->GetHeader('References') ); 
> 
> I think you concatenate the strings in the wrong order.  The old
> message ID must be appended, not prepended.  

Nice catch.

> You also should trim
> overlong References: headers (by dropping everything but the first two
> and last three message IDs, for example), to work around bugs in
> certain Windows clients which would otherwise crash.

Can you point me at a reference for this?

> I think a way to customize the $pseudo_ref value is desirable.

I can see that. I'll break it out to a separate subroutine.