[Rt-devel] BUG in ParseQuery ?

[Jesse Vincent]

On Wed, Nov 09, 2005 at 04:01:28PM -0500, Todd Chapman wrote:
> In Search/Build.html is sub ref ParseQuery with
> these lines:
> 
>     my $string  = shift;
>     my $tree    = shift;
>     my @actions = shift;
>     my $want    = KEYWORD | PAREN;
>     my $last    = undef;
> 
> Shouldn't @actions be $actions, a ref to an array?
> The sub goes on to push value onto the arrary but
> the new values won't be seen outside the sub.
> 
> If I am correct, it is easy to fix, but then shows
> shows a deeper bug in the sub.

That looks like a bug. assuming it's being called with an arrayref

> 
> -Todd
> 
> _______________________________________________
> Rt-devel mailing list
> Rt-devel at lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
> 

--