[Rt-devel] PATCH: silence warnings Search/Results.html

Jim Meyer purp at acm.org
Wed Nov 16 17:35:48 EST 2005


Attached.

--j
-- 
Jim Meyer, Geek at Large                                    purp at acm.org
-------------- next part --------------
--- share/html/Search/Results.html	2005-09-02 10:01:17.000000000 -0700
+++ local/html/Search/Results.html.merge	2005-11-16 14:31:29.000000000 -0800
@@ -63,13 +63,13 @@
     Format => $Format,
     BaseURL => $RT::WebPath."/Search/Results.html?"
 
    &>
-% my @vars = (Query => $Query, Format => $Format,  Rows => $Rows, OrderBy => $OrderBy,  Order => $Order, HideResults => $HideResults, Page => $Page );
+% my %hiddens = (Query => $Query, Format => $Format,  Rows => $Rows, OrderBy => $OrderBy,  Order => $Order, HideResults => $HideResults, Page => $Page );
 <div align="right">
 <form method="get" action="<%$RT::WebPath%>/Search/Results.html">
-%while (my $var = shift (@vars)) {
-<input type="hidden" class="hidden" name="<%$var%>" value="<%shift(@vars)%>"/>
+%foreach my $key (keys(%hiddens)) {
+<input type="hidden" class="hidden" name="<%$key%>" value="<%defined($hiddens{$key})?$hiddens{$key}:''%>"/>
 %}
 <& /Elements/Refresh, Name => 'TicketsRefreshInterval', Default => $session {'tickets_refresh_interval'} &>
 <input type="submit" class="button" value="<&|/l&>Go!</&>">
 </form>
@@ -80,11 +80,11 @@
 <a href="<%$RT::WebPath%>/Search/Results.tsv<%$QueryString%>"><&|/l&>spreadsheet</&></a> |
 <a href="<%$RSSFeedURL%>"><&|/l&>RSS</&></a> |
 <a href="<%$RT::WebPath%>/Tools/Offline.html<%$ShortQueryString%>"><&|/l&>Work offline</&></a><br/>
 <form method="get" action="<%$RT::WebPath%>/Search/Chart.html"><&|/l&>chart</&>
-% @vars = (Query => $Query, Format => $Format,  Rows => $Rows, OrderBy => $OrderBy,  Order => $Order);
-%while (my $var = shift (@vars)) {
-<input type="hidden" class="hidden" name="<%$var%>" value="<%shift(@vars)%>"/>
+% %hiddens = (Query => $Query, Format => $Format,  Rows => $Rows, OrderBy => $OrderBy,  Order => $Order, ShowActions => $ShowActions);
+%foreach my $key (keys(%hiddens)) {
+<input type="hidden" class="hidden" name="<%$key%>" value="<%defined($hiddens{$key})?$hiddens{$key}:''%>"/>
 %}
 <&|/l, $m->scomp('Elements/SelectGroupBy', Name => 'PrimaryGroupBy') &>grouped by [_1]</&>
 <&|/l, $m->scomp('Elements/SelectChartType', Name => 'ChartStyle') &>style: [_1]</&>
 <input type="submit" class="button" value="<%loc('Go')%>"/>


More information about the Rt-devel mailing list