[Rt-devel] 3.4.2 Bug/Patch - Mail failure results in 'success' log message & transaction

[Jesse Vincent]

On Wed, May 10, 2006 at 11:08:32AM -0400, Stephen Turner wrote:
> Patch to SendEmail.pm to fix minor bug.
> 
> If using sendmailpipe, and the mail command fails, RT still creates 
> an 'Outgoing Mail Recorded' transaction and logs a success message.

Looking at RT 3.4.5, this one's already fixed. But thanks for the heads
up.

> This patch eliminates the recording of 'success' messages if the mail 
> command fails - making the behavior consistent with the non-sendmailpipe 
> logic.
> 
> RT version is 3.4.2.
> 
> Steve
> 
> 
> 
> --- SendEmail.pm        2006-01-19 14:09:13.000000000 -0500
> +++ SendEmail_Local.pm  2006-05-10 10:55:24.000000000 -0400
> @@ -257,6 +257,7 @@
>          };
>          if ($@) {
>              $RT::Logger->crit( $msgid . "Could not send mail. -" . $@ );
> +            return (0);
>          }
>      }
>      else {
> 
> _______________________________________________
> List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
> 
> Best Practical is hiring! Come hack Perl for us: 
> http://bestpractical.com/about/jobs.html
> 

--