[Rt-devel] Errors generate warnings

Nicholas Clark nick at ccl4.org
Fri Jun 15 17:41:16 EDT 2007


On Fri, Jun 15, 2007 at 12:31:08PM -0400, Jesse Vincent wrote:
> About to apply this equivalent, slightly more Masonic patch. Thanks!
> 
> === html/Elements/Error
> ==================================================================
> --- html/Elements/Error (revision 58163)
> +++ html/Elements/Error (local)
> @@ -61,7 +61,7 @@
> 
>  <%args>
>  $Code => undef
> -$Details => undef
> +$Details =>''
>  $Title => loc("RT Error")
>  $Why => loc("the calling component did not specify why")
>  </%args>

I thought about that, but I wasn't sure whether $Details being undef was
intended to be a significant difference from $Details being an empty string.
Thinking about it now, it would seem pretty silly to have an empty string as
the supplied text detailing the error. So, yes, that approach is better.

Nicholas Clark


More information about the Rt-devel mailing list