[Rt-devel] PATCH: minor bug in Ticket/Elements/ShowHistory

Olly Stephens Olly.Stephens at arm.com
Tue Nov 18 19:12:21 EST 2008


Ticket/Elements/ShowHistory in 3.8.1 has a conditional <div> at the top
with an unconditional </div> at the bottom.  This causes the tickets to
leak out of the body on the approvals summary page because the
conditions for the div aren't true so you get too many closes.

The attached [trivial] patch resolves it.

Olly

Index: share/html/Ticket/Elements/ShowHistory
===================================================================
--- share/html/Ticket/Elements/ShowHistory      (revision 6360)
+++ share/html/Ticket/Elements/ShowHistory      (working copy)
@@ -132,8 +132,8 @@
 </div>
 % if ($ShowDisplayModes or $ShowTitle) {
 <& /Widgets/TitleBoxEnd &>
+</div>
 % }
-</div>
 <%INIT>
 my $Transactions = new RT::Transactions($session{'CurrentUser'});
 if ($Tickets) {

-- 
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rt-showhistory-patch.txt
Url: http://lists.bestpractical.com/pipermail/rt-devel/attachments/20081119/c7d4d8bc/attachment.txt 


More information about the Rt-devel mailing list