[Rt-devel] RT Reminders

[Kevin Falcone]

Christian

There turn out to have been multiple issues with this refactor:

http://issues.bestpractical.com/Ticket/Display.html?id=16273
https://github.com/bestpractical/rt/tree/4.0/show-all-reminders

You may want to backport them to your original extension

-kevin

On Fri, Dec 17, 2010 at 01:25:23PM -0500, Jesse Vincent wrote:
> Hi! 
> 
> I have some quibbles with some of the styling:
> 
>  - In the full-page edit UI, we should be using a more RTish key:value layout
>    rather than the multicolumn table
> 
>  - I'm not sure "Reminder" is the right header for the table, maybe "Summary"? not sure.
> 
>  - The table looks a little weird in context
> 
> Additionally, we should work toward killing the inline mason components. (I know they're not your fault. They were mine 8 years ago)
> 
> It looks like you may not have run tests after applying these patches, as they generated some warnings. 
> 
> All that being said, this is much better than what we had before. Thanks! Applied.
> 
> Best,
> Jesse
> 
> 
> On Thu, Dec 16, 2010 at 04:33:26PM +0100, Christian Loos wrote:
> > Hi Jesse,
> > 
> > attached 7 patches against 3.9-trunk.
> > 
> > -Chris
> > 
> > Am 13.12.2010 22:42, schrieb Jesse Vincent:
> > > Patches would certainly be easier to deal with than "here's a thing on github" 
> > > 
> > > If you have the cycles to do that, I'd find time to take a look.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.bestpractical.com/pipermail/rt-devel/attachments/20110111/04450c48/attachment.pgp>