<div class="gmail_quote"><div>Hi, I'm currently working with a RT 3 instance and I've found that some Tickets could be created with missing content under specific situations.</div><div>This is my scenario:</div><div>
* RT 3.8.7 runnig on RHEL5 with perl 5.8.8</div>
<div>* Oracle 10g database</div><div>* External mail server and fetchmail to recover emails</div><div><br></div><div>This RT instance is quite special, we recive a lot of spam (we are working to fix it) and the database grows quickly. During working days our monitoring agents alert us about reaching database space limit, but if this happen on weekend, nobody extends de DB until Monday. </div>
<div>Because of Spam we have configured fetchmail with "no keep" option, so if Ticket creation fails and fetchmail does not recieve an error return code the information of the email is lost.</div><div>I know that this are a lot of "special situations" but I think that rt-mailgate should return non zero result when RT couldn't create the Ticket correctly.</div>
<div>I haven't try to reproduce with other databases than Oracle, but I've reproduce this behavior on two different Oracle instances</div><div>This are the steps to reproduce the issue:</div><div><br></div><div>When rt database tablesapce is full, fetchmail try to recover an email (with an attachment or an html email).</div>
<div>Ticket is created but we end up with no attach or no text if email was html.</div><div>Fetchmail recive a 0 ret code and erase email from server.</div><div><br></div><div>I've attach the rt log when attachment insert fails.</div>
<div><br></div><div>I don't know if this is a bug or that's the way it's supposed to work, but we can't loose the email information.</div><div>If this is a bug, I think that could be generated by the scope of the variable $id in this code (Attachment_Overlay line 140)</div>
<div><br></div><div> # If a message has no bodyhandle, that means that it has subparts (or appears to)</div><div> # and we should act accordingly.</div><div> unless ( defined $Attachment->bodyhandle ) {</div>
<div>
my ($id) = $self->SUPER::Create(</div><div> TransactionId => $args{'TransactionId'},</div><div> Parent => $args{'Parent'},</div><div> ContentType => $Attachment->mime_type,</div>
<div> Headers => $head,</div><div> MessageId => $MessageId,</div><div> Subject => $Subject,</div><div> );</div><div><br></div><div> unless ($id) {</div>
<div> $RT::Logger->crit("Attachment insert failed - ". $RT::Handle->dbh->errstr);</div><div> }</div><div><br></div><div> foreach my $part ( $Attachment->parts ) {</div><div>
my $SubAttachment = new RT::Attachment( $self->CurrentUser );</div>
<div> my ($id) = $SubAttachment->Create(</div><div> TransactionId => $args{'TransactionId'},</div><div> Parent => $id,</div><div> Attachment => $part,</div>
<div> );</div><div> unless ($id) {</div><div> $RT::Logger->crit("Attachment insert failed: ". $RT::Handle->dbh->errstr);</div><div> }</div><div> }</div>
<div> return ($id);</div><div> }</div><div><br></div><div> #If it's not multipart</div><div> else {</div><div><br></div><div> my ($ContentEncoding, $Body) = $self->_EncodeLOB(</div><div> $Attachment->bodyhandle->as_string,</div>
<div><br></div><div><br></div><div>If the first SUPER::Create is successfull, the $id value isn't undef, but within the foreach loop, if an error ocurred adding Subattachments the crit message is printed because the inner $id is undef, but the returned value is the outer $id that is not undef, so the Ticket is created despite the error adding a subattachment. Adding a return($id) inside the foreach loop solves the problem an RT knows that Ticket can not be completly created.</div>
<div><br></div><div>This post is too long and don't want to add more info (specially with this terrible bad english), but despite the error returned to rt-mailgate when Ticket creation fails, it tells fetchmail that everything is ok and email is deleted. I've made an ugly hack to make it work, but I think that check_for_failure() in rt-mailgate could get te correct return code, I'm not a perl expert and couldn't make it work, any help?</div>
<div><br></div><div>Anyway, do you think that this is a bug or a feature?</div><div>Best regards.</div><div>Andres.</div><div><br></div>
</div><br>