[rt-users] Requiring CF to be defined on resolve

[Francis L Fabrizio]

Sorry, I created that patch pre-coffee this morning, and the patch was going backwards.  Here's the real patch:

--- /usr/local/rt/share/html/Ticket/Update.html 2010-08-24 08:33:38.000000000 -0500
+++ /usr/local/rt/local/html/Ticket/Update.html 2010-08-26 08:25:06.000000000 -0500
@@ -168,7 +168,7 @@

 my @results;

-$m->callback( Ticket => $TicketObj, ARGSRef => \%ARGS, results => \@results, CallbackName => 'Initial' );
+$m->callback( Ticket => $TicketObj, ARGSRef => \%ARGS, checks_failure => \$checks_failure, results => \@results, CallbackName => 'Initial' );

 unless($DefaultStatus){
     $DefaultStatus=($ARGS{'Status'} ||$TicketObj->Status());




> -----Original Message-----
> From: rt-users-bounces at lists.bestpractical.com [mailto:rt-users-
> bounces at lists.bestpractical.com] On Behalf Of Francis L Fabrizio
> Sent: Thursday, August 26, 2010 8:37 AM
> To: Emmanuel Lacour; rt-users at lists.bestpractical.com
> Subject: Re: [rt-users] Requiring CF to be defined on resolve
> 
> > exposing check_failure in a callback is a good idea. Can you provide
> a
> > patch for this so it will go in RT core?
> 
> This simple patch was sufficient for me:
> 
> 
> --- /usr/local/rt/local/html/Ticket/Update.html 2010-08-26
> 08:25:06.000000000 -0500
> +++ /usr/local/rt/share/html/Ticket/Update.html 2010-08-24
> 08:33:38.000000000 -0500
> @@ -168,7 +168,7 @@
> 
>  my @results;
> 
> -$m->callback( Ticket => $TicketObj, ARGSRef => \%ARGS, checks_failure
> => \$checks_failure, results => \@results, CallbackName => 'Initial' );
> +$m->callback( Ticket => $TicketObj, ARGSRef => \%ARGS, results =>
> \@results, CallbackName => 'Initial' );
> 
>  unless($DefaultStatus){
>      $DefaultStatus=($ARGS{'Status'} ||$TicketObj->Status());
> 
> 
> It might make sense to also expose checks_failure in other callbacks in
> Update.html, but hooking in at Initial seems pretty flexible on its
> own.
> 
> -Fran
> 
> RT Training in Washington DC, USA on Oct 25 & 26 2010
> Last one this year -- Learn how to get the most out of RT!