[rt-users] [PATCH REQ for 4.2.2] callback for Modify.html

Arkadiusz Miśkiewicz arekm at maven.pl
Tue Nov 26 07:58:47 EST 2013


Hi.

Update.html contains nice callback for various tasks (like checking form 
fields etc):
 $m->callback( CallbackName => 'BeforeUpdate', ARGSRef => \%ARGS, skip_update 
               => \$skip_update, ...

but Modify.html doesn't have such thing.

Was there any reason for not adding BeforeModify callback in Modify.html? It's 
logical to have the same sets of callbacks for similar actions IMO.

This patch below works (hand made, line wrapped, so likely won't apply 
directly). Please add such modification to 4.2.2. Thanks.

--- html/Ticket/Modify.html~   2013-11-25 10:25:50.000000000 +0100
+++ html/Ticket/Modify.html    2013-11-26 13:36:25.847864830 +0100
@@ -77,6 +77,9 @@
 my @results;
 my $skip_update = 0;
 
+$m->callback( CallbackName => 'BeforeModify', ARGSRef => \%ARGS, skip_update 
=> \$skip_update,
+              results => \@results, TicketObj => $TicketObj );
+
 # Now let callbacks have a chance at editing %ARGS
 $m->callback( TicketObj => $TicketObj, CustomFields => $CustomFields, ARGSRef 
=> \%ARGS, skip_update => \$skip_update );

-- 
Arkadiusz Miśkiewicz, arekm / maven.pl



More information about the rt-users mailing list