Of course.<br><br clear="all">--<br>Bekény<br>
<br><br><div class="gmail_quote">2009/12/18 Jesse Vincent <span dir="ltr"><<a href="mailto:jesse@bestpractical.com">jesse@bestpractical.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
Bekeny,<br>
<br>
Could you do me the favor of resending as a unified diff? (diff -u)<br>
<br>
Thanks!<br>
<div><div></div><div class="h5"><br>
On Thu 17.Dec'09 at 23:24:11 +0100, BÁLINT Bekény wrote:<br>
> Hi Jesse,<br>
><br>
><br>
> I attached a patch for 3.8.6.<br>
> I'm not sure it is the best solution for this problem but it seems a working<br>
> one.<br>
> Hope I helped.<br>
><br>
><br>
> Best regards,<br>
> --<br>
> Bekeny<br>
><br>
><br>
> 2009/12/17 Jesse Vincent <<a href="mailto:jesse@bestpractical.com">jesse@bestpractical.com</a>><br>
><br>
><br>
><br>
><br>
> On Thu 17.Dec'09 at 13:43:41 +0100, BALINT Bekeny wrote:<br>
> > Hi List,<br>
> ><br>
> ><br>
> > I have the following problem in 3.8.6 (sorry I can't try it on 3.8.7<br>
> now).<br>
> > If I have a header line in an email like this (or in Cc field):<br>
> ><br>
> > To: "'Foo Bar'" <<a href="mailto:foo.bar@foobar.hu">foo.bar@foobar.hu</a>><br>
> > of<br>
> > To: 'Foo2 Bar2' <<a href="mailto:foo2.bar2@foobar2.hu">foo2.bar2@foobar2.hu</a>><br>
> ><br>
> > on the Update.html page (UpdateCc component) RT generates the code:<br>
> ><br>
> > [...]<br>
> ><br>
> > It seems that ' disturbs the generated JavaScript code.<br>
> > Is it a known issue?<br>
><br>
> I didn't know about it.<br>
><br>
> > Or a Bug?<br>
><br>
> It sure looks like a bug. Will you open a ticket? A patch would be much<br>
> appreciated if you or anyone else is up to it.<br>
><br>
> > Or a Feature?<br>
><br>
> It's definitely not one of these.<br>
><br>
> -Jesse<br>
><br>
> -----BEGIN PGP SIGNATURE-----<br>
> Version: GnuPG v1.4.9 (GNU/Linux)<br>
><br>
> iEYEARECAAYFAksqQg0ACgkQEi9d9xCOQEbYEACeN5Wphc16WbGraqy9ayXsPeVt<br>
> uHYAn1I2sS4AHEqkKNeK4uY+TZRwgjao<br>
> =N12W<br>
> -----END PGP SIGNATURE-----<br>
><br>
><br>
><br>
<br>
</div></div>> *** share/html/Ticket/Elements/UpdateCc Mon Nov 23 23:11:39 2009<br>
> --- local/html/Ticket/Elements/UpdateCc Thu Dec 17 23:14:00 2009<br>
> ***************<br>
> *** 55,61 ****<br>
> id="UpdateCc-<%$addr%>"<br>
> name="UpdateCc-<%$addr%>"<br>
> type="checkbox"<br>
> ! onClick="checkboxToInput('UpdateCc', 'UpdateCc-<%$addr%>','<%$txn_addresses{$addr}->format%>' ); $(UpdateIgnoreAddressCheckboxes).value=1"<br>
> <% $ARGS{'UpdateCc-'.$addr} ? 'checked="checked"' : ''%> > <& /Elements/ShowUser, Address => $txn_addresses{$addr}&><br>
> %}<br>
> </td></tr><br>
> --- 55,63 ----<br>
> id="UpdateCc-<%$addr%>"<br>
> name="UpdateCc-<%$addr%>"<br>
> type="checkbox"<br>
> ! % my $clean_addr = $txn_addresses{$addr}->format;<br>
> ! % $clean_addr =~ s/'//g;<br>
> ! onClick="checkboxToInput('UpdateCc', 'UpdateCc-<%$addr%>','<%$clean_addr%>' ); $(UpdateIgnoreAddressCheckboxes).value=1"<br>
> <% $ARGS{'UpdateCc-'.$addr} ? 'checked="checked"' : ''%> > <& /Elements/ShowUser, Address => $txn_addresses{$addr}&><br>
> %}<br>
> </td></tr><br>
> ***************<br>
> *** 66,72 ****<br>
> id="UpdateBcc-<%$addr%>"<br>
> name="UpdateBcc-<%$addr%>"<br>
> type="checkbox"<br>
> ! onClick="checkboxToInput('UpdateBcc', 'UpdateBcc-<%$addr%>','<%$txn_addresses{$addr}->format%>' ); $(UpdateIgnoreAddressCheckboxes).value=1"<br>
> <% $ARGS{'UpdateBcc-'.$addr} ? 'checked="checked"' : ''%>><br>
> <& /Elements/ShowUser, Address => $txn_addresses{$addr}&><br>
> %}<br>
> --- 68,76 ----<br>
> id="UpdateBcc-<%$addr%>"<br>
> name="UpdateBcc-<%$addr%>"<br>
> type="checkbox"<br>
> ! % my $clean_addr = $txn_addresses{$addr}->format;<br>
> ! % $clean_addr =~ s/'//g;<br>
> ! onClick="checkboxToInput('UpdateBcc', 'UpdateBcc-<%$addr%>','<%$clean_addr%>' ); $(UpdateIgnoreAddressCheckboxes).value=1"<br>
> <% $ARGS{'UpdateBcc-'.$addr} ? 'checked="checked"' : ''%>><br>
> <& /Elements/ShowUser, Address => $txn_addresses{$addr}&><br>
> %}<br>
<br>
<br>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.9 (GNU/Linux)<br>
<br>
iEYEARECAAYFAksr5l8ACgkQEi9d9xCOQEY0cQCgooq/46j4HCDwE5miUkMto6nv<br>
DZgAoLU0rQvdttmcTwYHw8RRf5xvr1b+<br>
=PnES<br>
-----END PGP SIGNATURE-----<br>
<br></blockquote></div><br>