<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-AU link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:10.0pt'>Hi Emmanuel,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>Thanks, the patch doesn’t apply:<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>root@sirius:/usr/share/request-tracker3.8# patch -p2 < /tmp/thepatch<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>patching file html/REST/1.0/Forms/ticket/default<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>patch: **** malformed patch at line 14: $time = new RT::Date ($session{Curr entUser});<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>=========<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>root@sirius:/tmp# cat thepatch<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>diff --git a/share/html/REST/1.0/Forms/ticket/default b/share/html/REST/1.0/Forms/ticket/default<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>index 0d403b2..280ab55 100755<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>--- a/share/html/REST/1.0/Forms/ticket/default<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>+++ b/share/html/REST/1.0/Forms/ticket/default<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>@@ -202,7 +202,7 @@ if (!keys(%data)) {<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'> foreach $key (@people) {<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'> next unless (!%$fields || (exists $fields->{lc $key}));<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>- push @data, [ $key => [ $ticket->$key->MemberEmailAddresses ] ];<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>+ push @data, [ $key =><o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>+ $ticket->$key->MemberEmailAddressesAsString ];<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'> }<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'> $time = new RT::Date ($session{CurrentUser});<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>root@sirius:/tmp#<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>This occurs twice in that file (approx. line 202 & line 310). The other matching text you’ve flagged there narrows it down to the block @ line 202…<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>Ok, found it:<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>205: push @data, [ $key => [ $ticket->$key->MemberEmailAddresses ] ];<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>To<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'> push @data, [ $key => $ticket->$key->MemberEmailAddresses ];<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>and it’s now working… yay! I need to check a few other things in our staging environment first, and then will deploy to prod.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>Dominic: Yes, agree but I need a way of making this work right now, so for the moment I’ll update our internal documentation around deploying upgrades for RT and a note to check this functionality. We have several other systems that depend upon RT (like billing for example) so we don’t tend to upgrade RT very often, only when we’re looking for some significant new functionality.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>What’s the protocol for me to post this up as a suggestion for this fix to become incorporated back into the main 3.8 code base so that future releases will include it? (assuming that this isn’t going to break some other piece of critical functionality!).<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>Something weird I did notice (unrelated I think):<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal style='margin-left:36.0pt'><span style='font-size:10.0pt'>rt> list "id = 68667" -f id,requestors,subject<o:p></o:p></span></p><p class=MsoNormal style='margin-left:36.0pt'><span style='font-size:10.0pt'>id Subject Requestors<o:p></o:p></span></p><p class=MsoNormal style='margin-left:36.0pt'><span style='font-size:10.0pt'>68667 My testing ticket chris@noemail.com<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'>Notice that the order of the requestors & subject field is reversed? The headings in the results are the right way around though. It’s not critical but curious as to why.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;color:black;mso-fareast-language:EN-AU'>Regards,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;color:black;mso-fareast-language:EN-AU'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;color:black;mso-fareast-language:EN-AU'>Chris Herrmann<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;color:black;mso-fareast-language:EN-AU'>Far Edge Technology<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;color:black;mso-fareast-language:EN-AU'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;color:black;mso-fareast-language:EN-AU'>p. 02 84251400<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;color:black;mso-fareast-language:EN-AU'>m. 0403 393309<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;color:black;mso-fareast-language:EN-AU'><a href="http://www.faredge.com.au"><span style='color:blue'>http://www.faredge.com.au</span></a> <o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p></div></body></html>