[SearchBuilder-devel] [RFC] transactions handling changes and tests

Ruslan Zakirov ruslan.zakirov at gmail.com
Sat Dec 31 03:13:32 EST 2005


here is patch with:
* EndTxn
* per-dbh txn depth


On 12/30/05, Jesse Vincent <jesse at bestpractical.com> wrote:
>
> On Fri, Dec 30, 2005 at 01:52:24AM +0300, Ruslan Zakirov wrote:
> > changes:
> > * "EndTransaction [action] [force]" method that generalize commit and
> > rollback behaviour.
> > * don't import methods(functions) from external modules
> > * per $dbh transaction depth
> > * delete $DEBUG global var, too many ways for reporting problems
>
>
> I'd rather split out the totally uncontroversial stuff (imports, DEBUG,
> trans depth) and get those in right away and see the EndTxn as its own
> patch without source reformattings, so I can see what it's actually
> doing. You've included a whole lot of minor cleanups that make it really
> hard to see your functionality changes.
>
> Jesse
>
> >
> > tests:
> > * transactions tests
> > * joins tests, two test fails and marked as TODO, I've hit this
> > behaviour when was writing
> >
> > if patch would be approved then I'll update docs and commit it.
> >
> > --
> > Best regards, Ruslan.


--
Best regards, Ruslan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: transactions.patch
Type: text/x-patch
Size: 3570 bytes
Desc: not available
Url : http://lists.bestpractical.com/pipermail/searchbuilder-devel/attachments/20051231/24032182/transactions.bin


More information about the SearchBuilder-devel mailing list