[SearchBuilder-devel] Re: [PATCH] filters

[Ruslan Zakirov]

On 9/23/05, Jesse Vincent <jesse at bestpractical.com> wrote:
>
>
>
> On Fri, Sep 23, 2005 at 05:02:22AM +0400, Ruslan Zakirov wrote:
> > Comments from Jesse:
> >
> > > I see why you moved the filters thing, but it feels a little more wrong to me on records than on columns.
> >
> > > and Jifty::DBI::Filterable isn't quite right name
> > it's only abstract interface class and it was implemented only to
> > reach next goals:
> > 1) one interface for all classes where you can define filters
> > 2) and cover logic: unless you define own list of the output filters
> > we take reversed list of input filters
> > I don't know how to name it correctly and also don't like that I've
> > created new file for this.
>
> I think it deserves a file. It's a mixin ;)
>
> > Suggest another name for package.
>
> ::HasFilters?
doesn't matter

>
> > Also we could move this code into Filter.pm file, but with different
> > package name.
>
> Down that road lies madness and SOAP::Lite.
ok :)
>
> > > also, why the ->{decoded} hash to go along with the fetched hash?
> > It's required to optimize code a little, and would help us implement
> > any logic we want for load_* methods.
>
> I didn't se it used yet. was it acutally used?
yes. if value is fetched(cached in the record object) it doesn't mean
it's decoded.

>
> > > also, "wants more docs" ;)
> > writing
> >
> > > otherwise, nice
>
> Cool
>


--
Best regards, Ruslan.