[svk-commit] r2188 - trunk/lib/SVK

[clkao at bestpractical.com]

Author: clkao
Date: Mon Nov 20 07:37:33 2006
New Revision: 2188

Modified:
   trunk/lib/SVK/Command.pm
   trunk/lib/SVK/Logger.pm
   trunk/lib/SVK/Mirror.pm

Log:
l4p has funny behaviour about trailing newlines.

Modified: trunk/lib/SVK/Command.pm
==============================================================================
--- trunk/lib/SVK/Command.pm	(original)
+++ trunk/lib/SVK/Command.pm	Mon Nov 20 07:37:33 2006
@@ -364,7 +364,7 @@
     # this is going to take a while, release giant lock
     $self->{xd}->giant_unlock;
 
-    $logger->info(loc("New URI encountered: %1", $uri));
+    $logger->info(loc("New URI encountered: %1\n", $uri));
 
     my $depots = join('|', map quotemeta, sort keys %$map);
     my ($base_uri, $rel_uri);

Modified: trunk/lib/SVK/Logger.pm
==============================================================================
--- trunk/lib/SVK/Logger.pm	(original)
+++ trunk/lib/SVK/Logger.pm	Mon Nov 20 07:37:33 2006
@@ -62,8 +62,10 @@
 $current_level = $level->{lc $ENV{SVKLOGLEVEL}} || $level->{info};
 
 my $ignore  = sub { return };
-my $warn    = sub { shift; $_[0] .= "\n"; print $_[0] };
-#my $die     = sub { shift; $_[0] .= "\n" unless ref($_[0]); goto \&CORE::GLOBAL::die };
+my $warn = sub {
+    $_[1] .= "\n" unless substr( $_[1], -1, 1 ) eq "\n";
+    print $_[1];
+};
 my $die     = sub { shift; die $_[0]."\n"; };
 my $carp    = sub { shift; goto \&Carp::carp };
 my $confess = sub { shift; goto \&Carp::confess };

Modified: trunk/lib/SVK/Mirror.pm
==============================================================================
--- trunk/lib/SVK/Mirror.pm	(original)
+++ trunk/lib/SVK/Mirror.pm	Mon Nov 20 07:37:33 2006
@@ -344,6 +344,7 @@
 This is essentially making a checkout of the url, and is bad if the
 url contains directories like trunk and branches.  If this isn't what
 you mean, please hit ^C.
+
 ", $self->url));
 
     $self->run_svnmirror_sync( { skip_to => $snapshot });