[svk-users] SVK mirror sync problem - quoted spaces in url

[William McKee]

Hi Guys,

These patches look like they will solve some of the problems I've been
having with checkouts. Thanks for your work. Could someone roll them up
into a patchset against the latest release or will these be going into a
forthcoming release?


Thanks,
William

On Wed, 2008-04-16 at 11:31 +0200, Fabian Walk wrote:
> Hi,
> 
> thank you for the workaround now the synchronization works fine when I 
> use the -s option.
> 
> Now I can go on to integrate svk in our work flow and install the 
> patched version on the development PC's.
> 
> Thank you very much
> Fabian
> 
> 
> Cheng-Lung Sung schrieb:
> > Hi,
> >     It seems we need to patch SVN/Mirror/Ra.pm, but before that
> >     here is a similar workaround,
> > 
> >     Please use this patch and try again :) (also note the first
> >     patch segment was already provided before).
> > 
> > ==================================================================
> > --- lib/SVK/Mirror.pm (revision 2736)
> > +++ lib/SVK/Mirror.pm (local)
> > @@ -118,6 +118,7 @@
> >      my $self = $class->SUPER::new($args);
> > 
> >      $self->{url} =~ s{/+$}{}g;
> > +    $self->{url} =~ s/%([0-9A-Fa-f]{2})/chr(hex($1))/eg;
> > 
> >      $self->pool( SVN::Pool->new(undef) )
> >          unless $self->pool;
> > @@ -426,7 +427,11 @@
> >      my $target = $self->get_svkpath;
> > 
> >      my $lock_message = $self->_lock_message;
> > +    my $escaped_url = $self->url;
> > +    $escaped_url =~ s/([^0-9A-Za-z%\-\/:_.!~*'()])/sprintf("%%%02X", ord($1))/eg;
> > +
> >      my $svm = SVN::Mirror->new(
> > +        source => $escaped_url,
> >          target_path    => $self->path,
> >          repos          => $self->depot->repos,
> >          config         => SVK::Config->svnconfig,
> > ==================================================================
> > 
> > Best Regards,
> > Cheng-Lung
> _______________________________________________
> svk-users mailing list
> svk-users at lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/svk-users
-- 
Knowmad Technologies - Software Consultancy
W: http://www.knowmad.com | E: william at knowmad.com
P: 704.343.9330 | http://www.LinkedIn.com/in/williammckee