[Bps-public-commit] r10208 - in RT-Client-Console: trunk/lib/RT/Client/Console trunk/lib/RT/Client/Console/Session trunk/lib/RT/Client/Console/Session/Ticket
dams at bestpractical.com
dams at bestpractical.com
Sun Dec 30 18:04:54 EST 2007
Author: dams
Date: Sun Dec 30 18:04:54 2007
New Revision: 10208
Modified:
RT-Client-Console/ (props changed)
RT-Client-Console/trunk/lib/RT/Client/Console/Cnx.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/KeyHandler.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/Progress.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/Root.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/Status.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/TabBar.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Attachments.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/CustFields.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Header.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Links.pm
RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Transactions.pm
Log:
r51 at pundit: dams | 2007-12-30 23:04:46 +0000
use strict and warnings. From Maddingue's patch (thanks)
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Cnx.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Cnx.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Cnx.pm Sun Dec 30 18:04:54 2007
@@ -1,6 +1,9 @@
package RT::Client::Console::Cnx;
-use base qw(RT::Client::Console);
+use strict;
+use warnings;
+
+use parent qw(RT::Client::Console);
use Curses::Forms::Dialog::Logon;
use Curses::Forms::Dialog::Input;
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session.pm Sun Dec 30 18:04:54 2007
@@ -3,7 +3,7 @@
use strict;
use warnings;
-use base qw(RT::Client::Console);
+use parent qw(RT::Client::Console);
use POE;
use List::Util qw(max);
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/KeyHandler.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/KeyHandler.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/KeyHandler.pm Sun Dec 30 18:04:54 2007
@@ -1,6 +1,9 @@
package RT::Client::Console::Session::KeyHandler;
-use base qw(RT::Client::Console::Session);
+use strict;
+use warnings;
+
+use parent qw(RT::Client::Console::Session);
use Curses;
use Params::Validate qw(:all);
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/Progress.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/Progress.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/Progress.pm Sun Dec 30 18:04:54 2007
@@ -1,6 +1,9 @@
package RT::Client::Console::Session::Progress;
-use base qw(RT::Client::Console::Session);
+use strict;
+use warnings;
+
+use parent qw(RT::Client::Console::Session);
use POE;
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/Root.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/Root.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/Root.pm Sun Dec 30 18:04:54 2007
@@ -1,6 +1,9 @@
package RT::Client::Console::Session::Root;
-use base qw(RT::Client::Console::Session);
+use strict;
+use warnings;
+
+use parent qw(RT::Client::Console::Session);
use Params::Validate qw(:all);
use POE;
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/Status.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/Status.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/Status.pm Sun Dec 30 18:04:54 2007
@@ -1,6 +1,9 @@
package RT::Client::Console::Session::Status;
-use base qw(RT::Client::Console::Session);
+use strict;
+use warnings;
+
+use parent qw(RT::Client::Console::Session);
use Curses::Widgets::Label;
use Params::Validate qw(:all);
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/TabBar.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/TabBar.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/TabBar.pm Sun Dec 30 18:04:54 2007
@@ -3,7 +3,7 @@
use strict;
use warnings;
-use base qw(RT::Client::Console::Session);
+use parent qw(RT::Client::Console::Session);
use Curses::Forms;
use Curses::Widgets::Label;
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket.pm Sun Dec 30 18:04:54 2007
@@ -1,8 +1,11 @@
package RT::Client::Console::Session::Ticket;
+use strict;
+use warnings;
+
# multi-inheritance
-use base qw(RT::Client::Console::Session
- RT::Client::REST::Ticket);
+use parent qw(RT::Client::Console::Session
+ RT::Client::REST::Ticket);
use Error qw(:try);
use POE;
@@ -33,12 +36,13 @@
sub load {
my ($class) = @_;
+ my $id;
try {
- if (my $id = $class->input_ok_cancel('Open a ticket', 'Ticket number')) {
+ if ($id = $class->input_ok_cancel('Open a ticket', 'Ticket number')) {
$class->load_from_id($id);
}
} otherwise {
- $class->error("problem opening/retrieving rt $rt_num : " . $@);
+ $class->error("problem opening/retrieving rt $id : " . $@);
};
return;
}
@@ -61,7 +65,7 @@
$class->set_current_id($id);
$class->_set_visibility();
} otherwise {
- $class->error("problem opening/retrieving rt $rt_num : " . $@);
+ $class->error("problem opening/retrieving rt $id : " . $@);
};
return;
}
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Attachments.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Attachments.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Attachments.pm Sun Dec 30 18:04:54 2007
@@ -3,7 +3,7 @@
use strict;
use warnings;
-use base qw(RT::Client::Console::Session);
+use parent qw(RT::Client::Console::Session);
use Curses::Widgets; # for textwrap
use Curses::Widgets::ListBox;
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/CustFields.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/CustFields.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/CustFields.pm Sun Dec 30 18:04:54 2007
@@ -1,6 +1,9 @@
package RT::Client::Console::Session::Ticket::CustFields;
-use base qw(RT::Client::Console::Session);
+use strict;
+use warnings;
+
+use parent qw(RT::Client::Console::Session);
use Curses::Forms;
use Params::Validate qw(:all);
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Header.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Header.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Header.pm Sun Dec 30 18:04:54 2007
@@ -1,6 +1,9 @@
package RT::Client::Console::Session::Ticket::Header;
-use base qw(RT::Client::Console::Session);
+use strict;
+use warnings;
+
+use parent qw(RT::Client::Console::Session);
use Curses::Forms;
use Params::Validate qw(:all);
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Links.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Links.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Links.pm Sun Dec 30 18:04:54 2007
@@ -1,6 +1,9 @@
package RT::Client::Console::Session::Ticket::Links;
-use base qw(RT::Client::Console::Session);
+use strict;
+use warnings;
+
+use parent qw(RT::Client::Console::Session);
use Curses::Forms;
use Params::Validate qw(:all);
@@ -129,7 +132,6 @@
[ 'Depended on by:' => $_ticket_to_label->($d2[0]) ],
map { [ '' => $_ticket_to_label->($_) ] } @d2[1..$#d2]
);
-print STDERR "----> parents : " . Dumper(\@p); use Data::Dumper;
my @p = @{$heap->{parents}};
my @parents = (
[ 'Parents:' => $_ticket_to_label->($p[0]) ],
@@ -234,4 +236,5 @@
},
);
}
+
1;
Modified: RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Transactions.pm
==============================================================================
--- RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Transactions.pm (original)
+++ RT-Client-Console/trunk/lib/RT/Client/Console/Session/Ticket/Transactions.pm Sun Dec 30 18:04:54 2007
@@ -3,7 +3,7 @@
use strict;
use warnings;
-use base qw(RT::Client::Console::Session);
+use parent qw(RT::Client::Console::Session);
use Error qw(:try);
use Curses::Widgets; # for textwrap
More information about the Bps-public-commit
mailing list