[Bps-public-commit] r10466 - bpsbuilder/Shipwright/lib/Shipwright/Source

[sunnavy at bestpractical.com]

Author: sunnavy
Date: Thu Jan 24 08:27:41 2008
New Revision: 10466

Modified:
   bpsbuilder/Shipwright/lib/Shipwright/Source/Base.pm

Log:
make critic happy, though we have to use eval

Modified: bpsbuilder/Shipwright/lib/Shipwright/Source/Base.pm
==============================================================================
--- bpsbuilder/Shipwright/lib/Shipwright/Source/Base.pm	(original)
+++ bpsbuilder/Shipwright/lib/Shipwright/Source/Base.pm	Thu Jan 24 08:27:41 2008
@@ -62,7 +62,7 @@
             my $source = read_file( File::Spec->catfile( '_build', 'prereqs' ) )
               or die "can't read _build/prereqs: $!";
             my $eval .= '$require = ' . $source;
-            eval $eval or die "eval error: $@";
+            eval $eval or die "eval error: $@"; ## no critic
 
             $source = read_file( File::Spec->catfile('Build.PL') )
               or die "can't read Build.PL: $!";
@@ -81,7 +81,7 @@
             if ( $source =~ /({.*})/ ) {
                 my $eval .= '$require = ' . $1;
                 $eval =~ s/([\w:]+)=>/'$1'=>/g;
-                eval $eval or die "eval error: $@";
+                eval $eval or die "eval error: $@"; ## no critic
             }
 
             for ( keys %$require ) {
@@ -110,7 +110,6 @@
 
                 for (qw/recommends build_requires/) {
                     my $keep = 'keep_' . $_;
-                    no strict 'refs';
                     if ( $meta->{$_} ) {
                         for my $module ( keys %{ $meta->{$_} } ) {
                             next unless defined $require->{requires}{$module};