[Bps-public-commit] r14136 - in sd/trunk: . lib/App/SD/Replica/Hiveminder lib/App/SD/Replica/RT

[sartak at bestpractical.com]

Author: sartak
Date: Tue Jul 15 21:12:37 2008
New Revision: 14136

Modified:
   sd/trunk/   (props changed)
   sd/trunk/lib/App/SD/Replica/Hiveminder/PushEncoder.pm
   sd/trunk/lib/App/SD/Replica/RT.pm
   sd/trunk/lib/App/SD/Replica/RT/PullEncoder.pm

Log:
 r64339 at onn:  sartak | 2008-07-15 21:12:28 -0400
 Some warnings cleanup


Modified: sd/trunk/lib/App/SD/Replica/Hiveminder/PushEncoder.pm
==============================================================================
--- sd/trunk/lib/App/SD/Replica/Hiveminder/PushEncoder.pm	(original)
+++ sd/trunk/lib/App/SD/Replica/Hiveminder/PushEncoder.pm	Tue Jul 15 21:12:37 2008
@@ -83,11 +83,11 @@
 }
 
 sub integrate_comment {
-    warn "comment not yet";
+    warn "comment not implemented yet";
 }
 
 sub integrate_ticket_update {
-    warn "update not yet";
+    warn "update not implemented yet";
 }
 
 sub _recode_props_for_integrate {

Modified: sd/trunk/lib/App/SD/Replica/RT.pm
==============================================================================
--- sd/trunk/lib/App/SD/Replica/RT.pm	(original)
+++ sd/trunk/lib/App/SD/Replica/RT.pm	Tue Jul 15 21:12:37 2008
@@ -48,7 +48,6 @@
     $self->rt_url($uri->as_string);
     $self->rt_queue($type);
     $self->rt_query( ( $query ?  "($query) AND " :"") . " Queue = '$type'" );
-    warn $self->rt_query;
     $self->rt( RT::Client::REST->new( server => $server ) );
 
     ( $username, $password ) = $self->prompt_for_login( $uri, $username )

Modified: sd/trunk/lib/App/SD/Replica/RT/PullEncoder.pm
==============================================================================
--- sd/trunk/lib/App/SD/Replica/RT/PullEncoder.pm	(original)
+++ sd/trunk/lib/App/SD/Replica/RT/PullEncoder.pm	Tue Jul 15 21:12:37 2008
@@ -160,8 +160,7 @@
 
             return $changeset;
         } else {
-            warn "not handling txn type $txn->{Type} for $txn->{id} yet";
-            die YAML::Dump($txn);
+            die "not handling txn type $txn->{Type} for $txn->{id} yet";
         }
     }