[Bps-public-commit] r12515 - in Shipwright/trunk: share/bin

[sunnavy at bestpractical.com]

Author: sunnavy
Date: Sun May 18 11:17:07 2008
New Revision: 12515

Modified:
   Shipwright/trunk/   (props changed)
   Shipwright/trunk/share/bin/shipwright-builder

Log:
 r12550 at sunnavys-mb:  sunnavy | 2008-05-18 22:26:25 +0800
 $! is so misleading weirdly


Modified: Shipwright/trunk/share/bin/shipwright-builder
==============================================================================
--- Shipwright/trunk/share/bin/shipwright-builder	(original)
+++ Shipwright/trunk/share/bin/shipwright-builder	Sun May 18 11:17:07 2008
@@ -111,7 +111,7 @@
     if ( -e '__need_clean' ) {
         print "seems it has been built before, need to clean first\n";
         print $log "seems it has been built before, need to clean first\n";
-        system("$0 --clean") && die "clean failed: $!";
+        system("$0 --clean") && die 'clean failed.';
 
     }
 
@@ -252,8 +252,8 @@
           $skip_test ? '--skip-test' : (), $args{'force'} ? '--force' : (),
           $args{'clean'} ? '--clean' : ();
         if ( system($cmd) ) {
-            print $log "build $dir with failure: $!\n";
-            die "build $dir with failure: $!\n";
+            print $log "build $dir with failure.\n";
+            die "build $dir with failure.\n";
         }
     }
     else {
@@ -273,13 +273,13 @@
 
             print "we'll run the cmd: $cmd\n";
             if ( system($cmd) ) {
-                print $log "build $dir $type part with failure: $!\n";
+                print $log "build $dir $type part with failure.\n";
                 if ( $args{force} && $type eq 'test' ) {
                     print $log
 "although tests failed, will install anyway since we have force arg\n";
                 }
                 else {
-                    die "build $dir $type part with failure: $!\n";
+                    die "build $dir $type part with failure.\n";
                 }
             }
             else {
@@ -394,7 +394,7 @@
         my ( $type, $cmd ) = @$_;
         print $log "run tests $type part with cmd: $cmd\n";
         if ( system($cmd ) ) {
-            die "something wrong when execute $cmd: $?";
+            die "something wrong when execute $cmd.";
         }
         else {
             print $log "run test $type part with success\n";
@@ -463,10 +463,10 @@
     }
 
     if ( system($cmd) ) {
-        print $log "clean $dir with failure: $!\n";
+        print $log "clean $dir with failure.\n";
     }
     else {
-        print $log "clean $dir with success $!\n";
+        print $log "clean $dir with success.\n";
     }
 
     print '=' x 80, "\n";