[Bps-public-commit] r16818 - in Shipwright/trunk: . lib

sunnavy at bestpractical.com sunnavy at bestpractical.com
Wed Nov 12 11:38:44 EST 2008


Author: sunnavy
Date: Wed Nov 12 11:38:42 2008
New Revision: 16818

Modified:
   Shipwright/trunk/   (props changed)
   Shipwright/trunk/lib/Shipwright.pm
   Shipwright/trunk/lib/Shipwright/Util.pm

Log:
 r17709 at sunnavys-mb:  sunnavy | 2008-11-12 22:33:53 +0800
 put log file just in /tmp


Modified: Shipwright/trunk/lib/Shipwright.pm
==============================================================================
--- Shipwright/trunk/lib/Shipwright.pm	(original)
+++ Shipwright/trunk/lib/Shipwright.pm	Wed Nov 12 11:38:42 2008
@@ -16,7 +16,7 @@
 use Shipwright::Source;
 use Shipwright::Build;
 use File::Temp qw/tempfile/;
-use File::Spec::Functions qw/catfile/;
+use File::Spec::Functions qw/catfile tmpdir/;
 
 sub new {
     my $class = shift;
@@ -28,11 +28,7 @@
 
         # a better named log_file, in the name of repository
         my $info = join '', map { /\w/ ? $_ : '_' } split //, $args{repository};
-        $args{log_file} = tempfile(
-            "shipwright_${info}_XXXXXX",
-            TMPDIR => 1,
-            suffix => '.log',
-        );
+        $args{log_file} = catfile( tmpdir(), "shipwright_$info.log" );
     }
 
     my $self = {

Modified: Shipwright/trunk/lib/Shipwright/Util.pm
==============================================================================
--- Shipwright/trunk/lib/Shipwright/Util.pm	(original)
+++ Shipwright/trunk/lib/Shipwright/Util.pm	Wed Nov 12 11:38:42 2008
@@ -4,7 +4,7 @@
 use strict;
 use Carp;
 use IPC::Run3;
-use File::Spec::Functions qw/catfile catdir splitpath splitdir/;
+use File::Spec::Functions qw/catfile catdir splitpath splitdir tmpdir/;
 use File::Temp qw/tempfile/;
 use Cwd qw/abs_path/;
 
@@ -142,11 +142,7 @@
 
 open $null_fh, '>', '/dev/null';
 
-$cpan_log_path = tempfile(
-    'shipwright_cpan_XXXXXX',
-    TMPDIR => 1,
-    suffix => '.log',
-);
+$cpan_log_path = catfile( tmpdir(), 'shipwright_cpan.log');
 
 open $cpan_fh, '>>', $cpan_log_path;
 $stdout_fh = select;



More information about the Bps-public-commit mailing list