[Bps-public-commit] r17048 - in sd/trunk: . lib/App/SD/CLI/Command/Help lib/App/SD/Model lib/App/SD/Replica/hm lib/App/SD/Replica/rt

[spang at bestpractical.com]

Author: spang
Date: Fri Nov 28 14:03:50 2008
New Revision: 17048

Modified:
   sd/trunk/   (props changed)
   sd/trunk/lib/App/SD/CLI/Command/Help/Config.pm
   sd/trunk/lib/App/SD/Model/Ticket.pm
   sd/trunk/lib/App/SD/Replica/hm.pm
   sd/trunk/lib/App/SD/Replica/hm/PullEncoder.pm
   sd/trunk/lib/App/SD/Replica/rt/PullEncoder.pm

Log:
 r52804 at loki:  spang | 2008-11-28 10:35:39 -0500
 change 'reported_by' field to 'reporter' to be more consistent with 'creator'


Modified: sd/trunk/lib/App/SD/CLI/Command/Help/Config.pm
==============================================================================
--- sd/trunk/lib/App/SD/CLI/Command/Help/Config.pm	(original)
+++ sd/trunk/lib/App/SD/CLI/Command/Help/Config.pm	Fri Nov 28 14:03:50 2008
@@ -15,7 +15,7 @@
 
   email_address = foo\@bar.com
     Specifies an email address to use as the default for tickets'
-    reported_by field.
+    reporter field.
 
   summary_format_ticket = %4s },\$luid | %-11.11s,status | %-60.60s,summary
     Specifies how to format ticket summaries (when listing tickets, e.g.).

Modified: sd/trunk/lib/App/SD/Model/Ticket.pm
==============================================================================
--- sd/trunk/lib/App/SD/Model/Ticket.pm	(original)
+++ sd/trunk/lib/App/SD/Model/Ticket.pm	Fri Nov 28 14:03:50 2008
@@ -31,15 +31,15 @@
     return 1 if grep { $_ eq $self->prop('status') } @{$self->app_handle->setting(label => 'active_statuses')->get()};
 }
 
-=head2 default_prop_reported_by
+=head2 default_prop_reporter
 
-Returns a string of the default value of the C<reported_by> prop.
+Returns a string of the default value of the C<reporter> prop.
 (Currently, this is the config variable C<email_address> or
 the environmental variable C<EMAIL>.)
 
 =cut
 
-sub default_prop_reported_by {
+sub default_prop_reporter {
     shift->app_handle->config->get('email_address') or $ENV{EMAIL}
 }
 
@@ -152,7 +152,7 @@
 =cut
 
 sub props_to_show {
-    ('id', 'summary', 'status', 'owner', 'created', 'due', 'creator', 'reported_by', 'milestone', 'original_replica')
+    ('id', 'summary', 'status', 'owner', 'created', 'due', 'creator', 'reporter', 'milestone', 'original_replica')
 }
 
 =head2 immutable_props

Modified: sd/trunk/lib/App/SD/Replica/hm.pm
==============================================================================
--- sd/trunk/lib/App/SD/Replica/hm.pm	(original)
+++ sd/trunk/lib/App/SD/Replica/hm.pm	Fri Nov 28 14:03:50 2008
@@ -176,7 +176,7 @@
 
 our %PROP_MAP = (
     owner_id                 => 'owner',
-    requestor_id             => 'reported_by',
+    requestor_id             => 'reporter',
     priority                 => 'priority_integer',
     completed_at             => 'completed',
     due                      => 'due',

Modified: sd/trunk/lib/App/SD/Replica/hm/PullEncoder.pm
==============================================================================
--- sd/trunk/lib/App/SD/Replica/hm/PullEncoder.pm	(original)
+++ sd/trunk/lib/App/SD/Replica/hm/PullEncoder.pm	Fri Nov 28 14:03:50 2008
@@ -158,7 +158,7 @@
             $prop->name( $PROP_MAP{ lc( $prop->name ) } ) if $PROP_MAP{ lc( $prop->name ) };
             next if ( $prop->name eq '_delete' );
 
-            if ( $prop->name =~ /^(?:reported_by|owner|next_action_by)$/ ) {
+            if ( $prop->name =~ /^(?:reporter|owner|next_action_by)$/ ) {
                 $prop->old_value( $self->resolve_user_id_to_email( $prop->old_value ) );
                 $prop->new_value( $self->resolve_user_id_to_email( $prop->new_value ) );
             }

Modified: sd/trunk/lib/App/SD/Replica/rt/PullEncoder.pm
==============================================================================
--- sd/trunk/lib/App/SD/Replica/rt/PullEncoder.pm	(original)
+++ sd/trunk/lib/App/SD/Replica/rt/PullEncoder.pm	Fri Nov 28 14:03:50 2008
@@ -458,8 +458,8 @@
     initialpriority => '_delete',
     finalpriority   => '_delete',
     told            => '_delete',
-    requestor       => 'reported_by',
-    requestors      => 'reported_by',
+    requestor       => 'reporter',
+    requestors      => 'reporter',
     admincc         => 'admin_cc',
     refersto        => 'refers_to',
     referredtoby    => 'referred_to_by',