[Bps-public-commit] r16637 - in RT-Authen-ExternalAuth/branches/errorchecking: html/Callbacks/ExternalAuth/autohandler lib/RT/Authen

[falcone at bestpractical.com]

Author: falcone
Date: Fri Oct 31 08:06:48 2008
New Revision: 16637

Modified:
   RT-Authen-ExternalAuth/branches/errorchecking/   (props changed)
   RT-Authen-ExternalAuth/branches/errorchecking/ChangeLog
   RT-Authen-ExternalAuth/branches/errorchecking/html/Callbacks/ExternalAuth/autohandler/Auth
   RT-Authen-ExternalAuth/branches/errorchecking/lib/RT/Authen/ExternalAuth.pm

Log:
- Merge //mirror/bps-public/RT-Authen-ExternalAuth/trunk to //mirror/bps-public/RT-Authen-ExternalAuth/branches/errorchecking

Modified: RT-Authen-ExternalAuth/branches/errorchecking/ChangeLog
==============================================================================
--- RT-Authen-ExternalAuth/branches/errorchecking/ChangeLog	(original)
+++ RT-Authen-ExternalAuth/branches/errorchecking/ChangeLog	Fri Oct 31 08:06:48 2008
@@ -1,15 +1,53 @@
-v0.06_02    2008-10-17	Kevin Falcone <falcone at cpan.org>
+v0.06_03 2008-10-31    Mike Peachey <zordrak at cpan.org>
+                       Kevin Falcone <falcone at cpan.org>
+
+    * html/Callbacks/ExternalAuth/autohandler/Auth
+            
+        Add fix to work around a plugin bug in RT-3.8.0 & RT-3.8.1
+        preventing User_Vendor.pm overlay being required before
+        RT::User is loaded.
+        
+        Check the return value from calling RT::User::Create. 
+
+        Check the return value when loading an autocreated user.
+
+    * README
+            
+        Updated to talk about removing old files in local/.
+
+    * lib/RT/Authen/User_Vendor.pm
+
+        Added error-checking to complain if a an LDAP configuration is
+        in use, but no d_filter has been specified.
+
+    * lib/RT/Authen/ExternalAuth.pm
+
+        Version updated to 0.06_03.
+
+    * ChangeLog
+
+        General clean-up.
 
-	* update changelog
 
-v0.06_01    2008-10-17	Kevin Falcone <falcone at cpan.org>
+v0.06_02 2008-10-01    Kevin Falcone <falcone at cpan.org>
 
-	* lib/RT/Authen/User_Vendor.pm
+    * ChangeLog
+
+       Updates to previous release.
+
+    * lib/RT/Authen/ExternalAuth.pm
+
+        Version updated to 0.06_02.
+
+
+v0.06_01 2008-10-17    Kevin Falcone <falcone at cpan.org>
 
-	Add a patch to be compatible with 3.8
+    * lib/RT/Authen/User_Vendor.pm
+
+        Add a patch to be compatible with 3.8
+
+    * Upgrade Module::Install::RTx to work better with RT-3.8.x
 
-	* Upgrade Module::Install::RTx to work better
-	  with 3.8
 
 v0.05    2008-04-09    Mike Peachey <zordrak at cpan.org>
 
@@ -42,6 +80,7 @@
 
         Version updated to 0.05
 
+
 v0.04    2008-04-03    Mike Peachey <zordrak at cpan.org>
 
     * etc/RT_SiteConfig.pm
@@ -60,6 +99,7 @@
 
         Version updated to 0.04
 
+
 v0.03    2008-03-31    Mike Peachey <zordrak at cpan.org>
 
     * html/Callbacks/ExternalAuth/autohandler/Auth 
@@ -94,6 +134,7 @@
 
         Version updated to 0.03
 
+
 v0.02    2008-03-17    Mike Peachey <zordrak at cpan.org>
 
     * lib/RT/User_Vendor.pm
@@ -116,6 +157,7 @@
 
         Version updated to 0.02
 
+
 v0.01    2008-03-13    Mike Peachey <zordrak at cpan.org>
 
     * Initial Release

Modified: RT-Authen-ExternalAuth/branches/errorchecking/html/Callbacks/ExternalAuth/autohandler/Auth
==============================================================================
--- RT-Authen-ExternalAuth/branches/errorchecking/html/Callbacks/ExternalAuth/autohandler/Auth	(original)
+++ RT-Authen-ExternalAuth/branches/errorchecking/html/Callbacks/ExternalAuth/autohandler/Auth	Fri Oct 31 08:06:48 2008
@@ -1,5 +1,15 @@
 <%init>
 
+# If the RT::User::UpdateFromExternal method is not available, then we are in
+# RT-3.8.0 or RT-3.8.1 and we need to work around a bug in the plugin system:
+# Temporarily force RT to reload RT::User, since it isn't being loaded
+# correctly as a plugin.
+unless (RT::User->can('UpdateFromExternal')) {
+    $RT::Logger->error("Working around bug in RT and reloading RT::User");
+    delete $INC{'RT/User.pm'};
+    require RT::User;
+}
+
 # If the user is logging in, let's authenticate; if they can auth but don't load
 # (e.g. they don't have an account but external auth succeeds), we'll autocreate
 # their account.

Modified: RT-Authen-ExternalAuth/branches/errorchecking/lib/RT/Authen/ExternalAuth.pm
==============================================================================
--- RT-Authen-ExternalAuth/branches/errorchecking/lib/RT/Authen/ExternalAuth.pm	(original)
+++ RT-Authen-ExternalAuth/branches/errorchecking/lib/RT/Authen/ExternalAuth.pm	Fri Oct 31 08:06:48 2008
@@ -1,6 +1,6 @@
 package RT::Authen::ExternalAuth;
 
-our $VERSION = '0.06_02';
+our $VERSION = '0.06_03';
 
 =head1 NAME