[Bps-public-commit] App-Changeloggr branch, master, updated. 43393fe729b98999c8df2abd129a9bb27d64d33d

Alex M Vandiver alexmv at bestpractical.com
Wed Apr 1 15:05:19 EDT 2009


The branch, master has been updated
       via  43393fe729b98999c8df2abd129a9bb27d64d33d (commit)
       via  d5c70f354864caf7d8c66180e35448bfa3ab3975 (commit)
      from  845fa0abcc3c2cc45f54ee20876014cbe2812663 (commit)

Summary of changes:
 lib/App/Changeloggr/Action/CreateTag.pm |    4 ++--
 lib/App/Changeloggr/Model/Tag.pm        |    7 ++++---
 2 files changed, 6 insertions(+), 5 deletions(-)

- Log -----------------------------------------------------------------
commit d5c70f354864caf7d8c66180e35448bfa3ab3975
Author: Alex Vandiver <alexmv at mit.edu>
Date:   Wed Apr 1 15:04:21 2009 -0400

    Fix changelog_id to be hidden

diff --git a/lib/App/Changeloggr/Model/Tag.pm b/lib/App/Changeloggr/Model/Tag.pm
index b2384c9..844e1c6 100644
--- a/lib/App/Changeloggr/Model/Tag.pm
+++ b/lib/App/Changeloggr/Model/Tag.pm
@@ -8,7 +8,8 @@ use App::Changeloggr::Record schema {
     column changelog_id =>
         refers_to App::Changeloggr::Model::Changelog,
         is mandatory,
-        is immutable;
+        is immutable,
+        render as 'hidden';
 
     column text =>
         type is 'text',

commit 43393fe729b98999c8df2abd129a9bb27d64d33d
Author: Alex Vandiver <alexmv at mit.edu>
Date:   Wed Apr 1 15:02:01 2009 -0400

    More changelog => changelog_id fixes

diff --git a/lib/App/Changeloggr/Action/CreateTag.pm b/lib/App/Changeloggr/Action/CreateTag.pm
index 507dfdd..578baef 100644
--- a/lib/App/Changeloggr/Action/CreateTag.pm
+++ b/lib/App/Changeloggr/Action/CreateTag.pm
@@ -10,8 +10,8 @@ sub canonicalize_text {
     if (length $tag and not length($self->argument_value('hotkey')||'')) {
         my $possible = lc substr($tag, 0, 1);
         my $existing = App::Changeloggr::Model::TagCollection->new;
-        $existing->limit( column => 'changelog', value => $self->argument_value('changelog') );
-        $existing->limit( column => 'hotkey',    value => $possible );
+        $existing->limit( column => 'changelog_id', value => $self->argument_value('changelog_id') );
+        $existing->limit( column => 'hotkey',       value => $possible );
         $self->argument_value( hotkey => $possible ) unless $existing->count;
     }
     return $tag;
diff --git a/lib/App/Changeloggr/Model/Tag.pm b/lib/App/Changeloggr/Model/Tag.pm
index 844e1c6..cd5242d 100644
--- a/lib/App/Changeloggr/Model/Tag.pm
+++ b/lib/App/Changeloggr/Model/Tag.pm
@@ -32,8 +32,8 @@ sub validate_hotkey {
     my $args = shift || {};
     return 1 if not defined $key or not length $key;
     my $existing = App::Changeloggr::Model::TagCollection->new;
-    $existing->limit( column => 'changelog', value => $args->{changelog} || $self->changelog->id );
-    $existing->limit( column => 'hotkey',    value => $key );
+    $existing->limit( column => 'changelog_id', value => $args->{changelog_id} || $self->changelog->id );
+    $existing->limit( column => 'hotkey',       value => $key );
     return (0, "Duplicate key!") if $existing->first and ($existing->first->id != ($self->id||0));
     return 1;
 }

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list