[Bps-public-commit] App-Changeloggr branch, master, updated. f3d6ee3c32a20ab8fced4f1faa936d422ebc854b

sartak at bestpractical.com sartak at bestpractical.com
Wed Apr 29 11:45:06 EDT 2009


The branch, master has been updated
       via  f3d6ee3c32a20ab8fced4f1faa936d422ebc854b (commit)
      from  42c0616cd12495adff26f41ccd54b9482c5b9100 (commit)

Summary of changes:
 lib/App/Changeloggr/View.pm  |   24 ++++++++++++++++--------
 share/web/static/css/app.css |    9 ++++++++-
 2 files changed, 24 insertions(+), 9 deletions(-)

- Log -----------------------------------------------------------------
commit f3d6ee3c32a20ab8fced4f1faa936d422ebc854b
Author: Shawn M Moore <sartak at gmail.com>
Date:   Wed Apr 29 11:44:57 2009 -0400

    change display styling

diff --git a/lib/App/Changeloggr/View.pm b/lib/App/Changeloggr/View.pm
index 838835f..a95e93a 100644
--- a/lib/App/Changeloggr/View.pm
+++ b/lib/App/Changeloggr/View.pm
@@ -50,8 +50,7 @@ template '/vote-on-change' => sub {
     my $changelog = M('Changelog', id => get('changelog'));
     my $change = $changelog->choose_change;
     if ($change) {
-        show_change($change);
-        show_vote_form($change);
+        show_change($change, voting_form => 1);
     } else {
         my $has_changes = $changelog->changes->count;
         h2 { "No changes " . ($has_changes ? "left " : "") . " in this log" };
@@ -78,14 +77,23 @@ sub changelog_summary {
 
 sub show_change {
     my $change = shift;
+    my %args = @_;
 
-    h3 {
+    div {
         { class is "change" };
-        my $message = Jifty->web->escape($change->message);
-        my $links = $change->changelog->commit_links;
-        $message = $_->linkify($message) while $_ = $links->next;
-        outs_raw( $message );
-    }
+
+        h3 {
+            { class is "change_message" };
+            my $message = Jifty->web->escape($change->message);
+            my $links = $change->changelog->commit_links;
+            $message = $_->linkify($message) while $_ = $links->next;
+            outs_raw( $message );
+        };
+
+        if ($args{voting_form}) {
+            show_vote_form($change);
+        }
+    };
 }
 
 sub show_vote_form {
diff --git a/share/web/static/css/app.css b/share/web/static/css/app.css
index ecaf45e..60826da 100644
--- a/share/web/static/css/app.css
+++ b/share/web/static/css/app.css
@@ -69,7 +69,14 @@ dl.keybindings dd {
   display: block;
 }
 
-.change {
+.change_message {
   white-space: pre;
   font-family: monospace;
 }
+
+.change {
+  background: #224;
+  margin: 1em;
+  padding: 1em;
+  border: 5px solid #000;
+}

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list