[Bps-public-commit] r17688 - in Net-Google-Code/trunk: . lib/Net/Google/Code
sunnavy at bestpractical.com
sunnavy at bestpractical.com
Sun Jan 11 09:51:51 EST 2009
Author: sunnavy
Date: Sun Jan 11 09:51:51 2009
New Revision: 17688
Modified:
Net-Google-Code/trunk/ (props changed)
Net-Google-Code/trunk/lib/Net/Google/Code/Connection.pm
Net-Google-Code/trunk/lib/Net/Google/Code/Downloads.pm
Net-Google-Code/trunk/lib/Net/Google/Code/Home.pm
Net-Google-Code/trunk/lib/Net/Google/Code/Issue.pm
Net-Google-Code/trunk/lib/Net/Google/Code/IssueAttachment.pm
Net-Google-Code/trunk/lib/Net/Google/Code/IssueSearch.pm
Net-Google-Code/trunk/lib/Net/Google/Code/Wiki.pm
Net-Google-Code/trunk/lib/Net/Google/Code/WikiEntry.pm
Net-Google-Code/trunk/t/01.connection.t
Net-Google-Code/trunk/t/02.issue.t
Net-Google-Code/trunk/t/10.downloads.t
Net-Google-Code/trunk/t/11.wiki.t
Net-Google-Code/trunk/t/20.code.t
Log:
r18703 at sunnavys-mb: sunnavy | 2009-01-11 22:51:36 +0800
connection->_fetch => connection->fetch
Modified: Net-Google-Code/trunk/lib/Net/Google/Code/Connection.pm
==============================================================================
--- Net-Google-Code/trunk/lib/Net/Google/Code/Connection.pm (original)
+++ Net-Google-Code/trunk/lib/Net/Google/Code/Connection.pm Sun Jan 11 09:51:51 2009
@@ -31,7 +31,7 @@
}
);
-sub _fetch {
+sub fetch {
my $self = shift;
my $query = shift;
my $abs_url;
@@ -74,6 +74,8 @@
=head1 INTERFACE
+=head2 fetch
+
=head1 AUTHOR
sunnavy C<< <sunnavy at bestpractical.com> >>
Modified: Net-Google-Code/trunk/lib/Net/Google/Code/Downloads.pm
==============================================================================
--- Net-Google-Code/trunk/lib/Net/Google/Code/Downloads.pm (original)
+++ Net-Google-Code/trunk/lib/Net/Google/Code/Downloads.pm Sun Jan 11 09:51:51 2009
@@ -20,7 +20,7 @@
my $project = $self->parent->project;
my $feed_url = "http://code.google.com/feeds/p/$project/downloads/basic";
- my $content = $connection->_fetch( $feed_url );
+ my $content = $connection->fetch( $feed_url );
my $feed = XML::Atom::Feed->new( \$content );
my @fentries = $feed->entries;
@@ -53,7 +53,7 @@
my $project = $self->parent->project;
my $url = "http://code.google.com/p/$project/downloads/detail?name=$filename";
- my $content = $connection->_fetch( $url );
+ my $content = $connection->fetch( $url );
require HTML::TreeBuilder;
my $tree = HTML::TreeBuilder->new;
Modified: Net-Google-Code/trunk/lib/Net/Google/Code/Home.pm
==============================================================================
--- Net-Google-Code/trunk/lib/Net/Google/Code/Home.pm (original)
+++ Net-Google-Code/trunk/lib/Net/Google/Code/Home.pm Sun Jan 11 09:51:51 2009
@@ -20,7 +20,7 @@
my $connection = $self->parent->connection;
- my $content = $connection->_fetch( $self->parent->url );
+ my $content = $connection->fetch( $self->parent->url );
return $content;
}
);
Modified: Net-Google-Code/trunk/lib/Net/Google/Code/Issue.pm
==============================================================================
--- Net-Google-Code/trunk/lib/Net/Google/Code/Issue.pm (original)
+++ Net-Google-Code/trunk/lib/Net/Google/Code/Issue.pm Sun Jan 11 09:51:51 2009
@@ -44,7 +44,7 @@
my $self = shift;
my ($id) = validate_pos( @_, { type => SCALAR } );
$self->state->{id} = $id;
- my $content = $self->connection->_fetch( "/issues/detail?id=" . $id );
+ my $content = $self->connection->fetch( "/issues/detail?id=" . $id );
$self->parse( $content );
return $id;
}
Modified: Net-Google-Code/trunk/lib/Net/Google/Code/IssueAttachment.pm
==============================================================================
--- Net-Google-Code/trunk/lib/Net/Google/Code/IssueAttachment.pm (original)
+++ Net-Google-Code/trunk/lib/Net/Google/Code/IssueAttachment.pm Sun Jan 11 09:51:51 2009
@@ -49,7 +49,7 @@
sub content {
my $self = shift;
- return $self->connection->_fetch( $self->url );
+ return $self->connection->fetch( $self->url );
}
Modified: Net-Google-Code/trunk/lib/Net/Google/Code/IssueSearch.pm
==============================================================================
--- Net-Google-Code/trunk/lib/Net/Google/Code/IssueSearch.pm (original)
+++ Net-Google-Code/trunk/lib/Net/Google/Code/IssueSearch.pm Sun Jan 11 09:51:51 2009
@@ -50,7 +50,7 @@
}
my $mech = $self->connection->mech;
- $self->connection->_fetch('/issues/list');
+ $self->connection->fetch('/issues/list');
$mech->submit_form(
form_number => 2,
fields => {
Modified: Net-Google-Code/trunk/lib/Net/Google/Code/Wiki.pm
==============================================================================
--- Net-Google-Code/trunk/lib/Net/Google/Code/Wiki.pm (original)
+++ Net-Google-Code/trunk/lib/Net/Google/Code/Wiki.pm Sun Jan 11 09:51:51 2009
@@ -21,7 +21,7 @@
my $project = $self->parent->project;
my $wiki_svn = "http://$project.googlecode.com/svn/wiki/";
- my $content = $connection->_fetch( $wiki_svn );
+ my $content = $connection->fetch( $wiki_svn );
# regex would be OK
my @lines = split("\n", $content);
Modified: Net-Google-Code/trunk/lib/Net/Google/Code/WikiEntry.pm
==============================================================================
--- Net-Google-Code/trunk/lib/Net/Google/Code/WikiEntry.pm (original)
+++ Net-Google-Code/trunk/lib/Net/Google/Code/WikiEntry.pm Sun Jan 11 09:51:51 2009
@@ -26,7 +26,7 @@
my $project = $self->parent->project;
my $wiki_url = "http://$project.googlecode.com/svn/wiki/$name.wiki";
- my $content = $connection->_fetch( $wiki_url );
+ my $content = $connection->fetch( $wiki_url );
return $content;
}
@@ -45,7 +45,7 @@
# http://code.google.com/p/net-google-code/wiki/TestPage
my $wiki_url = "http://code.google.com/p/$project/wiki/$name";
- my $content = $connection->_fetch( $wiki_url );
+ my $content = $connection->fetch( $wiki_url );
return $content;
}
Modified: Net-Google-Code/trunk/t/01.connection.t
==============================================================================
--- Net-Google-Code/trunk/t/01.connection.t (original)
+++ Net-Google-Code/trunk/t/01.connection.t Sun Jan 11 09:51:51 2009
@@ -17,4 +17,4 @@
$mech->mock( 'response', sub { HTTP::Response->new } );
$resp->mock( 'is_success', sub { 1 } );
-is( $connection->_fetch('blabla'), 'content', '_fetch' );
+is( $connection->fetch('blabla'), 'content', 'fetch' );
Modified: Net-Google-Code/trunk/t/02.issue.t
==============================================================================
--- Net-Google-Code/trunk/t/02.issue.t (original)
+++ Net-Google-Code/trunk/t/02.issue.t Sun Jan 11 09:51:51 2009
@@ -14,7 +14,7 @@
my $mock_connection = Test::MockModule->new('Net::Google::Code::Connection');
$mock_connection->mock(
- '_fetch',
+ 'fetch',
sub { $content }
);
Modified: Net-Google-Code/trunk/t/10.downloads.t
==============================================================================
--- Net-Google-Code/trunk/t/10.downloads.t (original)
+++ Net-Google-Code/trunk/t/10.downloads.t Sun Jan 11 09:51:51 2009
@@ -17,7 +17,7 @@
my $mock_connection = Test::MockModule->new('Net::Google::Code::Connection');
$mock_connection->mock(
- '_fetch',
+ 'fetch',
sub {
( undef, my $uri ) = @_;
if ( $uri eq 'http://code.google.com/feeds/p/net-google-code/downloads/basic' ) {
Modified: Net-Google-Code/trunk/t/11.wiki.t
==============================================================================
--- Net-Google-Code/trunk/t/11.wiki.t (original)
+++ Net-Google-Code/trunk/t/11.wiki.t Sun Jan 11 09:51:51 2009
@@ -18,7 +18,7 @@
my $mock_connection = Test::MockModule->new('Net::Google::Code::Connection');
$mock_connection->mock(
- '_fetch',
+ 'fetch',
sub {
( undef, my $uri ) = @_;
if ( $uri eq 'http://foorum.googlecode.com/svn/wiki/' ) {
Modified: Net-Google-Code/trunk/t/20.code.t
==============================================================================
--- Net-Google-Code/trunk/t/20.code.t (original)
+++ Net-Google-Code/trunk/t/20.code.t Sun Jan 11 09:51:51 2009
@@ -14,7 +14,7 @@
my $mock_connection = Test::MockModule->new('Net::Google::Code::Connection');
$mock_connection->mock(
- '_fetch',
+ 'fetch',
sub {
( undef, my $uri ) = @_;
if ( $uri eq 'http://code.google.com/p/net-google-code/' ) {
More information about the Bps-public-commit
mailing list