[Bps-public-commit] UNNAMED PROJECT branch, master, updated. 56b578d26a5bf362dec6b86e3d304e9de57343ee
spang at bestpractical.com
spang at bestpractical.com
Fri Jan 16 10:08:08 EST 2009
The branch, master has been updated
via 56b578d26a5bf362dec6b86e3d304e9de57343ee (commit)
via 94cf448670d7a8506ad0592fc469b2a3d2022f66 (commit)
from 28f9b4dfddb4d8ac719ec6a7779ba0aa24908f7a (commit)
Summary of changes:
lib/App/SD.pm | 2 +-
lib/App/SD/CLI/Command/Help/Search.pm | 2 +-
lib/App/SD/CLI/Command/Help/Tickets.pm | 2 +-
lib/App/SD/CLI/Model/Ticket.pm | 2 +-
lib/App/SD/Model/Ticket.pm | 2 +-
t/03-update-ticket-with-editor.t | 20 ++++++++++----------
6 files changed, 15 insertions(+), 15 deletions(-)
- Log -----------------------------------------------------------------
commit 94cf448670d7a8506ad0592fc469b2a3d2022f66
Author: Christine Spang <spang at bestpractical.com>
Date: Fri Jan 16 17:04:00 2009 +0200
rename vague default_props_to_show to common_ticket_props
diff --git a/lib/App/SD.pm b/lib/App/SD.pm
index 949d315..5aace01 100644
--- a/lib/App/SD.pm
+++ b/lib/App/SD.pm
@@ -23,7 +23,7 @@ sub database_settings {
default_milestone => ['BAB613BD-9E25-4612-8DE3-21E4572859EA' => 'alpha'],
project_name => ['3B4B297C-906F-4018-9829-F7CC672274C9' => 'Your SD Project'],
- default_props_to_show => ['3f0a074f-af13-406f-bf7b-d69bbf360720' => qw/id summary status milestone component owner created due creator reporter original_replica/],
+ common_ticket_props => ['3f0a074f-af13-406f-bf7b-d69bbf360720' => qw/id summary status milestone component owner created due creator reporter original_replica/],
prop_descriptions => ['c1bced3a-ad2c-42c4-a502-4149205060f1',
{ summary =>
"a one-line summary of what this ticket is about",
diff --git a/lib/App/SD/CLI/Command/Help/Search.pm b/lib/App/SD/CLI/Command/Help/Search.pm
index b90dea4..ad55ff8 100644
--- a/lib/App/SD/CLI/Command/Help/Search.pm
+++ b/lib/App/SD/CLI/Command/Help/Search.pm
@@ -34,7 +34,7 @@ print <<EOF
$cmd ticket show 1234 --all-props
Show all properties of the given ticket, even if they aren't in
- the database setting default_props_to_show.
+ the database setting common_ticket_props.
$cmd ticket show 1234 --skip-history
Show only metadata and comments for the ticket 1234 (but not
diff --git a/lib/App/SD/CLI/Command/Help/Tickets.pm b/lib/App/SD/CLI/Command/Help/Tickets.pm
index 192db0f..e495e4e 100644
--- a/lib/App/SD/CLI/Command/Help/Tickets.pm
+++ b/lib/App/SD/CLI/Command/Help/Tickets.pm
@@ -35,7 +35,7 @@ print <<EOF
$cmd ticket update 123 --all-props
Interactively update the ticket with local id 123 in a text
editor, presenting all the props of the record for editing instead of
- just those specified by the database setting 'default_props_to_show'.
+ just those specified by the database setting 'common_ticket_props'.
$cmd ticket update fad5849a-67f1-11dd-bde1-5b33d3ff2799 -- status=closed
Sets the status of the ticket with uuid
diff --git a/lib/App/SD/Model/Ticket.pm b/lib/App/SD/Model/Ticket.pm
index 3e2ee3b..2e0dcb0 100644
--- a/lib/App/SD/Model/Ticket.pm
+++ b/lib/App/SD/Model/Ticket.pm
@@ -182,7 +182,7 @@ sub props_to_show {
my $self = shift;
my $args = shift || {};
my $props_list = $self->app_handle->setting(label =>
- 'default_props_to_show')->get();
+ 'common_ticket_props')->get();
return @{$props_list} unless $args->{'verbose'};
diff --git a/t/03-update-ticket-with-editor.t b/t/03-update-ticket-with-editor.t
index a73fc83..930e1d5 100644
--- a/t/03-update-ticket-with-editor.t
+++ b/t/03-update-ticket-with-editor.t
@@ -14,11 +14,11 @@ run_script( 'sd', [ 'init']);
my $replica_uuid = replica_uuid;
diag('changing settings to enable different behaviour with --verbose arg');
-run_output_matches( 'sd', [ 'settings', '--set', '--', 'default_props_to_show',
+run_output_matches( 'sd', [ 'settings', '--set', '--', 'common_ticket_props',
'["id","summary","status","milestone","owner","created","due","creator","reporter","original_replica"]' ],
[
- 'Trying to change default_props_to_show from ["id","summary","status","milestone","component","owner","created","due","creator","reporter","original_replica"] to ["id","summary","status","milestone","owner","created","due","creator","reporter","original_replica"].',
- 'Changed default_props_to_show from ["id","summary","status","milestone","component","owner","created","due","creator","reporter","original_replica"] to ["id","summary","status","milestone","owner","created","due","creator","reporter","original_replica"].',
+ 'Trying to change common_ticket_props from ["id","summary","status","milestone","component","owner","created","due","creator","reporter","original_replica"] to ["id","summary","status","milestone","owner","created","due","creator","reporter","original_replica"].',
+ 'Changed common_ticket_props from ["id","summary","status","milestone","component","owner","created","due","creator","reporter","original_replica"] to ["id","summary","status","milestone","owner","created","due","creator","reporter","original_replica"].',
]
);
@@ -46,7 +46,7 @@ App::SD::Test->set_editor("ticket-update-editor.pl --no-args $replica_uuid $tick
# update it
my ($comment_id, $comment_uuid) = App::SD::Test->update_ticket_with_editor_ok($ticket_id, $ticket_uuid);
-# check output -- component prop should be hidden by default_props_to_show
+# check output -- component prop should be hidden by common_ticket_props
run_output_matches( 'sd', [ 'ticket', 'basics', '--batch', '--id', $ticket_id ],
[
"id: $ticket_id ($ticket_uuid)",
@@ -86,7 +86,7 @@ App::SD::Test->set_editor("ticket-update-editor.pl --all-props $replica_uuid $ti
# template should show the hidden component prop
($comment_id, $comment_uuid) = App::SD::Test->update_ticket_with_editor_ok($ticket_id, $ticket_uuid, '--all-props');
-# check output -- component prop should be hidden by default_props_to_show
+# check output -- component prop should be hidden by common_ticket_props
run_output_matches( 'sd', [ 'ticket', 'basics', '--batch', '--id', $ticket_id ],
[
"id: $ticket_id ($ticket_uuid)",
@@ -109,7 +109,7 @@ App::SD::Test->set_editor("ticket-update-editor.pl --verbose $replica_uuid $tick
# update it
($comment_id, $comment_uuid) = App::SD::Test->update_ticket_with_editor_ok($ticket_id, $ticket_uuid, '--verbose');
-# check output -- component prop should be hidden by default_props_to_show
+# check output -- component prop should be hidden by common_ticket_props
run_output_matches( 'sd', [ 'ticket', 'basics', '--batch', '--id', $ticket_id ],
[
"id: $ticket_id ($ticket_uuid)",
@@ -132,11 +132,11 @@ App::SD::Test->set_editor("ticket-update-editor.pl --verbose-and-all $replica_uu
diag('changing settings for regression test: make sure props aren\'t deleted');
diag('if they weren\'t presented for editing in the first place');
-run_output_matches( 'sd', [ 'settings', '--set', '--', 'default_props_to_show',
+run_output_matches( 'sd', [ 'settings', '--set', '--', 'common_ticket_props',
'["id","summary","status","milestone","owner","created","due","creator","original_replica"]' ],
[
- 'Trying to change default_props_to_show from ["id","summary","status","milestone","owner","created","due","creator","reporter","original_replica"] to ["id","summary","status","milestone","owner","created","due","creator","original_replica"].',
- 'Changed default_props_to_show from ["id","summary","status","milestone","owner","created","due","creator","reporter","original_replica"] to ["id","summary","status","milestone","owner","created","due","creator","original_replica"].',
+ 'Trying to change common_ticket_props from ["id","summary","status","milestone","owner","created","due","creator","reporter","original_replica"] to ["id","summary","status","milestone","owner","created","due","creator","original_replica"].',
+ 'Changed common_ticket_props from ["id","summary","status","milestone","owner","created","due","creator","reporter","original_replica"] to ["id","summary","status","milestone","owner","created","due","creator","original_replica"].',
]
);
@@ -155,7 +155,7 @@ run_output_matches( 'sd', [ 'ticket', 'basics', '--batch', '--id', $ticket_id, '
qr/^created: \d{4}-\d{2}-\d{2}.+$/,
qr/^creator: /,
"original_replica: $replica_uuid",
- # no ordering is imposed on props not in default_props_to_show
+ # no ordering is imposed on props not in common_ticket_props
qr/(?:reporter: $ENV{EMAIL}|component: core)/,
qr/(?:reporter: $ENV{EMAIL}|component: core)/,
]
commit 56b578d26a5bf362dec6b86e3d304e9de57343ee
Author: Christine Spang <spang at bestpractical.com>
Date: Fri Jan 16 17:07:49 2009 +0200
props will soon be able to be force-set, so 'valid' is not quite the right word to use here
diff --git a/lib/App/SD/CLI/Model/Ticket.pm b/lib/App/SD/CLI/Model/Ticket.pm
index 24d4186..fe53bf1 100644
--- a/lib/App/SD/CLI/Model/Ticket.pm
+++ b/lib/App/SD/CLI/Model/Ticket.pm
@@ -209,7 +209,7 @@ sub _build_kv_pairs {
if ( ($args{record}->recommended_values_for_prop($prop))[0] ) {
my @valid_values =
$args{record}->recommended_values_for_prop($prop);
- $string .= "# valid values for $prop: ".
+ $string .= "# recommended values for $prop: ".
join(', ', @valid_values)."\n";
}
}
-----------------------------------------------------------------------
More information about the Bps-public-commit
mailing list