[Bps-public-commit] SD - A distributed issue tracker branch, master, updated. 0934ed05485a48e35f7153a1492e5604e5172dc5

[spang at bestpractical.com]

The branch, master has been updated
       via  0934ed05485a48e35f7153a1492e5604e5172dc5 (commit)
       via  be75f8bf8883520d81cc0b8fe6922b76c917496f (commit)
      from  609ed4b5e551192036c95dbf3c15f3de11798f43 (commit)

Summary of changes:
 lib/App/SD/CLI/Command/Help/Config.pm  |    7 +++++++
 lib/App/SD/CLI/Command/Help/Search.pm  |    3 ++-
 lib/App/SD/CLI/Command/Help/Tickets.pm |    3 ++-
 lib/App/SD/Model/Ticket.pm             |    6 ++++--
 4 files changed, 15 insertions(+), 4 deletions(-)

- Log -----------------------------------------------------------------
commit be75f8bf8883520d81cc0b8fe6922b76c917496f
Author: Christine Spang <spang at bestpractical.com>
Date:   Mon Jan 19 20:08:19 2009 +0200

    check to see if there is a local common_ticket_props config var before falling back to the db-wide setting

diff --git a/lib/App/SD/Model/Ticket.pm b/lib/App/SD/Model/Ticket.pm
index 2eee4b6..e637217 100644
--- a/lib/App/SD/Model/Ticket.pm
+++ b/lib/App/SD/Model/Ticket.pm
@@ -200,8 +200,10 @@ an update.)
 sub props_to_show {
     my $self = shift;
     my $args = shift || {};
-    my $props_list = $self->app_handle->setting(label =>
-        'common_ticket_props')->get();
+    my @props_from_config = split(',',
+        ($self->app_handle->config->get('common_ticket_props') || ''));
+    my $props_list = @props_from_config ? \@props_from_config :
+        $self->app_handle->setting(label => 'common_ticket_props')->get();
 
     return @{$props_list} unless $args->{'verbose'};
 

commit 0934ed05485a48e35f7153a1492e5604e5172dc5
Author: Christine Spang <spang at bestpractical.com>
Date:   Mon Jan 19 20:12:42 2009 +0200

    update help for common_ticket_props config

diff --git a/lib/App/SD/CLI/Command/Help/Config.pm b/lib/App/SD/CLI/Command/Help/Config.pm
index 8774775..c48053e 100644
--- a/lib/App/SD/CLI/Command/Help/Config.pm
+++ b/lib/App/SD/CLI/Command/Help/Config.pm
@@ -36,6 +36,13 @@ Currently, the following configuration variables are available:
       be overridden by passing the '--show-history' arg to the
       command.
 
+    common_ticket_props = id,summary,status,owner,created,original_replica
+      A comma-separated list of ticket properties that are most-often
+      used. These properties will be shown by default in the 'ticket
+      show' command and presented for editing when interactively
+      creating or updating tickets. (Overrides the database-wide
+      setting of the same name.)
+
 For information on environmental variables that can affect SD, see
 '$cmd help environment'.
 EOF
diff --git a/lib/App/SD/CLI/Command/Help/Search.pm b/lib/App/SD/CLI/Command/Help/Search.pm
index ad55ff8..d79685d 100644
--- a/lib/App/SD/CLI/Command/Help/Search.pm
+++ b/lib/App/SD/CLI/Command/Help/Search.pm
@@ -34,7 +34,8 @@ print <<EOF
 
     $cmd ticket show 1234 --all-props
       Show all properties of the given ticket, even if they aren't in
-      the database setting common_ticket_props.
+      the database setting common_ticket_props (or local configuration
+      variable 'common_ticket_props' if it exists).
 
     $cmd ticket show 1234 --skip-history
       Show only metadata and comments for the ticket 1234 (but not
diff --git a/lib/App/SD/CLI/Command/Help/Tickets.pm b/lib/App/SD/CLI/Command/Help/Tickets.pm
index e495e4e..3aa19d8 100644
--- a/lib/App/SD/CLI/Command/Help/Tickets.pm
+++ b/lib/App/SD/CLI/Command/Help/Tickets.pm
@@ -35,7 +35,8 @@ print <<EOF
     $cmd ticket update 123 --all-props
       Interactively update the ticket with local id 123 in a text
       editor, presenting all the props of the record for editing instead of
-      just those specified by the database setting 'common_ticket_props'.
+      just those specified by the database setting 'common_ticket_props'
+      (or local configuration variable 'common_ticket_props' if it exists).
 
     $cmd ticket update fad5849a-67f1-11dd-bde1-5b33d3ff2799 -- status=closed
       Sets the status of the ticket with uuid

-----------------------------------------------------------------------