[Bps-public-commit] r19855 - Net-Google-Code/trunk/lib/Net/Google/Code/Issue

[sunnavy at bestpractical.com]

Author: sunnavy
Date: Wed Jun  3 04:26:06 2009
New Revision: 19855

Modified:
   Net-Google-Code/trunk/lib/Net/Google/Code/Issue/Search.pm

Log:
make arguments consistent: columns => colspec

Modified: Net-Google-Code/trunk/lib/Net/Google/Code/Issue/Search.pm
==============================================================================
--- Net-Google-Code/trunk/lib/Net/Google/Code/Issue/Search.pm	(original)
+++ Net-Google-Code/trunk/lib/Net/Google/Code/Issue/Search.pm	Wed Jun  3 04:26:06 2009
@@ -48,13 +48,11 @@
     default => ''
 );
 
-has 'columns' => (
-    isa     => 'ArrayRef[Str]',
+has 'colspec' => (
+    isa     => 'Str',
     is      => 'rw',
     lazy    => 1,
-    default => sub {
-        [qw/ID Type Status Priority Milestone Owner Summary/];
-    },
+    default => 'ID+Type+Status+Priority+Milestone+Owner+Summary+Modified',
 );
 
 has 'results' => (
@@ -79,7 +77,7 @@
     my $self = shift;
     if ( scalar @_ ) {
         my %args = @_;
-        for my $attr (qw/can q limit sort columns/) {
+        for my $attr (qw/can q limit sort colspec/) {
             $self->$attr( $args{$attr} )       if defined $args{$attr};
         }
         $self->load_after_search( $args{load_after_search} )
@@ -87,13 +85,13 @@
     }
 
     my $mech = $self->mech;
-    $self->fetch( $self->base_url
-            . 'issues/list'
-            . '?can=' . $self->can
-            . ';sort=' .$self->sort 
-            . ';q=' .   $self->q 
-            . ';colspec=' . join( '+', @{$self->columns} )
-            );
+    my $url = $self->base_url . 'issues/list?';
+    for my $attr ( qw/can q sort colspec/ ) {
+        next unless defined $self->$attr;
+        $url .= $attr . '=' . $self->$attr . ';';
+    }
+    $self->fetch( $url );
+
     die "Server threw an error " . $mech->response->status_line . 'when search'
       unless $mech->response->is_success;