[Bps-public-commit] SD branch, master, updated. 7402ff5643a991375f5f784b5d14957523d8ca5a

[jesse]

The branch, master has been updated
       via  7402ff5643a991375f5f784b5d14957523d8ca5a (commit)
       via  8d949e32df6b7f6b43f6849259354dc345cc958e (commit)
       via  744bf184defdb2c5ba93363d32c5f0ff9cc7be7a (commit)
      from  0d2b273968b51c88e0653b795372644f410a7c60 (commit)

Summary of changes:
 lib/App/SD/Replica/gcode/PullEncoder.pm |    3 ++-
 lib/App/SD/Replica/trac/PullEncoder.pm  |    2 +-
 tools/shipwright-package                |    3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 744bf184defdb2c5ba93363d32c5f0ff9cc7be7a
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Fri Jun 5 14:40:51 2009 -0400

    Now we package Net::Google::Code

diff --git a/tools/shipwright-package b/tools/shipwright-package
index 7c89ff4..83073a7 100644
--- a/tools/shipwright-package
+++ b/tools/shipwright-package
@@ -25,12 +25,13 @@ $IMPORT \
  cpan:Net::Jifty \
  cpan:Net::Trac \
  git:git+ssh://fsck.com/git/sd.git
+$IMPORT svn://fsck.com/Net-Google-Code/trunk Net-Google-Code
 cd /tmp
 rm -rf sdex
 #shipwright update -r $SVN_PATH cpan-Module-Build --add-deps cpan-Pod-Simple
 #shipwright update -r $SVN_PATH cpan-IO-Compress-Base --add-deps cpan-Scalar-List-Utils
 shipwright update -r $SVN_PATH prophet.git      --add-deps cpan-Term-ReadLine-Perl,cpan-TermReadKey,cpan-DBD-SQLite,cpan-File-ShareDir,cpan-HTTP-Server-Simple,cpan-JSON-XS
-shipwright update -r $SVN_PATH sd.git           --add-deps prophet.git,cpan-Net-Bonjour,cpan-Email-Address,cpan-Net-Trac,cpan-RT-Client-REST
+shipwright update -r $SVN_PATH sd.git           --add-deps prophet.git,cpan-Net-Bonjour,cpan-Email-Address,cpan-Net-Trac,cpan-RT-Client-REST,Net-Google-Code
 shipwright maintain -r $SVN_PATH --update-order
 cd /tmp
 mkdir svnhack-$$

commit 8d949e32df6b7f6b43f6849259354dc345cc958e
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Fri Jun 5 14:41:15 2009 -0400

    google code uses '----' as "empty"
    Arguably Net::Google::Code should to, but we'll do it ourselves

diff --git a/lib/App/SD/Replica/gcode/PullEncoder.pm b/lib/App/SD/Replica/gcode/PullEncoder.pm
index e510f04..d2eb600 100644
--- a/lib/App/SD/Replica/gcode/PullEncoder.pm
+++ b/lib/App/SD/Replica/gcode/PullEncoder.pm
@@ -54,7 +54,7 @@ sub _translate_final_ticket_state {
 
     # delete undefined and empty fields
     delete $ticket_data->{$_}
-      for grep { !defined $ticket_data->{$_} || $ticket_data->{$_} eq '' }
+      for grep { !defined $ticket_data->{$_} || $ticket_data->{$_} eq '' || $ticket_data->{$_} eq '----' }
       keys %$ticket_data;
 
     return $ticket_data;
@@ -116,6 +116,7 @@ sub translate_ticket_state {
         for my $prop (qw(owner status cc summary)) {
             next unless exists $updates->{$prop};
             my $value = delete $updates->{$prop};
+            $value = '' if ($value eq '----');
             if ( my $sub = $self->can( 'translate_prop_' . $prop ) ) {
                 $value = $sub->( $self, $value );
             }

commit 7402ff5643a991375f5f784b5d14957523d8ca5a
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Fri Jun 5 14:41:44 2009 -0400

    quiet a debug message

diff --git a/lib/App/SD/Replica/trac/PullEncoder.pm b/lib/App/SD/Replica/trac/PullEncoder.pm
index a2fd2f1..369c872 100644
--- a/lib/App/SD/Replica/trac/PullEncoder.pm
+++ b/lib/App/SD/Replica/trac/PullEncoder.pm
@@ -106,7 +106,7 @@ sub find_matching_transactions {
                       serial => $txn->date->epoch,
                       object => $txn};
     }
-    $self->sync_source->log('Done looking at pulled txns');
+    $self->sync_source->log_debug('Done looking at pulled txns');
     return \@txns;
 }
 

-----------------------------------------------------------------------