[Bps-public-commit] Prophet branch, master, updated. 0.73-7-gaa68df8
Kevin Falcone
falcone at bestpractical.com
Tue Oct 6 16:47:45 EDT 2009
The branch, master has been updated
via aa68df8727287f98f57a36f15e6438b577696372 (commit)
from dd6a670a81f29bb26e4ef6dadb7c6cbd19439e54 (commit)
Summary of changes:
lib/Prophet/Web/Menu.pm | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
- Log -----------------------------------------------------------------
commit aa68df8727287f98f57a36f15e6438b577696372
Author: Florian Ragwitz <rafl at debian.org>
Date: Tue Oct 6 22:25:05 2009 +0200
Don't create an accessor for Web::Menu::url
It's defined explicitly later in the file. Creating the accessor anyway and
just applying modifiers to it would be better. Having another attribute to hold
the lazy-built URI instance and a trigger on url to clear that when a new url
is set would be even better.
diff --git a/lib/Prophet/Web/Menu.pm b/lib/Prophet/Web/Menu.pm
index dd87751..de0e826 100644
--- a/lib/Prophet/Web/Menu.pm
+++ b/lib/Prophet/Web/Menu.pm
@@ -8,7 +8,7 @@ has label => ( isa => 'Str', is => 'rw');
has parent => ( isa => 'Prophet::Web::Menu|Undef', is => 'rw', weak_ref => 1);
has sort_order => ( isa => 'Str', is => 'rw');
has render_children_inline => ( isa => 'Bool', is => 'rw', default => 0);
-has url => ( isa => 'Str', is => 'rw');
+has url => ( isa => 'Str', is => 'bare');
has target => ( isa => 'Str', is => 'rw');
has class => ( isa => 'Str', is => 'rw');
has escape_label => ( isa => 'Bool', is => 'rw');
-----------------------------------------------------------------------
More information about the Bps-public-commit
mailing list