[Bps-public-commit] SD branch, master, updated. 0.74-61-g4448218

[Thomas Sibley]

The branch, master has been updated
       via  444821833ac3c159f92ef6261a56500cbbb0590d (commit)
       via  a850160138c667a264236a2d2e7646fcb2308f06 (commit)
      from  c94e33c2b44d67ee5b8149dfdaf0438fdb37d8fb (commit)

Summary of changes:
 lib/App/SD/Replica/hm.pm             |    3 ++-
 lib/App/SD/Replica/hm/PullEncoder.pm |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit a850160138c667a264236a2d2e7646fcb2308f06
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Dec 7 10:00:09 2010 -0500

    Set the foreign_username after possibly getting it from the config or prompt
    
    Otherwise the foreign_username attribute remains undef in many cases.

diff --git a/lib/App/SD/Replica/hm.pm b/lib/App/SD/Replica/hm.pm
index db605b8..8dccb18 100644
--- a/lib/App/SD/Replica/hm.pm
+++ b/lib/App/SD/Replica/hm.pm
@@ -49,7 +49,6 @@ sub BUILD {
         $uri->userinfo(undef);
     }
     $self->remote_url("$uri");
-    $self->foreign_username($username) if ($username);
 
     ( $username, $password )
         = $self->prompt_for_login(
@@ -57,6 +56,8 @@ sub BUILD {
             username => $username,
         ) unless $password;
 
+    $self->foreign_username($username) if ($username);
+
     if ($props) {
         my %props = split /=|;/, $props;
         $self->props( \%props );

commit 444821833ac3c159f92ef6261a56500cbbb0590d
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Dec 7 10:01:10 2010 -0500

    add_prop_change expects a paramhash, not a hashref

diff --git a/lib/App/SD/Replica/hm/PullEncoder.pm b/lib/App/SD/Replica/hm/PullEncoder.pm
index dc1e018..a88bb19 100644
--- a/lib/App/SD/Replica/hm/PullEncoder.pm
+++ b/lib/App/SD/Replica/hm/PullEncoder.pm
@@ -151,7 +151,7 @@ sub recode_create {
         for qw(id record_locator);
 
     while ( my ( $k, $v ) = each %{ $args{'task'} } ) {
-        $res->add_prop_change( { name => $k, old => undef, new => $v } );
+        $res->add_prop_change( name => $k, old => undef, new => $v );
     }
     return $res;
 }

-----------------------------------------------------------------------