[Bps-public-commit] Net-Trac branch, master, updated. 08492c30f26a3bd105588dd476b046f6923133cd

? sunnavy sunnavy at bestpractical.com
Wed May 5 23:57:09 EDT 2010


The branch, master has been updated
       via  08492c30f26a3bd105588dd476b046f6923133cd (commit)
      from  4bd778c7431fcb453a648591bedbdcb7c5f9c80c (commit)

Summary of changes:
 lib/Net/Trac/Ticket.pm |   20 +-------------------
 1 files changed, 1 insertions(+), 19 deletions(-)

- Log -----------------------------------------------------------------
commit 08492c30f26a3bd105588dd476b046f6923133cd
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu May 6 11:57:03 2010 +0800

    no_auto_status is meanless since we stick to the api now

diff --git a/lib/Net/Trac/Ticket.pm b/lib/Net/Trac/Ticket.pm
index 9509086..b1fb47d 100644
--- a/lib/Net/Trac/Ticket.pm
+++ b/lib/Net/Trac/Ticket.pm
@@ -301,10 +301,7 @@ sub create {
 
 =head2 update HASH
 
-Updates the current ticket with the specified values.  This method will
-attempt to emulate Trac's default workflow by auto-updating the status
-based on changes to other fields.  To avoid this auto-updating, specify
-a true value as the value for the key C<no_auto_status>.
+Updates the current ticket with the specified values.
 
 Returns undef on failure, and the ID of the current ticket on success.
 
@@ -316,25 +313,10 @@ sub update {
         @_,
         {
             comment         => 0,
-            no_auto_status  => { default => 0 },
             %{$self->_metadata_validation_rules( 'update' => $self->valid_update_props )}
         }
     );
 
-    # Automatically set the status for default trac workflows unless
-    # we're asked not to
-    unless ( $args{'no_auto_status'} ) {
-        $args{'status'} = 'closed'
-            if $args{'resolution'} and not $args{'status'};
-        
-        $args{'status'} = 'assigned'
-            if $args{'owner'} and not $args{'status'};
-        
-        $args{'status'} = 'accepted'
-            if $args{'owner'} and $args{'owner'} eq $self->connection->user
-               and not $args{'status'};
-    }
-
     my ($form,$form_num)= $self->_get_update_ticket_form();
 
     # Copy over the values we'll be using

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list