[Bps-public-commit] Test-Spelling branch, master, updated. 44f99a61d52c34e49d07d757df893fae0ec89605

Shawn Moore sartak at bestpractical.com
Mon Apr 25 15:03:28 EDT 2011


The branch, master has been updated
       via  44f99a61d52c34e49d07d757df893fae0ec89605 (commit)
      from  ed59bb5f58d1bf988248f249291110617647ea84 (commit)

Summary of changes:
 lib/Test/Spelling.pm |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 44f99a61d52c34e49d07d757df893fae0ec89605
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Mon Apr 25 15:02:43 2011 -0400

    IPC::Open3 deals with exec errors better
    
        open2 on a program that doesn't exist will give you crap in
        stderr, but since we're trying alternatives, it's better to capture
        and discard it

diff --git a/lib/Test/Spelling.pm b/lib/Test/Spelling.pm
index c88ac3c..9849997 100644
--- a/lib/Test/Spelling.pm
+++ b/lib/Test/Spelling.pm
@@ -7,7 +7,7 @@ use base 'Exporter';
 use Pod::Spell;
 use Test::Builder;
 use File::Spec;
-use IPC::Open2;
+use IPC::Open3;
 
 our $VERSION = '0.12';
 
@@ -45,7 +45,7 @@ sub _get_spellcheck_results {
     for my $spellchecker (spellchecker_candidates()) {
         my @words;
         my $ok = eval {
-            my $pid = open2((my ($spellcheck_results, $child_in)), $spellchecker);
+            my $pid = open3((my ($child_in, $spellcheck_results, $child_err)), $spellchecker);
 
             print $child_in $document;
 

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list