[Bps-public-commit] jifty-plugin-recordhistory branch, master, updated. 0.04-1-gfb25f73

Shawn Moore sartak at bestpractical.com
Sat Feb 19 03:23:27 EST 2011


The branch, master has been updated
       via  fb25f7332fcae44316bedd20da382f2b66415e21 (commit)
      from  51428d7a16f6bad48edf7da83bcf864d0a1bf53b (commit)

Summary of changes:
 .../RecordHistory/Mixin/Model/RecordHistory.pm     |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit fb25f7332fcae44316bedd20da382f2b66415e21
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Sat Feb 19 03:23:15 2011 -0500

    Explain *why* this trigger is after that trigger

diff --git a/lib/Jifty/Plugin/RecordHistory/Mixin/Model/RecordHistory.pm b/lib/Jifty/Plugin/RecordHistory/Mixin/Model/RecordHistory.pm
index a40f65c..2e50d86 100644
--- a/lib/Jifty/Plugin/RecordHistory/Mixin/Model/RecordHistory.pm
+++ b/lib/Jifty/Plugin/RecordHistory/Mixin/Model/RecordHistory.pm
@@ -79,7 +79,8 @@ sub import {
         });
     }
 
-    # this is intentionally added AFTER the previous trigger
+    # this is intentionally added AFTER the previous trigger, otherwise we'll
+    # create the delete change in this trigger then delete it in the other
     if ($args{delete_change}) {
         $caller->add_trigger(before_delete => sub {
             my $self = shift;

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list