[Bps-public-commit] rt-extension-quickdelete branch, master, updated. 0.04-13-g96d81bd
Kevin Falcone
falcone at bestpractical.com
Wed Jan 11 16:37:52 EST 2012
The branch, master has been updated
via 96d81bd03a5530ef11bf188f6b3818f44b603d70 (commit)
via 498c3d61fdce593b47e09b2a8321efa246e17f7e (commit)
via bfa9c9012dafcb3c7b8b5be655cb7fb0bb549604 (commit)
via 84c2c4be40751e24c7d5d2cf417abe746201017d (commit)
from 32b381124ab61b8973335b35c85a25aa0e618e82 (commit)
Summary of changes:
.gitignore | 2 +-
META.yml | 9 +++--
README | 71 +++++++++++++++++++++++++++++++++++++++
inc/Module/Install.pm | 4 +-
inc/Module/Install/Base.pm | 2 +-
inc/Module/Install/Can.pm | 2 +-
inc/Module/Install/Fetch.pm | 2 +-
inc/Module/Install/Makefile.pm | 11 +++---
inc/Module/Install/Metadata.pm | 22 ++++++++----
inc/Module/Install/Win32.pm | 2 +-
inc/Module/Install/WriteAll.pm | 2 +-
lib/RT/Extension/QuickDelete.pm | 5 ++-
12 files changed, 106 insertions(+), 28 deletions(-)
create mode 100644 README
- Log -----------------------------------------------------------------
commit 84c2c4be40751e24c7d5d2cf417abe746201017d
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Wed Jan 11 15:51:25 2012 -0500
Go back to tracking README because it make github look prettier
diff --git a/.gitignore b/.gitignore
index 6eec439..81b2c24 100644
--- a/.gitignore
+++ b/.gitignore
@@ -16,4 +16,4 @@ rtldapimport
*.bak
t/tmp/
t/lib/RT/Extension/LDAPImport/Test.pm
-README
+MYMETA.*
diff --git a/README b/README
new file mode 100644
index 0000000..5e53ab1
--- /dev/null
+++ b/README
@@ -0,0 +1,70 @@
+NAME
+ RT::Extension::QuickDelete - Adds a "quick delete" button to RT's
+ standard ticket search interface
+
+SYNOPSIS
+ perl Makefile.PL
+ make install
+ make initdb
+
+ Add RT::Extension::QuickDelete to your existin @Plugins line, or create a new @Plugins line:
+
+ Set(@Plugins, qw(RT::Extension::QuickDelete));
+
+ # If you're using RT 3.6.0 or RT 3.6.1, copy etc/3.6.1/ShowSearch to /opt/rt3/share/html/Elements/ShowSearch
+ # (This changed file is already included in RT 3.6.2)
+
+ # Update your default RT search results format to include favorites link by adding this to your RT_SiteConfig.pm:
+
+ Set ($DefaultSearchResultFormat, qq{
+ '<B><A HREF="$RT::WebPath/Ticket/Display.html?id=__id__">__id__</a></B>/TITLE:#',
+ '<B><A HREF="$RT::WebPath/Ticket/Display.html?id=__id__">__Subject__</a></B>/TITLE:Subject',
+ Status,
+ QueueName,
+ OwnerName,
+ Priority,
+ QuickDelete,
+ '__NEWLINE__',
+ '',
+ '<small>__Requestors__</small>',
+ '<small>__CreatedRelative__</small>',
+ '<small>__ToldRelative__</small>',
+ '<small>__LastUpdatedRelative__</small>',
+ '<small>__TimeLeft__</small>'});
+
+ On RT 4, this extension will not provide a Quick Delete link from the
+ Ticket Display pages. You can add one using the Lifecycles
+ functionality.
+
+AUTHOR
+ Jesse Vincent "<jesse at bestpractical.com>"
+
+LICENCE AND COPYRIGHT
+ Copyright (c) 2007-2011, Best Practical Solutions, LLC. All rights
+ reserved.
+
+ This module is free software; you can redistribute it and/or modify it
+ under the same terms as Perl itself. See perlartistic.
+
+DISCLAIMER OF WARRANTY
+ BECAUSE THIS SOFTWARE IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
+ FOR THE SOFTWARE, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN
+ OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
+ PROVIDE THE SOFTWARE "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER
+ EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE
+ ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE SOFTWARE IS WITH
+ YOU. SHOULD THE SOFTWARE PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL
+ NECESSARY SERVICING, REPAIR, OR CORRECTION.
+
+ IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+ WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
+ REDISTRIBUTE THE SOFTWARE AS PERMITTED BY THE ABOVE LICENCE, BE LIABLE
+ TO YOU FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL, OR
+ CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE
+ SOFTWARE (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING
+ RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A
+ FAILURE OF THE SOFTWARE TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF
+ SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH
+ DAMAGES.
+
commit bfa9c9012dafcb3c7b8b5be655cb7fb0bb549604
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Wed Jan 11 16:24:53 2012 -0500
add a blank column to balance the format
diff --git a/README b/README
index 5e53ab1..5e97c6d 100644
--- a/README
+++ b/README
@@ -30,7 +30,8 @@ SYNOPSIS
'<small>__CreatedRelative__</small>',
'<small>__ToldRelative__</small>',
'<small>__LastUpdatedRelative__</small>',
- '<small>__TimeLeft__</small>'});
+ '<small>__TimeLeft__</small>',
+ '__BLANK__/TITLE:NBSP'});
On RT 4, this extension will not provide a Quick Delete link from the
Ticket Display pages. You can add one using the Lifecycles
diff --git a/lib/RT/Extension/QuickDelete.pm b/lib/RT/Extension/QuickDelete.pm
index 6586aac..8e806ec 100644
--- a/lib/RT/Extension/QuickDelete.pm
+++ b/lib/RT/Extension/QuickDelete.pm
@@ -41,7 +41,8 @@ RT::Extension::QuickDelete - Adds a "quick delete" button to RT's standard ticke
'<small>__CreatedRelative__</small>',
'<small>__ToldRelative__</small>',
'<small>__LastUpdatedRelative__</small>',
- '<small>__TimeLeft__</small>'});
+ '<small>__TimeLeft__</small>',
+ '__BLANK__/TITLE:NBSP'});
On RT 4, this extension will not provide a Quick Delete link from the Ticket Display pages. You can add one
using the Lifecycles functionality.
commit 498c3d61fdce593b47e09b2a8321efa246e17f7e
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Wed Jan 11 15:51:47 2012 -0500
bump MI version
diff --git a/inc/Module/Install.pm b/inc/Module/Install.pm
index 74caf9c..c685ca4 100644
--- a/inc/Module/Install.pm
+++ b/inc/Module/Install.pm
@@ -31,7 +31,7 @@ BEGIN {
# This is not enforced yet, but will be some time in the next few
# releases once we can make sure it won't clash with custom
# Module::Install extensions.
- $VERSION = '1.01';
+ $VERSION = '1.04';
# Storage for the pseudo-singleton
$MAIN = undef;
@@ -451,7 +451,7 @@ sub _version ($) {
}
sub _cmp ($$) {
- _version($_[0]) <=> _version($_[1]);
+ _version($_[1]) <=> _version($_[2]);
}
# Cloned from Params::Util::_CLASS
diff --git a/inc/Module/Install/Base.pm b/inc/Module/Install/Base.pm
index d3662c9..b520616 100644
--- a/inc/Module/Install/Base.pm
+++ b/inc/Module/Install/Base.pm
@@ -4,7 +4,7 @@ package Module::Install::Base;
use strict 'vars';
use vars qw{$VERSION};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.04';
}
# Suspend handler for "redefined" warnings
diff --git a/inc/Module/Install/Can.pm b/inc/Module/Install/Can.pm
index 276409a..a162ad4 100644
--- a/inc/Module/Install/Can.pm
+++ b/inc/Module/Install/Can.pm
@@ -9,7 +9,7 @@ use Module::Install::Base ();
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.04';
@ISA = 'Module::Install::Base';
$ISCORE = 1;
}
diff --git a/inc/Module/Install/Fetch.pm b/inc/Module/Install/Fetch.pm
index 093cb7a..a412576 100644
--- a/inc/Module/Install/Fetch.pm
+++ b/inc/Module/Install/Fetch.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.04';
@ISA = 'Module::Install::Base';
$ISCORE = 1;
}
diff --git a/inc/Module/Install/Makefile.pm b/inc/Module/Install/Makefile.pm
index 4c71003..035cef2 100644
--- a/inc/Module/Install/Makefile.pm
+++ b/inc/Module/Install/Makefile.pm
@@ -8,7 +8,7 @@ use Fcntl qw/:flock :seek/;
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.04';
@ISA = 'Module::Install::Base';
$ISCORE = 1;
}
@@ -219,14 +219,14 @@ sub write {
# an underscore, even though its own version may contain one!
# Hence the funny regexp to get rid of it. See RT #35800
# for details.
- my $v = $ExtUtils::MakeMaker::VERSION =~ /^(\d+\.\d+)/;
+ my ($v) = $ExtUtils::MakeMaker::VERSION =~ /^(\d+\.\d+)/;
$self->build_requires( 'ExtUtils::MakeMaker' => $v );
$self->configure_requires( 'ExtUtils::MakeMaker' => $v );
} else {
# Allow legacy-compatibility with 5.005 by depending on the
# most recent EU:MM that supported 5.005.
- $self->build_requires( 'ExtUtils::MakeMaker' => 6.42 );
- $self->configure_requires( 'ExtUtils::MakeMaker' => 6.42 );
+ $self->build_requires( 'ExtUtils::MakeMaker' => 6.36 );
+ $self->configure_requires( 'ExtUtils::MakeMaker' => 6.36 );
}
# Generate the MakeMaker params
@@ -241,7 +241,6 @@ in a module, and provide its file path via 'version_from' (or
'all_from' if you prefer) in Makefile.PL.
EOT
- $DB::single = 1;
if ( $self->tests ) {
my @tests = split ' ', $self->tests;
my %seen;
@@ -412,4 +411,4 @@ sub postamble {
__END__
-#line 541
+#line 540
diff --git a/inc/Module/Install/Metadata.pm b/inc/Module/Install/Metadata.pm
index 3b01e09..31c953e 100644
--- a/inc/Module/Install/Metadata.pm
+++ b/inc/Module/Install/Metadata.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.04';
@ISA = 'Module::Install::Base';
$ISCORE = 1;
}
@@ -151,15 +151,21 @@ sub install_as_site { $_[0]->installdirs('site') }
sub install_as_vendor { $_[0]->installdirs('vendor') }
sub dynamic_config {
- my $self = shift;
- unless ( @_ ) {
- warn "You MUST provide an explicit true/false value to dynamic_config\n";
- return $self;
+ my $self = shift;
+ my $value = @_ ? shift : 1;
+ if ( $self->{values}->{dynamic_config} ) {
+ # Once dynamic we never change to static, for safety
+ return 0;
}
- $self->{values}->{dynamic_config} = $_[0] ? 1 : 0;
+ $self->{values}->{dynamic_config} = $value ? 1 : 0;
return 1;
}
+# Convenience command
+sub static_config {
+ shift->dynamic_config(0);
+}
+
sub perl_version {
my $self = shift;
return $self->{values}->{perl_version} unless @_;
@@ -170,7 +176,7 @@ sub perl_version {
# Normalize the version
$version = $self->_perl_version($version);
- # We don't support the reall old versions
+ # We don't support the really old versions
unless ( $version >= 5.005 ) {
die "Module::Install only supports 5.005 or newer (use ExtUtils::MakeMaker)\n";
}
@@ -582,7 +588,7 @@ sub bugtracker_from {
sub requires_from {
my $self = shift;
my $content = Module::Install::_readperl($_[0]);
- my @requires = $content =~ m/^use\s+([^\W\d]\w*(?:::\w+)*)\s+([\d\.]+)/mg;
+ my @requires = $content =~ m/^use\s+([^\W\d]\w*(?:::\w+)*)\s+(v?[\d\.]+)/mg;
while ( @requires ) {
my $module = shift @requires;
my $version = shift @requires;
diff --git a/inc/Module/Install/Win32.pm b/inc/Module/Install/Win32.pm
index 3139a63..99d9631 100644
--- a/inc/Module/Install/Win32.pm
+++ b/inc/Module/Install/Win32.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.04';
@ISA = 'Module::Install::Base';
$ISCORE = 1;
}
diff --git a/inc/Module/Install/WriteAll.pm b/inc/Module/Install/WriteAll.pm
index 1f724a7..86bb25e 100644
--- a/inc/Module/Install/WriteAll.pm
+++ b/inc/Module/Install/WriteAll.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.04';
@ISA = qw{Module::Install::Base};
$ISCORE = 1;
}
commit 96d81bd03a5530ef11bf188f6b3818f44b603d70
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Wed Jan 11 15:52:33 2012 -0500
Update for 0.05 release
diff --git a/META.yml b/META.yml
index 776d6bb..cf8847e 100644
--- a/META.yml
+++ b/META.yml
@@ -4,11 +4,12 @@ author:
- 'Jesse Vincent C<< <jesse at bestpractical.com> >>'
- 'Jesse Vincent <jesse at bestpractical.com>'
build_requires:
- ExtUtils::MakeMaker: 6.42
+ ExtUtils::MakeMaker: 6.36
configure_requires:
- ExtUtils::MakeMaker: 6.42
+ ExtUtils::MakeMaker: 6.36
distribution_type: module
-generated_by: 'Module::Install version 1.01'
+dynamic_config: 1
+generated_by: 'Module::Install version 1.04'
license: perl
meta-spec:
url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -24,4 +25,4 @@ requires:
Test::More: 0
resources:
license: http://dev.perl.org/licenses/
-version: 0.04
+version: 0.05
diff --git a/lib/RT/Extension/QuickDelete.pm b/lib/RT/Extension/QuickDelete.pm
index 8e806ec..2591f12 100644
--- a/lib/RT/Extension/QuickDelete.pm
+++ b/lib/RT/Extension/QuickDelete.pm
@@ -1,6 +1,6 @@
package RT::Extension::QuickDelete;
-our $VERSION = '0.04';
+our $VERSION = '0.05';
use warnings;
use strict;
-----------------------------------------------------------------------
More information about the Bps-public-commit
mailing list