[Bps-public-commit] RT-Extension-LDAPImport branch, master, updated. 0.32_05-3-g90716a1

[Thomas Sibley]

The branch, master has been updated
       via  90716a1714301f35d843d6723a4739ffd02d8c8b (commit)
       via  d89616687836e6292f91d9c3e498fda1b8db51c0 (commit)
      from  87a75f13f6d2368618a13f1f247750077344c39f (commit)

Summary of changes:
 Changes                        |    4 ++++
 META.yml                       |    2 +-
 lib/RT/Extension/LDAPImport.pm |    6 +++---
 3 files changed, 8 insertions(+), 4 deletions(-)

- Log -----------------------------------------------------------------
commit d89616687836e6292f91d9c3e498fda1b8db51c0
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Jun 8 21:50:11 2012 -0400

    Lower log level to debug for skipped numeric users/groups
    
    It's not easy to exclude numeric users/groups with an LDAP filter,
    leaving no way of acknowledging and suppressing the warning.  Rather
    than add an option, just lower the log level.
    
    While debugging it's helpful to see what was skipped, but under normal
    usage (i.e. from cron), you want to ensure you see meaningful errors and
    warnings not the same ones every night.

diff --git a/lib/RT/Extension/LDAPImport.pm b/lib/RT/Extension/LDAPImport.pm
index 7bc382a..9ac2cda 100644
--- a/lib/RT/Extension/LDAPImport.pm
+++ b/lib/RT/Extension/LDAPImport.pm
@@ -435,7 +435,7 @@ sub import_users {
             next;
         }
         if ( $user->{Name} =~ /^[0-9]+$/) {
-            $self->_warn("Skipping user '$user->{Name}', as it is numeric");
+            $self->_debug("Skipping user '$user->{Name}', as it is numeric");
             next;
         }
         $self->_import_user( user => $user, ldap_entry => $entry, import => $args{import} );
@@ -934,7 +934,7 @@ sub import_groups {
             next;
         }
         if ( $group->{Name} =~ /^[0-9]+$/) {
-            $self->_warn("Skipping group '$group->{Name}', as it is numeric");
+            $self->_debug("Skipping group '$group->{Name}', as it is numeric");
             next;
         }
         $self->_import_group( %args, group => $group, ldap_entry => $entry );

commit 90716a1714301f35d843d6723a4739ffd02d8c8b
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Jun 8 21:56:59 2012 -0400

    Bump version for another dev release

diff --git a/Changes b/Changes
index ed4edb8..399701d 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,9 @@
 Revision history for RT-Extension-LDAPImport
 
+0.32_06
+    Bug fix: Allow 0 as a valid object CF value
+    Usability: Lower log level to debug for skipped numeric users/groups
+
 0.32_05
     Bug fix: Restore the old uncached group member search logic when Member_Attr_Value is DN
     Bug fix: Ensure the users cache is defined before we use it
diff --git a/META.yml b/META.yml
index 0dd3921..5095d0d 100644
--- a/META.yml
+++ b/META.yml
@@ -28,4 +28,4 @@ requires:
   Test::More: 0
 resources:
   license: http://dev.perl.org/licenses/
-version: 0.32_05
+version: 0.32_06
diff --git a/lib/RT/Extension/LDAPImport.pm b/lib/RT/Extension/LDAPImport.pm
index 9ac2cda..06e8897 100644
--- a/lib/RT/Extension/LDAPImport.pm
+++ b/lib/RT/Extension/LDAPImport.pm
@@ -1,7 +1,7 @@
 package RT::Extension::LDAPImport;
 
 # XXX TODO: For historical reasons, this should become 0.33 after 0.32_xx dev releases are done.
-our $VERSION = '0.32_05';
+our $VERSION = '0.32_06';
 
 use warnings;
 use strict;

-----------------------------------------------------------------------