[Bps-public-commit] smokingit branch, master, updated. d3de530f504643e1cafab64c125a235fe068e7ef

Alex Vandiver alexmv at bestpractical.com
Thu Sep 13 17:11:47 EDT 2012


The branch, master has been updated
       via  d3de530f504643e1cafab64c125a235fe068e7ef (commit)
      from  d7ecb0112f4f7e7ff652e94cb39e1319b43e36c3 (commit)

Summary of changes:
 lib/Smokingit/Model/Branch.pm | 1 -
 lib/Smokingit/View/Branch.pm  | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit d3de530f504643e1cafab64c125a235fe068e7ef
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Sep 13 17:11:42 2012 -0400

    Push branches with no reviewer into having an explicit nobody current_actor

diff --git a/lib/Smokingit/Model/Branch.pm b/lib/Smokingit/Model/Branch.pm
index 6a5289a..6c0067a 100644
--- a/lib/Smokingit/Model/Branch.pm
+++ b/lib/Smokingit/Model/Branch.pm
@@ -193,7 +193,6 @@ sub long_status_html {
 sub is_under_review {
     my $self = shift;
     return unless $self->status =~ /^(needs-review|awaiting-merge|merged)$/;
-    return unless $self->review_by;
     return 1;
 }
 
diff --git a/lib/Smokingit/View/Branch.pm b/lib/Smokingit/View/Branch.pm
index 88c5a62..b599210 100644
--- a/lib/Smokingit/View/Branch.pm
+++ b/lib/Smokingit/View/Branch.pm
@@ -132,7 +132,7 @@ template '/fragments/branch/properties' => sub {
         if ($b->is_under_review) {
             row {
                 th { "Review by" };
-                cell { $b->review_by };
+                cell { $b->review_by || b { "somebody" } };
             };
         }
     };

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list