[Bps-public-commit] rt-extension-assets branch, 1.0/style, repushed

? sunnavy sunnavy at bestpractical.com
Tue Dec 31 08:21:54 EST 2013


The branch 1.0/style was deleted and repushed:
       was 54b3a402e74afe480923a67c1d3d7c4a346f96ff
       now 13b1404911e4e94b24da99cda66ecfd11acfc5ef

1:  b0852b3 ! 1:  d43c8ae Cut some input sizes down so they will actually fit inside a reflowed layout
    @@ -26,15 +26,33 @@
     @@
      % }
        <tr class="asset-name">
    -     <td class="label"><label for="Name"><&|/l&>Name</&></label></td>
    +     <td class="label"><label for="Name"><&|/l&>Name</&>:</label></td>
     -    <td><input name="Name" value="<% $current{Name} %>" size="50"></td>
     +    <td><input name="Name" value="<% $current{Name} %>" size="40"></td>
        </tr>
        <tr class="asset-description">
    -     <td class="label"><label for="Description"><&|/l&>Description</&></label></td>
    +     <td class="label"><label for="Description"><&|/l&>Description</&>:</label></td>
     -    <td><input name="Description" value="<% $current{Description} %>" size="75"></td>
     +    <td><input name="Description" value="<% $current{Description} %>" size="40"></td>
        </tr>
        <tr class="asset-status">
    -     <td class="label"><label for="Status"><&|/l&>Status</&></label></td>
    +     <td class="label"><label for="Status"><&|/l&>Status</&>:</label></td>
     
    +diff --git a/html/Asset/Search/Bulk.html b/html/Asset/Search/Bulk.html
    +--- a/html/Asset/Search/Bulk.html
    ++++ b/html/Asset/Search/Bulk.html
    +@@
    +   </tr>
    +   <tr class="asset-name">
    +     <td class="label"><label for="UpdateName"><&|/l&>Name</&></label></td>
    +-    <td><input name="UpdateName" value="<% $ARGS{'Name'}||'' %>" size="50"></td>
    ++    <td><input name="UpdateName" value="<% $ARGS{'Name'}||'' %>" size="40"></td>
    +   </tr>
    +   <tr class="asset-description">
    +     <td class="label"><label for="UpdateDescription"><&|/l&>Description</&></label></td>
    +-    <td><input name="UpdateDescription" value="<% $ARGS{'Description'}||'' %>" size="75"></td>
    ++    <td><input name="UpdateDescription" value="<% $ARGS{'Description'}||'' %>" size="40"></td>
    +   </tr>
    +   <tr class="asset-status">
    +     <td class="label"><label for="UpdateStatus"><&|/l&>Status</&></label></td>
    +
2:  e14c103 ! 2:  a56ae2a Make the "create an asset" form contain a table for semi-reliable twocol layout.
    @@ -1,7 +1,6 @@
     Author: Jesse Vincent <jesse at bestpractical.com>
     
    -    Make the "create an asset" form contane a table for semi-reliable twocol
    -    layout.
    +    Make the "create an asset" form contain a table for semi-reliable twocol layout.
     
     diff --git a/html/Asset/Create.html b/html/Asset/Create.html
     --- a/html/Asset/Create.html
3:  4c7f149 = 3:  aa28eaf add some more html so we can style it
4:  76f8928 < -:  ------- wording chang "but not" -> "not" for brevity styling hook for 'not'
5:  9bfcdc1 < -:  ------- move a submit out of a titlebox since it was messing up wrapping
6:  a77ec18 < -:  ------- More shorter inputs for styling
7:  c0deb4d < -:  ------- Brevity. In a column labeled 'tickets', don't repeat the words "tickets" twice per line
-:  ------- > 4:  9de016b wording change "but not" -> "not" for brevity
-:  ------- > 5:  0b768ba styling hook for 'not'
-:  ------- > 6:  7f811fe Brevity. In a column labeled 'tickets', don't repeat the words "tickets" twice per line
8:  e1cb042 ! 7:  7a0a457 This change would want to move into RT if it's accepted. it makes our search results not wrap funny
    @@ -1,7 +1,6 @@
     Author: Jesse Vincent <jesse at bestpractical.com>
     
    -    This change would want to move into RT if it's accepted. it makes our search
    -    results not wrap funny
    +    This change would want to move into RT if it's accepted. it makes our search results not wrap funny
     
     diff --git a/static/css/RTx-Assets.css b/static/css/RTx-Assets.css
     --- a/static/css/RTx-Assets.css
9:  54b3a40 ! 8:  13b1404 First pass at comprehensive styling for assets
    @@ -5,22 +5,6 @@
     diff --git a/static/css/RTx-Assets.css b/static/css/RTx-Assets.css
     --- a/static/css/RTx-Assets.css
     +++ b/static/css/RTx-Assets.css
    -@@
    -+
    -+
    - #assets-accordion h3 {
    -     position: relative;
    - }
    -@@
    - .asset-links    .titlebox .titlebox-title .left { background-color: #316531; }
    - .ticket-assets  .titlebox .titlebox-title .left { background-color: #316531; }
    - 
    -+
    -+
    -+
    - /* People display */
    - #comp-Asset-Display .asset-people table {
    -     width: 100%;
     @@
          font-weight: bold;
          color: black;
    @@ -46,32 +30,32 @@
     +	    min-width: 100%;
     +	    width: 100%;
     +	}
    -+	
    -+	#Asset-Create-basics>table,  
    ++
    ++	#Asset-Create-basics>table,
     +	#Asset-Create-basics>table>tbody>tr ,
     +	#Asset-Create-basics>table>tbody>tr>td  {
     +	    display: block;
     +	}
    -+	
    ++
     +}
     +
     +/* On a reasonable-width screen, make better use of whitespace */
     + at media(min-width: 601px) {
    -+	.edit-custom-fields tr, 
    ++	.edit-custom-fields tr,
     +    #ModifyAsset .asset-basics tr {
     +	    display: inline-block;
     +	    width: 50%;
    -+	
    ++
     +	}
    -+	.edit-custom-fields tr td.cflabel, 
    -+    #ModifyAsset .asset-basics tr td.label,  
    ++	.edit-custom-fields tr td.cflabel,
    ++    #ModifyAsset .asset-basics tr td.label,
     +    #ModifyAsset .asset-basics tr td.cflabel {
     +	    width: 13em;
     +	}
    -+	
    -+	
    ++
    ++
     +	/* Asset creation */
    -+	
    ++
     +	#Asset-Create-basics>table  {
     +	    width: 100%;
     +	    align: left;
    @@ -82,8 +66,8 @@
     +	#Asset-Create-basics>table>tbody>tr{
     +	        vertical-align: top;
     +	}
    -+	
    -+	
    ++
    ++
     +}
     +
     +/* basic cleanups for the search UI's elements */
    @@ -103,7 +87,7 @@
     +/* On a wide screen, use two columns for search criteria */
     + at media (min-width:1150px){
     +	.asset-search-grouping.asset-search-cfs {
    -+	
    ++
     +	    display: inline-block;
     +	    width: 45%;
     +	    padding-right: 1em;
    @@ -114,8 +98,8 @@
     +	    width: auto;
     +	    padding: inherit;
     +	}
    -+	
    -+	
    ++
    ++
     +	.asset-search-basics tr {
     +	    width: 49%;
     +	    display:inline-block;
    @@ -125,5 +109,5 @@
     +	    display:inline-block;
     +	    width:10em;
     +	}
    -+	
    ++
     +}




More information about the Bps-public-commit mailing list