[Bps-public-commit] RT-Extension-rt_cpan_org branch, rt4, updated. 2454eac4e48e1047a61ed3bdf348fec5e9eda400
Thomas Sibley
trs at bestpractical.com
Wed Feb 27 23:23:54 EST 2013
The branch, rt4 has been updated
via 2454eac4e48e1047a61ed3bdf348fec5e9eda400 (commit)
via 0057111d38bf3356f7dbf4158f10767c48ec51f1 (commit)
via 55a45c0ea3186288bf6ef166abd46df1b722343b (commit)
via 0a11d09f384bd7da1ce4009fd3330fbb1a4ee4b6 (commit)
via 256b6de7b4c6cc7c9219fe7d7d6c61580419cf1f (commit)
via eee9a800a8efcb98b985d46ad728f99e387173f8 (commit)
via 799443c6aef47f8b6c44c88f0a695a00d76b5967 (commit)
via a51adf036af916b51a3a5a777d3b52208978567b (commit)
via a149237fb0e37de4c40829b489f0a30dae3b11c3 (commit)
from 833f926a00b327e6839143537aa6ff9f8c1b2ab1 (commit)
Summary of changes:
etc/CPAN_Config.pm | 5 ++
html/Callbacks/rt_cpan_org/Elements/Footer/Default | 1 +
.../rt_cpan_org/Elements/Login/BeforeForm | 60 +--------------------
.../rt_cpan_org/Elements/MakeClicky/Default | 6 +--
.../rt_cpan_org/Elements/PersonalQuickbar/Default | 1 -
html/Callbacks/rt_cpan_org/Elements/Tabs/Default | 26 ---------
.../Callbacks/rt_cpan_org/Elements/Tabs/Privileged | 9 ++++
.../rt_cpan_org/Ticket/Elements/Tabs/Default | 23 --------
.../rt_cpan_org/User/Elements/Tabs/Default | 18 -------
html/Callbacks/rt_cpan_org/autohandler/Default | 8 ---
html/Elements/ContactInfo | 2 +-
html/Elements/Instructions | 59 ++++++++++++++++++++
html/{Public => NoAuth}/RT/CPAN/About.html | 34 ++++++------
html/NoAuth/RT/CPAN/Usage.html | 4 ++
html/NoAuth/css/rt.cpan.org.css | 8 ++-
html/NoAuth/images/cpan-cake.jpg | Bin 8290 -> 0 bytes
html/NoAuth/images/cpan-rt-3.8.jpg | Bin 5965 -> 0 bytes
html/NoAuth/images/cpan.jpg | Bin 3861 -> 0 bytes
html/NoAuth/images/cpan.png | Bin 0 -> 4282 bytes
html/NoAuth/js/rt.cpan.org.js | 5 ++
20 files changed, 112 insertions(+), 157 deletions(-)
create mode 100644 html/Callbacks/rt_cpan_org/Elements/Footer/Default
delete mode 100644 html/Callbacks/rt_cpan_org/Elements/PersonalQuickbar/Default
delete mode 100644 html/Callbacks/rt_cpan_org/Elements/Tabs/Default
delete mode 100644 html/Callbacks/rt_cpan_org/Ticket/Elements/Tabs/Default
delete mode 100644 html/Callbacks/rt_cpan_org/User/Elements/Tabs/Default
delete mode 100644 html/Callbacks/rt_cpan_org/autohandler/Default
create mode 100644 html/Elements/Instructions
rename html/{Public => NoAuth}/RT/CPAN/About.html (64%)
create mode 100644 html/NoAuth/RT/CPAN/Usage.html
delete mode 100644 html/NoAuth/images/cpan-cake.jpg
delete mode 100644 html/NoAuth/images/cpan-rt-3.8.jpg
delete mode 100644 html/NoAuth/images/cpan.jpg
create mode 100644 html/NoAuth/images/cpan.png
- Log -----------------------------------------------------------------
commit a149237fb0e37de4c40829b489f0a30dae3b11c3
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Feb 27 17:45:23 2013 -0800
"goto" query param considered harmful
Any redirects will use the RT 4 "NextPage" session store used by login.
diff --git a/html/Callbacks/rt_cpan_org/autohandler/Default b/html/Callbacks/rt_cpan_org/autohandler/Default
deleted file mode 100644
index 982d9cd..0000000
--- a/html/Callbacks/rt_cpan_org/autohandler/Default
+++ /dev/null
@@ -1,8 +0,0 @@
-<%ARGS>
-$goto => undef
-</%ARGS>
-<%INIT>
-return unless $goto;
-
-$m->redirect( RT->Config->Get('WebBaseURL') . $goto );
-</%INIT>
commit a51adf036af916b51a3a5a777d3b52208978567b
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Feb 27 17:55:21 2013 -0800
Put About link into the menu
diff --git a/html/Callbacks/rt_cpan_org/Elements/PersonalQuickbar/Default b/html/Callbacks/rt_cpan_org/Elements/PersonalQuickbar/Default
deleted file mode 100644
index 78cb56d..0000000
--- a/html/Callbacks/rt_cpan_org/Elements/PersonalQuickbar/Default
+++ /dev/null
@@ -1 +0,0 @@
-| <a href="<%RT->Config->Get("WebPath")%>/Public/RT/CPAN/About.html"><&|/l&>About rt.cpan.org</&></a>
diff --git a/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged b/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
index 1860be0..732772c 100644
--- a/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
+++ b/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
@@ -2,4 +2,10 @@
if (my $actions = PageMenu->child("actions")) {
$actions->delete("comment");
}
+
+Menu->child(
+ "about",
+ title => loc("About rt.cpan.org"),
+ path => "/Public/RT/CPAN/About.html",
+);
</%init>
commit 799443c6aef47f8b6c44c88f0a695a00d76b5967
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Feb 27 19:18:59 2013 -0800
Update our MakeClicky override which adds rel="nofollow"
Inserting spaces is no longer necessary in RT 4.
diff --git a/html/Callbacks/rt_cpan_org/Elements/MakeClicky/Default b/html/Callbacks/rt_cpan_org/Elements/MakeClicky/Default
index eca4aea..d229ab5 100644
--- a/html/Callbacks/rt_cpan_org/Elements/MakeClicky/Default
+++ b/html/Callbacks/rt_cpan_org/Elements/MakeClicky/Default
@@ -6,9 +6,7 @@ $handle => undef
<%INIT>
$actions->{url_overwrite} = sub {
my %args = @_;
- my $result = qq{<a target="new" rel="nofollow" href="$args{'value'}">};
- $args{'value'} =~ s/(\S{30})/$1 /g;
- $result .= qq{$args{'value'}</a>};
- return qq{<span class="clickylink">$result</span>};
+ my $url = $m->interp->apply_escapes($args{value}, 'h');
+ return qq{<span class="clickylink"><a target="new" rel="nofollow" href="$url">$url</a></span>};
};
</%INIT>
commit eee9a800a8efcb98b985d46ad728f99e387173f8
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Feb 27 19:44:42 2013 -0800
Replace old Tabs callback with the new one
ContactInfo was handled by the old callback, and is now positioned at
the bottom of pages for lack of a better location in RT 4.
diff --git a/html/Callbacks/rt_cpan_org/Elements/Footer/Default b/html/Callbacks/rt_cpan_org/Elements/Footer/Default
new file mode 100644
index 0000000..27e3436
--- /dev/null
+++ b/html/Callbacks/rt_cpan_org/Elements/Footer/Default
@@ -0,0 +1 @@
+<& /Elements/ContactInfo &>
diff --git a/html/Callbacks/rt_cpan_org/Elements/Tabs/Default b/html/Callbacks/rt_cpan_org/Elements/Tabs/Default
deleted file mode 100644
index 51f5cca..0000000
--- a/html/Callbacks/rt_cpan_org/Elements/Tabs/Default
+++ /dev/null
@@ -1,26 +0,0 @@
-<%ARGS>
-$topactions => {}
-$toptabs => {}
-</%ARGS>
-<%INIT>
-
-$topactions->{'0'} = {
- html => $m->scomp('/Elements/ContactInfo'),
-};
-
-foreach my $k ( keys %$toptabs ) {
- next unless $toptabs->{ $k }{'title'} eq loc('Tickets');
-
- $toptabs->{ $k }{'title'} = loc('Search Tickets');
- last;
-}
-
-my @hide = ('Simple Search', 'Approval');
-push @hide, 'Tools' if RT::BugTracker::Public->IsPublicUser;
- at hide = map loc($_), @hide;
-foreach my $k ( keys %$toptabs ) {
- my $title = $toptabs->{ $k }{'title'};
- next unless grep $title eq $_, @hide;
- delete $toptabs->{ $k };
-}
-</%INIT>
diff --git a/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged b/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
index 732772c..49e1301 100644
--- a/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
+++ b/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
@@ -3,6 +3,9 @@ if (my $actions = PageMenu->child("actions")) {
$actions->delete("comment");
}
+Menu->child("search")->title(loc("Search Tickets"));
+Menu->delete("tools");
+
Menu->child(
"about",
title => loc("About rt.cpan.org"),
diff --git a/html/Elements/ContactInfo b/html/Elements/ContactInfo
index 15d98c8..d634715 100644
--- a/html/Elements/ContactInfo
+++ b/html/Elements/ContactInfo
@@ -45,6 +45,6 @@
%# those contributions and any derivatives thereof.
%#
%# END BPS TAGGED BLOCK }}}
-<p class="contact-info">
+<p id="contact-info">
Please report any issues with rt.cpan.org to <a href="mailto:rt-cpan-admin at bestpractical.com">rt-cpan-admin at bestpractical.com</a>.
</p>
diff --git a/html/NoAuth/css/rt.cpan.org.css b/html/NoAuth/css/rt.cpan.org.css
index d46a06a..74c7f19 100644
--- a/html/NoAuth/css/rt.cpan.org.css
+++ b/html/NoAuth/css/rt.cpan.org.css
@@ -101,8 +101,14 @@ tt {
font-size: 1.2em;
}
-.contact-info {
+#contact-info {
+ color: white;
+ text-shadow: 1px 1px #444;
+ padding: 1em 1em 0 0;
+ margin: 0;
text-align: right;
}
+#contact-info a { color: white }
+
a { text-decoration: underline; }
commit 256b6de7b4c6cc7c9219fe7d7d6c61580419cf1f
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Feb 27 19:46:10 2013 -0800
Use a better copy of the CPAN logo
diff --git a/etc/CPAN_Config.pm b/etc/CPAN_Config.pm
index c68c2e8..6de7695 100644
--- a/etc/CPAN_Config.pm
+++ b/etc/CPAN_Config.pm
@@ -3,6 +3,11 @@
Set( $Organization, "rt.cpan.org" );
+# Logo
+Set( $LogoURL, '/NoAuth/images/cpan.png' );
+Set( $LogoLinkURL, $WebURL );
+Set( $LogoAltText, "CPAN" );
+
# Reminders add much complexity for not much value.
Set( $EnableReminders, 0 );
diff --git a/html/NoAuth/images/cpan-cake.jpg b/html/NoAuth/images/cpan-cake.jpg
deleted file mode 100644
index b6fa69a..0000000
Binary files a/html/NoAuth/images/cpan-cake.jpg and /dev/null differ
diff --git a/html/NoAuth/images/cpan-rt-3.8.jpg b/html/NoAuth/images/cpan-rt-3.8.jpg
deleted file mode 100644
index 896b62f..0000000
Binary files a/html/NoAuth/images/cpan-rt-3.8.jpg and /dev/null differ
diff --git a/html/NoAuth/images/cpan.jpg b/html/NoAuth/images/cpan.jpg
deleted file mode 100644
index a0d5ce5..0000000
Binary files a/html/NoAuth/images/cpan.jpg and /dev/null differ
diff --git a/html/NoAuth/images/cpan.png b/html/NoAuth/images/cpan.png
new file mode 100644
index 0000000..e504a0f
Binary files /dev/null and b/html/NoAuth/images/cpan.png differ
commit 0a11d09f384bd7da1ce4009fd3330fbb1a4ee4b6
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Feb 27 19:47:52 2013 -0800
Delegation is lone gone in 4.0
diff --git a/html/Callbacks/rt_cpan_org/User/Elements/Tabs/Default b/html/Callbacks/rt_cpan_org/User/Elements/Tabs/Default
deleted file mode 100644
index 613c232..0000000
--- a/html/Callbacks/rt_cpan_org/User/Elements/Tabs/Default
+++ /dev/null
@@ -1,18 +0,0 @@
-<%ARGS>
-$tabs
-</%ARGS>
-<%INIT>
-### Delegation option is disabled because the widgets are unclever about the
-### number of queues involved and so they hose the server. When we've made
-### the widgets smarter, we'll re-enable these options.
-my $lstr = loc('Delegation');
-if ( $tabs->{'h'} && $tabs->{'h'}{'title'} eq $lstr ) {
- delete $tabs->{'h'};
- return;
-}
-while ( my ($k, $v) = each %$tabs ) {
- next if $v->{'title'} ne $lstr;
- delete $tabs->{ $k };
- return;
-}
-</%INIT>
commit 55a45c0ea3186288bf6ef166abd46df1b722343b
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Feb 27 20:04:42 2013 -0800
Rejigger About page and create a separate Usage page
It's now easier to point to usage than "Look at the login page",
especially when a person is already logged in (either as the guest
public user or otherwise). Additionally, the About page no longer
automatically logs you in as the public user. This keeps the login page
obtainable.
diff --git a/html/Callbacks/rt_cpan_org/Elements/Login/BeforeForm b/html/Callbacks/rt_cpan_org/Elements/Login/BeforeForm
index 1499f3b..25c9e19 100644
--- a/html/Callbacks/rt_cpan_org/Elements/Login/BeforeForm
+++ b/html/Callbacks/rt_cpan_org/Elements/Login/BeforeForm
@@ -48,65 +48,7 @@
<div class="clearfix">
<div id="rtcpan-explanation">
<div class="wrapper">
- <p>
- This site tracks bugs in every distribution released through
- <a href="http://cpan.org">CPAN</a>.
- </p>
-
- <h2>Want to...</h2>
-
- <h2>... find a distribution and browse its bugs?</h2>
- <p>
- This site lets you <a href="<% RT->Config->Get("WebPath") %>/Public/">search
- for distributions</a> by name or author. When you've found the
- distribution you're looking for, you can browse known bugs and
- report new bugs.
- </p>
-
- <h2>... report a bug in a module using web-interface?</h2>
- <p>
- Use <a href="https://www.bitcard.org/">Bitcard</a> or OpenID account.
- Module authors can use PAUSE credentials.
- </p>
-
- <h2>... report a bug in a module using email?</h2>
- <p>
- To submit a bug report for a given distribution by email, send mail
- to <strong>bug-<distribution-name>@rt.cpan.org</strong>, where
- "<distribution-name>" is something like DBIx-SearchBuilder or
- Class-DBI or Acme-Current-Forever. Use
- <a href="<% RT->Config->Get("WebPath") %>/Public/">search</a> to find name of
- a distribution.
- </p>
-
- <h2>... report a bug in perl itself?</h2>
- <p>
- To report bugs in perl itself, you're best off using the command-line
- 'perlbug' tool or <a href="http://rt.perl.org">rt.perl.org</a>.
- </p>
-
- <h2>... manage bugs in your distributions?</h2>
- <p>
- To work with bugs, every module author with a
- <a href="http://pause.perl.org">PAUSE</a> account can log into
- rt.cpan.org with their PAUSE userid and password. If you can't log in or
- distributions you maintain aren't listed, please write to
- rt-cpan-admin at bestpractical.com at your earliest convenience.
- </p>
-
- <h2>... know more about this service?</h2>
- <p>
- Read <a href="<% RT->Config->Get("WebPath") %>/Public/RT/CPAN/About.html">this document</a>.
- </p>
-
- <p>
- Enjoy,
- </p>
-
- <p class="over-and-out">
- Jesse Vincent <br />
- <a href="http://bestpractical.com/">Best Practical Solutions</a>, LLC
- </p>
+ <& /Elements/Instructions &>
</div>
</div>
diff --git a/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged b/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
index 49e1301..71ad891 100644
--- a/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
+++ b/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
@@ -9,6 +9,6 @@ Menu->delete("tools");
Menu->child(
"about",
title => loc("About rt.cpan.org"),
- path => "/Public/RT/CPAN/About.html",
+ path => "/NoAuth/RT/CPAN/About.html",
);
</%init>
diff --git a/html/Elements/Instructions b/html/Elements/Instructions
new file mode 100644
index 0000000..d6ef122
--- /dev/null
+++ b/html/Elements/Instructions
@@ -0,0 +1,59 @@
+<p style="margin-top: 0">
+ This site tracks bugs in every distribution released through
+ <a href="http://cpan.org">CPAN</a>.
+</p>
+
+<h2>Want to...</h2>
+
+<h2>... find a distribution and browse its bugs?</h2>
+<p>
+ This site lets you <a href="<% RT->Config->Get("WebPath") %>/Public/">search
+ for distributions</a> by name or author. When you've found the
+ distribution you're looking for, you can browse known bugs and
+ report new bugs.
+</p>
+
+<h2>... report a bug in a module using web-interface?</h2>
+<p>
+ Use <a href="https://www.bitcard.org/">Bitcard</a> or OpenID account.
+ Module authors can use PAUSE credentials.
+</p>
+
+<h2>... report a bug in a module using email?</h2>
+<p>
+ To submit a bug report for a given distribution by email, send mail
+ to <strong>bug-<distribution-name>@rt.cpan.org</strong>, where
+ "<distribution-name>" is something like DBIx-SearchBuilder or
+ Class-DBI or Acme-Current-Forever. Use
+ <a href="<% RT->Config->Get("WebPath") %>/Public/">search</a> to find name of
+ a distribution.
+</p>
+
+<h2>... report a bug in perl itself?</h2>
+<p>
+ To report bugs in perl itself, you're best off using the command-line
+ 'perlbug' tool or <a href="http://rt.perl.org">rt.perl.org</a>.
+</p>
+
+<h2>... manage bugs in your distributions?</h2>
+<p>
+ To work with bugs, every module author with a
+ <a href="http://pause.perl.org">PAUSE</a> account can log into
+ rt.cpan.org with their PAUSE userid and password. If you can't log in or
+ distributions you maintain aren't listed, please write to
+ rt-cpan-admin at bestpractical.com at your earliest convenience.
+</p>
+
+<h2>... know more about this service?</h2>
+<p>
+ Read <a href="<% RT->Config->Get("WebPath") %>/NoAuth/RT/CPAN/About.html">this document</a>.
+</p>
+
+<p>
+Enjoy,
+</p>
+
+<p class="over-and-out">
+ Jesse Vincent <br />
+ <a href="http://bestpractical.com/">Best Practical Solutions</a>, LLC
+</p>
diff --git a/html/Public/RT/CPAN/About.html b/html/NoAuth/RT/CPAN/About.html
similarity index 64%
rename from html/Public/RT/CPAN/About.html
rename to html/NoAuth/RT/CPAN/About.html
index a3b5b80..4340379 100644
--- a/html/Public/RT/CPAN/About.html
+++ b/html/NoAuth/RT/CPAN/About.html
@@ -1,16 +1,17 @@
-<& /Elements/Header, Title => loc('About rt.cpan.org') &>
-%# End of div#quickbar from /Elements/Header
-</div>
+<& /Elements/Header, Title => loc('About rt.cpan.org'), RichText => 0 &>
-<div id="body"><div id="rtcpan-about" style="clear:both; margin-left: 2em;">
+<div id="body">
+ <div id="rtcpan-about">
- <h2>What is this all about?</h2>
+ <h2 style="margin-top: 0">What is this all about?</h2>
<p>
This site tracks bugs in every distribution released through
<a href="http://cpan.org">CPAN</a>.
</p>
- <p>Quick usage guidelines can be found on <a href="<% RT->Config->Get("WebPath") %>/NoAuth/Logout.html">the main page</a></p>
+ <p>
+ See the <a href="Usage.html">quick usage guidelines</a> if you want to know how to use this site. These guidelines are also on the login page.
+ </p>
<h2>Recommendations (soft rules)</h2>
<h3>For reporters</h3>
@@ -18,13 +19,13 @@
<h4>Be polite</h4>
<h4>Are maintainers required to act on all bugs reported by end users?</h4>
- <p>No. They are not. Unless you have an outside contractural relationship with
+ <p>No. They are not. Unless you have an outside contractual relationship with
a maintainer, you need to assume that they are a volunteer. Telling them they
"must" do something is impolite and counterproductive.</p>
<h4>Should maintainers accept bug reports against older versions of a module?</h4>
<p>In general, we discourage bug reports against older versions of modules other
- than for historical reporting purposes (ie close immediately upon report with a
+ than for historical reporting purposes (i.e. resolved immediately upon report with a
note that it's been tested and found to work in the current version.)</p>
<p>If a bug exists in the current CPAN version of a module, please do report the bug.</p>
@@ -33,14 +34,14 @@
<h4>Be polite</h4>
<h4>Can a module have its own bug tracker?</h4>
- <p>Sure it can, but that would not disable the module's RT queue and users would still be
- able to create tickets on rt.cpan.org.</p>
+ <p>Sure it can, but that does not disable the module's RT queue and users can still
+ create tickets on rt.cpan.org.</p>
<h2>What is used to power this service?</h2>
<p>All parts used to build this service are open source software.
- The core is the <a href="http://www.bestpractical.com/rt/">Request Tracker</a> project
- from Best Practical Solutions company. Everything else is either an extension for this
- project or a module from the CPAN.</p>
+ The core is <a href="http://www.bestpractical.com/rt/">Request Tracker</a>
+ from Best Practical Solutions. Everything else is either an extension for this
+ site or a module from the CPAN.</p>
<p>rt.cpan.org has some customizations which tie it to a particular RT version; at this
moment (March 2013) it's RT 4.0.</p>
@@ -54,7 +55,8 @@
<h2>Have a question about this service?</h2>
<p>
- If you have any questions <b>about rt.cpan.org</b>, feel free to send mail to
- rt-cpan-admin at bestpractical.com and we'll do our best to get back to you.
+ If you have any questions <b>about rt.cpan.org</b>, feel free to
+ <a href="mailto:rt-cpan-admin at bestpractical.com">send us mail</a> and we'll do our
+ best to get back to you.
</p>
-</div></div>
+ </div>
diff --git a/html/NoAuth/RT/CPAN/Usage.html b/html/NoAuth/RT/CPAN/Usage.html
new file mode 100644
index 0000000..7e678b0
--- /dev/null
+++ b/html/NoAuth/RT/CPAN/Usage.html
@@ -0,0 +1,4 @@
+<& /Elements/Header, Title => loc('How to use rt.cpan.org'), RichText => 0 &>
+
+<div id="body">
+<& /Elements/Instructions &>
commit 0057111d38bf3356f7dbf4158f10767c48ec51f1
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Feb 27 20:22:04 2013 -0800
Note that this bit of JS is unnecessary
diff --git a/html/NoAuth/js/rt.cpan.org.js b/html/NoAuth/js/rt.cpan.org.js
index 05ca60f..0012d92 100644
--- a/html/NoAuth/js/rt.cpan.org.js
+++ b/html/NoAuth/js/rt.cpan.org.js
@@ -1,5 +1,10 @@
jQuery(function(){
jQuery("select[name=UpdateType] option[value=private]").remove();
+
+ /* This is redundant, thanks to the
+ * /Ticket/Elements/ShowTransaction/ModifyDisplay callback. It doesn't
+ * hurt to leave it in place, however, and will catch if the callback stops
+ * working. */
jQuery("#ticket-history a.comment-link").each(function(){
var parent = this.parentNode;
parent.removeChild(this);
commit 2454eac4e48e1047a61ed3bdf348fec5e9eda400
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Feb 27 20:22:42 2013 -0800
Remove code handled by the new menu callback and lifecycle configuration
diff --git a/html/Callbacks/rt_cpan_org/Ticket/Elements/Tabs/Default b/html/Callbacks/rt_cpan_org/Ticket/Elements/Tabs/Default
deleted file mode 100644
index b04a281..0000000
--- a/html/Callbacks/rt_cpan_org/Ticket/Elements/Tabs/Default
+++ /dev/null
@@ -1,23 +0,0 @@
-<%ARGS>
-$Ticket => undef
-$actions => {}
-</%ARGS>
-<%INIT>
-return unless $Ticket;
-
-# we want to hide Comments on rt.cpan.org
-
-my $loc_comment = loc('Comment');
-foreach my $k ( keys %$actions ) {
- next unless ($actions->{$k}{'title'}||'') eq $loc_comment;
-
- delete $actions->{$k};
-}
-
-my $loc_resolve = loc('Resolve');
-foreach my $k ( keys %$actions ) {
- next unless ($actions->{$k}{'title'}||'') eq $loc_resolve;
-
- $actions->{$k}{'path'} =~ s{\bAction=Comment\b}{Action=Respond};
-}
-</%INIT>
-----------------------------------------------------------------------
More information about the Bps-public-commit
mailing list