[Bps-public-commit] rt-authen-externalauth branch, master, updated. 0.16-6-gbcd5861

[Thomas Sibley]

The branch, master has been updated
       via  bcd5861674db4f5a1b2a5bae5dacae6724629e8d (commit)
       via  f68491e812f10cfffa7829a19c7c3c8d4fb32a2f (commit)
       via  3d8222005d3e6cafa3067c4f5b7ec7a357131918 (commit)
      from  f5eafe0cf2a2cac4cd8dc35f05ef25ab83e19799 (commit)

Summary of changes:
 ChangeLog                     | 4 ++--
 META.yml                      | 2 +-
 lib/RT/Authen/ExternalAuth.pm | 3 ++-
 xt/obfuscate-password.t       | 2 +-
 4 files changed, 6 insertions(+), 5 deletions(-)

- Log -----------------------------------------------------------------
commit 3d8222005d3e6cafa3067c4f5b7ec7a357131918
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Jul 10 12:37:40 2013 -0700

    Avoid uninitialized warnings for some external DB configurations
    
    Not all configs may have a server, for example.

diff --git a/lib/RT/Authen/ExternalAuth.pm b/lib/RT/Authen/ExternalAuth.pm
index 83e7f71..389de8d 100644
--- a/lib/RT/Authen/ExternalAuth.pm
+++ b/lib/RT/Authen/ExternalAuth.pm
@@ -169,6 +169,7 @@ sub DoAuth {
         next unless $conf{type} eq 'db';
 
         # user/pass might be different (root, for instance)
+        no warnings 'uninitialized';
         next unless lc $conf{server} eq lc $RT::DatabaseHost and
                     lc $conf{database} eq lc $RT::DatabaseName and
                     lc $conf{table} eq 'users';

commit f68491e812f10cfffa7829a19c7c3c8d4fb32a2f
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Jul 10 12:40:36 2013 -0700

    The URL of the System Config page is more stable than the menu id
    
    The id changes with the menu location, which changes in RT 4.2.

diff --git a/xt/obfuscate-password.t b/xt/obfuscate-password.t
index ff5c636..6c4b8ee 100644
--- a/xt/obfuscate-password.t
+++ b/xt/obfuscate-password.t
@@ -21,7 +21,7 @@ RT->Config->Set(
 my ($base, $m) = RT::Test->started_ok();
 ok( $m->login, 'logged in' );
 
-$m->follow_link_ok({ id_regex => qr/config-tools-configuration$/i }, 'config page');
+$m->get_ok('/Admin/Tools/Configuration.html', 'config page');
 $m->content_lacks('sekrit', 'external source 1 pass obfuscated');
 $m->content_lacks('nottelling', 'external source 2 pass obfuscated');
 $m->content_contains('ldap_bind', 'sanity check: we do have external config dumped');

commit bcd5861674db4f5a1b2a5bae5dacae6724629e8d
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Jul 10 12:08:30 2013 -0700

    Releng 0.17

diff --git a/ChangeLog b/ChangeLog
index c864a86..070b881 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,5 @@
-0.17
-	* forbid to use RT's DB as external service
+0.17	2013-07-10	Thomas Sibley
+	* Forbid using RT's internal Users table as an auth service
 
 0.16	2013-06-27	Thomas Sibley
 	* Add new p_check option to DBI authentication module
diff --git a/META.yml b/META.yml
index 895a3f8..314aa08 100644
--- a/META.yml
+++ b/META.yml
@@ -33,4 +33,4 @@ requires:
   Net::SSLeay: 0
 resources:
   license: http://opensource.org/licenses/gpl-license.php
-version: 0.16
+version: 0.17
diff --git a/lib/RT/Authen/ExternalAuth.pm b/lib/RT/Authen/ExternalAuth.pm
index 389de8d..39b17cf 100644
--- a/lib/RT/Authen/ExternalAuth.pm
+++ b/lib/RT/Authen/ExternalAuth.pm
@@ -1,6 +1,6 @@
 package RT::Authen::ExternalAuth;
 
-our $VERSION = '0.16';
+our $VERSION = '0.17';
 
 =head1 NAME
 

-----------------------------------------------------------------------