[Bps-public-commit] RT-Extension-rt_cpan_org branch, rt4, updated. ecebe3b3dd4a0cb6a626327526459217a470f5e3

[Thomas Sibley]

The branch, rt4 has been updated
       via  ecebe3b3dd4a0cb6a626327526459217a470f5e3 (commit)
       via  223f3e7c593e43d680feff48b504976e163ededc (commit)
      from  5af135e20c7ef6e146cd2a0409e2324a241cc3d9 (commit)

Summary of changes:
 etc/CPAN_Config.pm                                  | 4 ++++
 html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged | 5 ++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 223f3e7c593e43d680feff48b504976e163ededc
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Mar 1 15:49:09 2013 -0800

    Don't delete the Tools menu for admins

diff --git a/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged b/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
index 9ad1d87..0d81f49 100644
--- a/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
+++ b/html/Callbacks/rt_cpan_org/Elements/Tabs/Privileged
@@ -6,7 +6,10 @@ if (my $actions = PageMenu->child("actions")) {
 }
 
 Menu->child("search")->title(loc("Search Tickets"));
-Menu->delete("tools");
+Menu->delete("tools") unless $session{CurrentUser}->HasRight(
+    Object  => RT->System,
+    Right   => 'ShowConfigTab',
+);
 
 my $about = Menu->child("preferences")->add_before(
     "about",

commit ecebe3b3dd4a0cb6a626327526459217a470f5e3
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Mar 1 15:49:20 2013 -0800

    Push ticket ACL checks into SQL with the expectation of better perf

diff --git a/etc/CPAN_Config.pm b/etc/CPAN_Config.pm
index 6de7695..44a3756 100644
--- a/etc/CPAN_Config.pm
+++ b/etc/CPAN_Config.pm
@@ -139,4 +139,8 @@ Set( %Lifecycles,
 my %lifecycles = RT->Config->Get("Lifecycles");
 %{ $lifecycles{default} } = %{ $lifecycles{cpan} };
 
+# SQL for ACLs is good for perf and accurate counts, and rt.cpan.org's ACL
+# model is pretty simple.
+Set($UseSQLForACLChecks, 1);
+
 1;

-----------------------------------------------------------------------