[Bps-public-commit] smokingit branch, master, updated. a4ce468aa37c9c207621ec5ebe77710c5132482a

Alex Vandiver alexmv at bestpractical.com
Thu Nov 21 16:37:03 EST 2013


The branch, master has been updated
       via  a4ce468aa37c9c207621ec5ebe77710c5132482a (commit)
      from  018e5b57b68810e0c35286fd37ec8304982c37ab (commit)

Summary of changes:
 lib/Smokingit/View/GitHub.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit a4ce468aa37c9c207621ec5ebe77710c5132482a
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Nov 21 16:34:36 2013 -0500

    Revert "Ensure that decode_json gets bytes, like it expects"
    
    The failing decode_json came from Web::Hippie, not the github endpoint.
    
    This reverts commit 018e5b57b68810e0c35286fd37ec8304982c37ab, but leaves
    in place the additional debugging.

diff --git a/lib/Smokingit/View/GitHub.pm b/lib/Smokingit/View/GitHub.pm
index 7afeb74..3c7b6f4 100644
--- a/lib/Smokingit/View/GitHub.pm
+++ b/lib/Smokingit/View/GitHub.pm
@@ -5,13 +5,12 @@ package Smokingit::View::GitHub;
 use Jifty::View::Declare -base;
 
 use Jifty::JSON qw/decode_json/;
-use Encode qw/encode/;
 
 template '/github' => sub {
     my $ret = eval {
         die "Wrong method\n" unless Jifty->web->request->method eq "POST";
         die "No payload\n"   unless get('payload');
-        my $json = eval { decode_json(encode('utf8', get('payload'))) }
+        my $json = eval { decode_json(get('payload')) }
             or die "Bad JSON: $@\n" . get('payload');
 
         my $name = $json->{repository}{name}

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list