[Bps-public-commit] smokingit branch, master, updated. b3b5adedf93ea797f61dadf9b0ff10d5ae5bc859

[Alex Vandiver]

The branch, master has been updated
       via  b3b5adedf93ea797f61dadf9b0ff10d5ae5bc859 (commit)
       via  49987e04df1c3b89e232c91ed91d8dcb6be68767 (commit)
      from  558a9af7f7352edea9c461a6e3e42cb7f28547fd (commit)

Summary of changes:
 lib/Smokingit/IRC.pm               | 10 +++++++++-
 lib/Smokingit/Model/SmokeResult.pm |  1 +
 2 files changed, 10 insertions(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 49987e04df1c3b89e232c91ed91d8dcb6be68767
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Apr 2 12:26:21 2014 -0400

    Report on configuration failures

diff --git a/lib/Smokingit/IRC.pm b/lib/Smokingit/IRC.pm
index 5f24ed5..5eb1442 100644
--- a/lib/Smokingit/IRC.pm
+++ b/lib/Smokingit/IRC.pm
@@ -317,7 +317,15 @@ sub describe_fail {
 
     # Are all of the fails across all configurations?
     my %tested_configs;
-    $tested_configs{$_->configuration->id}++ for @{ $commit->smoke_results->items_array_ref };
+    for my $result (@{ $commit->smoke_results->items_array_ref }) {
+        my $config = $result->configuration;
+        $tested_configs{$config->id}++;
+
+        my $short = $result->short_error;
+        next unless $short;
+        $short =~ s/^Configuration failed/configuration/;
+        $testnames{$short}{$config->name} = 1;
+    }
     my $config_count = keys %tested_configs;
     if (scalar values %testnames == grep {keys(%{$_}) == $config_count} values %testnames) {
         return "failing ".enum(",", sort keys %testnames);

commit b3b5adedf93ea797f61dadf9b0ff10d5ae5bc859
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Apr 2 12:27:07 2014 -0400

    Clear our error before clearing memcached
    
    Otherwise the error status will still be cached in memcached

diff --git a/lib/Smokingit/Model/SmokeResult.pm b/lib/Smokingit/Model/SmokeResult.pm
index b93d8a3..978986c 100644
--- a/lib/Smokingit/Model/SmokeResult.pm
+++ b/lib/Smokingit/Model/SmokeResult.pm
@@ -121,6 +121,7 @@ sub run_smoke {
         on_sent => sub {
             my $ok = shift;
             $self->as_superuser->set_queue_status($ok ? "queued" : "broken");
+            $self->as_superuser->set_error(undef);
             # Use SQL so we get millisecond accuracy in the DB.  Otherwise rows
             # inserted during the same second may not sort the same as they show
             # up in the worker's queue.

-----------------------------------------------------------------------