[Bps-public-commit] Module-Install-RTx branch, master, updated. 0.35-3-g24e67d8

[Kevin Falcone]

The branch, master has been updated
       via  24e67d803b219381ad70d22d5321517dafcb2150 (commit)
       via  77dd54b85a32487c574e5d1d1d87142c84f557cc (commit)
      from  3a83130e2c1006f93cab7cb1150aa6eff02c5794 (commit)

Summary of changes:
 README                    | 22 ++++++----------------
 lib/Module/Install/RTx.pm |  6 +++---
 2 files changed, 9 insertions(+), 19 deletions(-)

- Log -----------------------------------------------------------------
commit 77dd54b85a32487c574e5d1d1d87142c84f557cc
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Sun Aug 24 18:47:05 2014 -0400

    Fix pod errors (Everything elses uses a head2)
    
    As noted by Christian Loos in rt.cpan.org #98243

diff --git a/README b/README
index 0905fca..f0096c4 100644
--- a/README
+++ b/README
@@ -32,14 +32,14 @@ DESCRIPTION
     Accepts an optional argument hashref after the extension name with two
     possible keys
 
-    deprecated_rt
-            If set to a true value, skips the enforced RT-4.0.0 minimum version check
+  deprecated_rt
+        If set to a true value, skips the enforced RT-4.0.0 minimum version check
 
-            You should set a perl_version if using this option and requires_rt(), because requires_rt
-            only handles figuring our what perl you need if you're on RT 4.0.0 or higher.
+        You should set a perl_version if using this option and requires_rt(), because requires_rt
+        only handles figuring our what perl you need if you're on RT 4.0.0 or higher.
 
-    no_readme_generation
-            If set to a true value, will not call readme_from on the extension's primary perl module.
+  no_readme_generation
+        If set to a true value, will not call readme_from on the extension's primary perl module.
 
   requires_rt *version*
     Takes one argument, a valid RT version. If an attempt is made to install
@@ -104,13 +104,3 @@ COPYRIGHT
     TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
     SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-POD ERRORS
-    Hey! The above document had some coding errors, which are explained
-    below:
-
-    Around line 297:
-        '=item' outside of any '=over'
-
-    Around line 308:
-        You forgot a '=back' before '=head2'
-
diff --git a/lib/Module/Install/RTx.pm b/lib/Module/Install/RTx.pm
index abf9b0b..96b7a57 100644
--- a/lib/Module/Install/RTx.pm
+++ b/lib/Module/Install/RTx.pm
@@ -294,14 +294,14 @@ they exist (assuming C<RTx('RT-Extension-Example')>):
 
 Accepts an optional argument hashref after the extension name with two possible keys
 
-=item deprecated_rt
+=head2 deprecated_rt
 
     If set to a true value, skips the enforced RT-4.0.0 minimum version check
 
     You should set a perl_version if using this option and requires_rt(), because requires_rt
     only handles figuring our what perl you need if you're on RT 4.0.0 or higher.
 
-=item no_readme_generation
+=head2 no_readme_generation
 
     If set to a true value, will not call readme_from on the extension's primary perl module.
 

commit 24e67d803b219381ad70d22d5321517dafcb2150
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Sun Aug 24 19:17:29 2014 -0400

    Reach deeply enough into the data structure to find the previous values
    
    As reported by Christian Loos in rt.cpan.org #98243
    Fixes an error in the META.yml for rt-extension-ldapimport-multiemail

diff --git a/lib/Module/Install/RTx.pm b/lib/Module/Install/RTx.pm
index 96b7a57..800b4da 100644
--- a/lib/Module/Install/RTx.pm
+++ b/lib/Module/Install/RTx.pm
@@ -197,7 +197,7 @@ sub requires_rt_plugin {
     my ( $plugin ) = @_;
 
     if ($self->is_admin) {
-        my $plugins = $self->{values}{"x_requires_rt_plugins"} || [];
+        my $plugins = $self->Meta->{values}{"x_requires_rt_plugins"} || [];
         push @{$plugins}, $plugin;
         $self->add_metadata("x_requires_rt_plugins", $plugins);
     }

-----------------------------------------------------------------------