[Bps-public-commit] rt-extension-assets branch, master, updated. f253e14179e3129435ea6e4eb096ae19715287ef
Alex Vandiver
alexmv at bestpractical.com
Wed Feb 5 16:49:56 EST 2014
The branch, master has been updated
via f253e14179e3129435ea6e4eb096ae19715287ef (commit)
via a042b31b1e7823af4d8b950583753a182c9d2553 (commit)
via 627acafdc4b380c2d05e80eef5834c2002eb2f7f (commit)
via 04c0cfaf130decd06988aff0b2dd9b4f82caf2e9 (commit)
via 0a65f7cdbb41378218a4565e79c393ba08064db6 (commit)
via 2d181c2341eb6e06f0a6e63940558d344a5033d2 (commit)
via d9703c7a146edaa8fda512d0a03c10623a09aa1b (commit)
via 1f36a95aaaa1076945d2bdb6114d6ba478776812 (commit)
via f0ae812bb55b04398c218d406ebde8e0212a6672 (commit)
via 931a782daab713f8854093c23a2b09373fbc65cd (commit)
via d87cd134b7897164d95626220b507530ba8b3ce7 (commit)
via 5943d56b58f55a09e8d947e1c40c0a65f09f0a16 (commit)
via ea428b68c1579d7ef130bb4b915455d782dc87c3 (commit)
via 3c75ffc43af6457b323eb274b8c0c06bb2bffcc4 (commit)
via 9dd304f479a859d5f120ba53a4a882d664914a72 (commit)
from 0e86af3db0db0d8adfbaaf3517ae58d71fd09d14 (commit)
Summary of changes:
.gitignore | 1 +
MANIFEST | 1 +
MANIFEST.SKIP | 60 +++++++++++++++++++++-
META.yml | 4 +-
Makefile.PL | 2 +-
README | 30 +++++++----
html/Admin/Assets/Catalogs/Create.html | 2 +-
html/Admin/Assets/Catalogs/CustomFields.html | 2 +-
html/Admin/Assets/Catalogs/Elements/EditBasics | 2 +-
html/Admin/Assets/Catalogs/GroupRights.html | 2 +-
html/Admin/Assets/Catalogs/Modify.html | 2 +-
html/Admin/Assets/Catalogs/Roles.html | 2 +-
html/Admin/Assets/Catalogs/UserRights.html | 2 +-
html/Admin/Assets/Catalogs/index.html | 2 +-
html/Admin/Assets/index.html | 2 +-
html/Admin/Global/CustomFields/Catalog-Assets.html | 2 +-
html/Asset/Create.html | 4 +-
html/Asset/CreateInCatalog.html | 2 +-
html/Asset/CreateLinkedTicket.html | 2 +-
html/Asset/Display.html | 4 +-
html/Asset/Elements/AssetSearchBasics | 2 +-
html/Asset/Elements/AssetSearchCFs | 2 +-
html/Asset/Elements/AssetSearchPeople | 2 +-
html/Asset/Elements/CreateInCatalog | 2 +-
html/Asset/Elements/CreateLinkedTicket | 2 +-
html/Asset/Elements/EditBasics | 2 +-
html/Asset/Elements/EditDates | 2 +-
html/Asset/Elements/EditPeople | 2 +-
html/Asset/Elements/SelectCatalog | 2 +-
html/Asset/Elements/SelectStatus | 2 +-
html/Asset/Elements/ShowBasics | 2 +-
html/Asset/Elements/ShowCatalog | 2 +-
html/Asset/Elements/ShowDates | 2 +-
html/Asset/Elements/ShowLinks | 2 +-
html/Asset/Elements/ShowPeople | 2 +-
html/Asset/Elements/ShowRoleMembers | 2 +-
html/Asset/Elements/ShowSummary | 2 +-
html/Asset/Helpers/CreateInCatalog | 2 +-
html/Asset/Helpers/CreateLinkedTicket | 2 +-
html/Asset/History.html | 4 +-
html/Asset/Modify.html | 4 +-
html/Asset/ModifyCFs.html | 4 +-
html/Asset/ModifyDates.html | 4 +-
html/Asset/ModifyLinks.html | 4 +-
html/Asset/ModifyPeople.html | 4 +-
html/Asset/Search/Bulk.html | 2 +-
html/Asset/Search/index.html | 2 +-
html/Asset/index.html | 2 +-
.../Elements/AddLinks/ExtraLinkInstructions | 2 +-
.../RT-Extension-Assets/Elements/Tabs/Privileged | 2 +-
.../RT-Extension-Assets/Elements/Tabs/SelfService | 2 +-
.../SelfService/Display.html/BeforeShowHistory | 2 +-
.../Ticket/Create.html/AfterBasics | 2 +-
.../Ticket/Elements/ShowSummary/LinksExtra | 2 +-
html/Elements/Assets/AddPeople | 2 +-
html/Elements/Assets/EditPeople | 2 +-
html/Elements/Assets/EditRoleMembers | 2 +-
html/Elements/Assets/Search | 2 +-
html/Elements/Assets/SelectRoleType | 2 +-
html/Elements/FindAsset | 2 +-
html/Elements/MyAssets | 2 +-
html/Elements/RT__Asset/ColumnMap | 2 +-
html/Elements/RT__Catalog/ColumnMap | 2 +-
html/SelfService/Asset/CreateLinkedTicket.html | 2 +-
html/SelfService/Asset/Display.html | 2 +-
html/SelfService/Asset/Helpers/CreateLinkedTicket | 2 +-
html/SelfService/Asset/History.html | 2 +-
html/SelfService/Asset/index.html | 2 +-
html/Ticket/Elements/ShowAssets | 2 +-
html/Ticket/Elements/ShowAssetsOnCreate | 2 +-
html/User/Elements/AssetList | 2 +-
html/User/Elements/Portlets/UserAssets | 2 +-
lib/RT/Asset.pm | 12 +++--
lib/RT/Assets.pm | 14 +++--
lib/RT/Catalog.pm | 6 +--
lib/RT/Catalogs.pm | 2 +-
lib/RT/Extension/Assets.pm | 44 +++++++++-------
lib/RT/Extension/Assets/Tutorial.pm | 47 +++++++++++++++++
lib/RT/Lifecycle/Asset.pm | 2 +-
lib/RT/URI/asset.pm | 2 +-
patches/rt-4.2.1-4.2.2.patch | 55 ++++++++++++++++++++
81 files changed, 308 insertions(+), 122 deletions(-)
create mode 100644 patches/rt-4.2.1-4.2.2.patch
- Log -----------------------------------------------------------------
commit 9dd304f479a859d5f120ba53a4a882d664914a72
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Jan 27 17:20:18 2014 -0500
Version bump for 1.0rc1
diff --git a/META.yml b/META.yml
index 7c546b7..54baa9e 100644
--- a/META.yml
+++ b/META.yml
@@ -32,4 +32,4 @@ requires:
perl: 5.10.1
resources:
license: http://opensource.org/licenses/gpl-license.php
-version: 0.90
+version: 1.0rc1
diff --git a/lib/RT/Extension/Assets.pm b/lib/RT/Extension/Assets.pm
index a2dbc12..34485db 100644
--- a/lib/RT/Extension/Assets.pm
+++ b/lib/RT/Extension/Assets.pm
@@ -50,7 +50,7 @@ use strict;
use warnings;
package RT::Extension::Assets;
-our $VERSION = '0.90';
+our $VERSION = '1.0rc1';
# Loaded so they're available and rights are injected.
use RT::Catalog;
commit 3c75ffc43af6457b323eb274b8c0c06bb2bffcc4
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Jan 27 17:28:08 2014 -0500
Ignore generated SIGNATURE
diff --git a/.gitignore b/.gitignore
index e516a72..d0e2233 100644
--- a/.gitignore
+++ b/.gitignore
@@ -12,3 +12,4 @@ pod2htm*.tmp
/MYMETA.*
/xt/tmp/
/xt/lib/RT/Extension/Assets/Test.pm
+SIGNATURE
\ No newline at end of file
commit ea428b68c1579d7ef130bb4b915455d782dc87c3
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Jan 27 17:28:40 2014 -0500
Expand the #!include_default, as Make wants to do
diff --git a/MANIFEST.SKIP b/MANIFEST.SKIP
index 9e4423e..09b2303 100644
--- a/MANIFEST.SKIP
+++ b/MANIFEST.SKIP
@@ -1,4 +1,62 @@
-#!include_default
+
+#!start included /home/chmrr/prog/perlbrew/perls/perl-5.16.0/lib/5.16.0/ExtUtils/MANIFEST.SKIP
+# Avoid version control files.
+\bRCS\b
+\bCVS\b
+\bSCCS\b
+,v$
+\B\.svn\b
+\B\.git\b
+\B\.gitignore\b
+\b_darcs\b
+\B\.cvsignore$
+
+# Avoid VMS specific MakeMaker generated files
+\bDescrip.MMS$
+\bDESCRIP.MMS$
+\bdescrip.mms$
+
+# Avoid Makemaker generated and utility files.
+\bMANIFEST\.bak
+\bMakefile$
+\bblib/
+\bMakeMaker-\d
+\bpm_to_blib\.ts$
+\bpm_to_blib$
+\bblibdirs\.ts$ # 6.18 through 6.25 generated this
+
+# Avoid Module::Build generated and utility files.
+\bBuild$
+\b_build/
+\bBuild.bat$
+\bBuild.COM$
+\bBUILD.COM$
+\bbuild.com$
+
+# Avoid temp and backup files.
+~$
+\.old$
+\#$
+\b\.#
+\.bak$
+\.tmp$
+\.#
+\.rej$
+
+# Avoid OS-specific files/dirs
+# Mac OSX metadata
+\B\.DS_Store
+# Mac OSX SMB mount metadata files
+\B\._
+
+# Avoid Devel::Cover and Devel::CoverX::Covered files.
+\bcover_db\b
+\bcovered\b
+
+# Avoid MYMETA files
+^MYMETA\.
+#!end included /home/chmrr/prog/perlbrew/perls/perl-5.16.0/lib/5.16.0/ExtUtils/MANIFEST.SKIP
+
# Testing infrastructure
^xt/lib/RT/Extension/Assets/Test.pm$
commit 5943d56b58f55a09e8d947e1c40c0a65f09f0a16
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Jan 28 17:24:14 2014 -0500
Fix the minimum version; Assets requires 4.2
diff --git a/Makefile.PL b/Makefile.PL
index 5edc662..0b6d23d 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -11,7 +11,7 @@ no_index package => "RT::Transaction";
no_index package => "RT::CustomField";
no_index package => "RT::CustomFields";
-requires_rt("4.0.0");
+requires_rt("4.2.1");
test_requires "Test::Warn";
my ($loaded) = ($INC{'RT.pm'} =~ /^(.*)[\\\/]/);
commit d87cd134b7897164d95626220b507530ba8b3ce7
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Jan 28 18:14:28 2014 -0500
Ensure that we do not try to id = 'string'
diff --git a/lib/RT/Assets.pm b/lib/RT/Assets.pm
index b7ad98e..cdfd4a1 100644
--- a/lib/RT/Assets.pm
+++ b/lib/RT/Assets.pm
@@ -195,7 +195,7 @@ sub SimpleSearch {
VALUE => $args{Term},
ENTRYAGGREGATOR => 'OR',
SUBCLAUSE => 'autocomplete',
- );
+ ) unless $args{Term} =~ /\D/ and $name eq 'id';
}
}
return $self;
commit 931a782daab713f8854093c23a2b09373fbc65cd
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Jan 28 18:15:34 2014 -0500
Pass the Catalog (which is the fetched DefaultCatalog) down into SimpleSearch
Previously, we limited to Catalog IS NULL
diff --git a/lib/RT/Extension/Assets.pm b/lib/RT/Extension/Assets.pm
index 34485db..69dae4c 100644
--- a/lib/RT/Extension/Assets.pm
+++ b/lib/RT/Extension/Assets.pm
@@ -204,7 +204,7 @@ RT->AddJavaScript("RTx-Assets.js");
my @PassArguments;
if ($ARGSRef->{q}) {
- $args{'Assets'}->SimpleSearch( Term => $ARGSRef->{q} );
+ $args{'Assets'}->SimpleSearch( Term => $ARGSRef->{q}, Catalog => $args{Catalog} );
push @PassArguments, "q";
} elsif ( $ARGSRef->{'SearchAssets'} ){
for my $key (keys %$ARGSRef) {
commit f0ae812bb55b04398c218d406ebde8e0212a6672
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Jan 28 18:15:54 2014 -0500
Accept Catalog as either an object or an id/name to load
diff --git a/lib/RT/Assets.pm b/lib/RT/Assets.pm
index cdfd4a1..0315043 100644
--- a/lib/RT/Assets.pm
+++ b/lib/RT/Assets.pm
@@ -156,9 +156,15 @@ sub SimpleSearch {
# and currently fails in odd ways. Such a mapping obviously assumes
# that names are unique within the catalog, but ids are also
# allowable as well.
+ my $catalog;
+ if (ref $args{Catalog}) {
+ $catalog = $args{Catalog};
+ } else {
+ $catalog = RT::Catalog->new( $self->CurrentUser );
+ $catalog->Load( $args{Catalog} );
+ }
+
my %cfs;
- my $catalog = RT::Catalog->new( $self->CurrentUser );
- $catalog->Load( $args{Catalog} );
my $cfs = $catalog->AssetCustomFields;
while (my $customfield = $cfs->Next) {
$cfs{$customfield->id} = $cfs{$customfield->Name}
commit 1f36a95aaaa1076945d2bdb6114d6ba478776812
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Jan 28 18:33:22 2014 -0500
Fix asset variable name in CSS class
diff --git a/html/Asset/Create.html b/html/Asset/Create.html
index 3a2edc5..c7476dd 100644
--- a/html/Asset/Create.html
+++ b/html/Asset/Create.html
@@ -56,7 +56,7 @@
<& /Elements/ListActions, actions => \@results &>
-<span class="catalog <% CSSClass($AssetObj->CatalogObj->Name) %>">
+<span class="catalog <% CSSClass($catalog->Name) %>">
<form method="post" enctype="multipart/form-data" id="CreateAsset" action="Create.html">
<input type="hidden" name="id" value="new">
<input type="hidden" name="Catalog" value="<% $catalog->id %>">
diff --git a/html/Asset/Display.html b/html/Asset/Display.html
index bab4f8a..85bd65e 100644
--- a/html/Asset/Display.html
+++ b/html/Asset/Display.html
@@ -52,7 +52,7 @@
<& /Elements/ListActions &>
-<span class="catalog <% CSSClass($AssetObj->CatalogObj->Name) %>">
+<span class="catalog <% CSSClass($asset->CatalogObj->Name) %>">
<& Elements/ShowSummary, AssetObj => $asset &>
% $m->callback(CallbackName => 'AfterShowSummary', ARGSRef => \%ARGS, Asset => $asset);
diff --git a/html/Asset/History.html b/html/Asset/History.html
index 02dd751..7a45f59 100644
--- a/html/Asset/History.html
+++ b/html/Asset/History.html
@@ -48,7 +48,7 @@
<& /Elements/Header, Title => loc("History of Asset #[_1]: [_2]", $asset->id, $asset->Name) &>
<& /Elements/Tabs &>
-<span class="catalog <% CSSClass($AssetObj->CatalogObj->Name) %>">
+<span class="catalog <% CSSClass($asset->CatalogObj->Name) %>">
<& /Elements/ShowHistory,
Object => $asset,
ShowDisplayModes => 0,
diff --git a/html/Asset/Modify.html b/html/Asset/Modify.html
index 366efb2..13a177b 100644
--- a/html/Asset/Modify.html
+++ b/html/Asset/Modify.html
@@ -50,7 +50,7 @@
<& /Elements/ListActions, actions => \@results &>
-<span class="catalog <% CSSClass($AssetObj->CatalogObj->Name) %>">
+<span class="catalog <% CSSClass($asset->CatalogObj->Name) %>">
<form method="post" enctype="multipart/form-data" id="ModifyAsset" action="Modify.html">
<input type="hidden" name="id" value="<% $asset->id %>">
<input type="hidden" name="DisplayAfter" value="<% $DisplayAfter ? 1 : 0 %>">
diff --git a/html/Asset/ModifyCFs.html b/html/Asset/ModifyCFs.html
index 4a1ff50..c896e5b 100755
--- a/html/Asset/ModifyCFs.html
+++ b/html/Asset/ModifyCFs.html
@@ -50,7 +50,7 @@
<& /Elements/ListActions, actions => \@results &>
-<span class="catalog <% CSSClass($AssetObj->CatalogObj->Name) %>">
+<span class="catalog <% CSSClass($asset->CatalogObj->Name) %>">
<form method="post" enctype="multipart/form-data" id="ModifyAssetCFs" action="ModifyCFs.html">
<input type="hidden" name="id" value="<% $asset->id %>">
<input type="hidden" name="Grouping" value="<% $Grouping %>">
diff --git a/html/Asset/ModifyDates.html b/html/Asset/ModifyDates.html
index 0c5bbfe..28e2c20 100755
--- a/html/Asset/ModifyDates.html
+++ b/html/Asset/ModifyDates.html
@@ -50,7 +50,7 @@
<& /Elements/ListActions, actions => \@results &>
-<span class="catalog <% CSSClass($AssetObj->CatalogObj->Name) %>">
+<span class="catalog <% CSSClass($asset->CatalogObj->Name) %>">
<form method="post" enctype="multipart/form-data" id="ModifyAssetDates" action="ModifyDates.html">
<input type="hidden" name="id" value="<% $asset->id %>">
diff --git a/html/Asset/ModifyLinks.html b/html/Asset/ModifyLinks.html
index 1823d58..c066810 100755
--- a/html/Asset/ModifyLinks.html
+++ b/html/Asset/ModifyLinks.html
@@ -50,7 +50,7 @@
<& /Elements/ListActions, actions => \@results &>
-<span class="catalog <% CSSClass($AssetObj->CatalogObj->Name) %>">
+<span class="catalog <% CSSClass($asset->CatalogObj->Name) %>">
<form method="post" enctype="multipart/form-data" id="ModifyAssetLinks" action="ModifyLinks.html">
<input type="hidden" name="id" value="<% $asset->id %>">
diff --git a/html/Asset/ModifyPeople.html b/html/Asset/ModifyPeople.html
index 99eb7de..5de317f 100755
--- a/html/Asset/ModifyPeople.html
+++ b/html/Asset/ModifyPeople.html
@@ -52,7 +52,7 @@
<& /Elements/ListActions, actions => \@results &>
-<span class="catalog <% CSSClass($AssetObj->CatalogObj->Name) %>">
+<span class="catalog <% CSSClass($asset->CatalogObj->Name) %>">
<form method="post" enctype="multipart/form-data" id="ModifyAssetPeople" action="ModifyPeople.html">
<input type="hidden" name="id" value="<% $asset->id %>">
commit d9703c7a146edaa8fda512d0a03c10623a09aa1b
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Jan 28 18:33:56 2014 -0500
Role resolution errors (aka "user does not exist") should be fatal
diff --git a/lib/RT/Asset.pm b/lib/RT/Asset.pm
index 4ee46d6..b4c0e23 100644
--- a/lib/RT/Asset.pm
+++ b/lib/RT/Asset.pm
@@ -249,6 +249,10 @@ sub Create {
);
}
+ my $roles = {};
+ my @errors = $self->_ResolveRoles( $roles, %args );
+ return (0, @errors) if @errors;
+
RT->DatabaseHandle->BeginTransaction();
my ( $id, $msg ) = $self->SUPER::Create(
@@ -271,8 +275,6 @@ sub Create {
}
# Figure out users for roles
- my $roles = {};
- push @non_fatal_errors, $self->_ResolveRoles( $roles, %args );
push @non_fatal_errors, $self->_AddRolesOnCreate( $roles, map { $_ => sub {1} } $self->Roles );
# Add CFs
commit 2d181c2341eb6e06f0a6e63940558d344a5033d2
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Feb 3 19:07:24 2014 -0500
Update license tag for 2014
diff --git a/html/Admin/Assets/Catalogs/Create.html b/html/Admin/Assets/Catalogs/Create.html
index 2f2be79..1179595 100644
--- a/html/Admin/Assets/Catalogs/Create.html
+++ b/html/Admin/Assets/Catalogs/Create.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Admin/Assets/Catalogs/CustomFields.html b/html/Admin/Assets/Catalogs/CustomFields.html
index bfbf2d2..a345c7d 100644
--- a/html/Admin/Assets/Catalogs/CustomFields.html
+++ b/html/Admin/Assets/Catalogs/CustomFields.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Admin/Assets/Catalogs/Elements/EditBasics b/html/Admin/Assets/Catalogs/Elements/EditBasics
index fbeef81..e084fb6 100644
--- a/html/Admin/Assets/Catalogs/Elements/EditBasics
+++ b/html/Admin/Assets/Catalogs/Elements/EditBasics
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Admin/Assets/Catalogs/GroupRights.html b/html/Admin/Assets/Catalogs/GroupRights.html
index f9dae76..333d476 100644
--- a/html/Admin/Assets/Catalogs/GroupRights.html
+++ b/html/Admin/Assets/Catalogs/GroupRights.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Admin/Assets/Catalogs/Modify.html b/html/Admin/Assets/Catalogs/Modify.html
index 70c411b..cf9a7aa 100644
--- a/html/Admin/Assets/Catalogs/Modify.html
+++ b/html/Admin/Assets/Catalogs/Modify.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Admin/Assets/Catalogs/Roles.html b/html/Admin/Assets/Catalogs/Roles.html
index d2d680a..33bfd4f 100644
--- a/html/Admin/Assets/Catalogs/Roles.html
+++ b/html/Admin/Assets/Catalogs/Roles.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Admin/Assets/Catalogs/UserRights.html b/html/Admin/Assets/Catalogs/UserRights.html
index 98d8f12..d676678 100644
--- a/html/Admin/Assets/Catalogs/UserRights.html
+++ b/html/Admin/Assets/Catalogs/UserRights.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Admin/Assets/Catalogs/index.html b/html/Admin/Assets/Catalogs/index.html
index aa8ef3b..572888c 100644
--- a/html/Admin/Assets/Catalogs/index.html
+++ b/html/Admin/Assets/Catalogs/index.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Admin/Assets/index.html b/html/Admin/Assets/index.html
index b1318b2..a4ac4bd 100644
--- a/html/Admin/Assets/index.html
+++ b/html/Admin/Assets/index.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Admin/Global/CustomFields/Catalog-Assets.html b/html/Admin/Global/CustomFields/Catalog-Assets.html
index 0d39da8..f85874b 100644
--- a/html/Admin/Global/CustomFields/Catalog-Assets.html
+++ b/html/Admin/Global/CustomFields/Catalog-Assets.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Create.html b/html/Asset/Create.html
index c7476dd..a517c6d 100644
--- a/html/Asset/Create.html
+++ b/html/Asset/Create.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/CreateInCatalog.html b/html/Asset/CreateInCatalog.html
index acd1b42..985ad37 100644
--- a/html/Asset/CreateInCatalog.html
+++ b/html/Asset/CreateInCatalog.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/CreateLinkedTicket.html b/html/Asset/CreateLinkedTicket.html
index 45535f6..104b205 100644
--- a/html/Asset/CreateLinkedTicket.html
+++ b/html/Asset/CreateLinkedTicket.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Display.html b/html/Asset/Display.html
index 85bd65e..f155136 100644
--- a/html/Asset/Display.html
+++ b/html/Asset/Display.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/AssetSearchBasics b/html/Asset/Elements/AssetSearchBasics
index 02e1298..386dd8b 100644
--- a/html/Asset/Elements/AssetSearchBasics
+++ b/html/Asset/Elements/AssetSearchBasics
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/AssetSearchCFs b/html/Asset/Elements/AssetSearchCFs
index ad52e3b..5bcd4f4 100644
--- a/html/Asset/Elements/AssetSearchCFs
+++ b/html/Asset/Elements/AssetSearchCFs
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/AssetSearchPeople b/html/Asset/Elements/AssetSearchPeople
index 3a85da5..9dfc15d 100644
--- a/html/Asset/Elements/AssetSearchPeople
+++ b/html/Asset/Elements/AssetSearchPeople
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/CreateInCatalog b/html/Asset/Elements/CreateInCatalog
index b754821..055dd9e 100644
--- a/html/Asset/Elements/CreateInCatalog
+++ b/html/Asset/Elements/CreateInCatalog
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/CreateLinkedTicket b/html/Asset/Elements/CreateLinkedTicket
index 2c5b8ca..63a8eaa 100644
--- a/html/Asset/Elements/CreateLinkedTicket
+++ b/html/Asset/Elements/CreateLinkedTicket
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/EditBasics b/html/Asset/Elements/EditBasics
index a3829fc..3095c35 100644
--- a/html/Asset/Elements/EditBasics
+++ b/html/Asset/Elements/EditBasics
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/EditDates b/html/Asset/Elements/EditDates
index 4575459..1e64a26 100644
--- a/html/Asset/Elements/EditDates
+++ b/html/Asset/Elements/EditDates
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/EditPeople b/html/Asset/Elements/EditPeople
index 86bc4b3..3dc88d2 100644
--- a/html/Asset/Elements/EditPeople
+++ b/html/Asset/Elements/EditPeople
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/SelectCatalog b/html/Asset/Elements/SelectCatalog
index 38ffd70..48e9df0 100644
--- a/html/Asset/Elements/SelectCatalog
+++ b/html/Asset/Elements/SelectCatalog
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/SelectStatus b/html/Asset/Elements/SelectStatus
index 4535355..f16c804 100644
--- a/html/Asset/Elements/SelectStatus
+++ b/html/Asset/Elements/SelectStatus
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/ShowBasics b/html/Asset/Elements/ShowBasics
index afe377f..da350a1 100644
--- a/html/Asset/Elements/ShowBasics
+++ b/html/Asset/Elements/ShowBasics
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/ShowCatalog b/html/Asset/Elements/ShowCatalog
index 36a31bb..d7c1095 100644
--- a/html/Asset/Elements/ShowCatalog
+++ b/html/Asset/Elements/ShowCatalog
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/ShowDates b/html/Asset/Elements/ShowDates
index 9a50752..582423e 100644
--- a/html/Asset/Elements/ShowDates
+++ b/html/Asset/Elements/ShowDates
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/ShowLinks b/html/Asset/Elements/ShowLinks
index d41cf3f..3b9a6f0 100644
--- a/html/Asset/Elements/ShowLinks
+++ b/html/Asset/Elements/ShowLinks
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/ShowPeople b/html/Asset/Elements/ShowPeople
index 50c5f64..35cbdb4 100644
--- a/html/Asset/Elements/ShowPeople
+++ b/html/Asset/Elements/ShowPeople
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/ShowRoleMembers b/html/Asset/Elements/ShowRoleMembers
index e0c72d7..d15f22c 100644
--- a/html/Asset/Elements/ShowRoleMembers
+++ b/html/Asset/Elements/ShowRoleMembers
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Elements/ShowSummary b/html/Asset/Elements/ShowSummary
index 8b77bf0..be39e65 100644
--- a/html/Asset/Elements/ShowSummary
+++ b/html/Asset/Elements/ShowSummary
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Helpers/CreateInCatalog b/html/Asset/Helpers/CreateInCatalog
index 9a15cd2..034ed91 100644
--- a/html/Asset/Helpers/CreateInCatalog
+++ b/html/Asset/Helpers/CreateInCatalog
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Helpers/CreateLinkedTicket b/html/Asset/Helpers/CreateLinkedTicket
index 0e6b410..95228f5 100644
--- a/html/Asset/Helpers/CreateLinkedTicket
+++ b/html/Asset/Helpers/CreateLinkedTicket
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/History.html b/html/Asset/History.html
index 7a45f59..925eeb4 100644
--- a/html/Asset/History.html
+++ b/html/Asset/History.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Modify.html b/html/Asset/Modify.html
index 13a177b..2c47d28 100644
--- a/html/Asset/Modify.html
+++ b/html/Asset/Modify.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/ModifyCFs.html b/html/Asset/ModifyCFs.html
index c896e5b..744b48e 100755
--- a/html/Asset/ModifyCFs.html
+++ b/html/Asset/ModifyCFs.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/ModifyDates.html b/html/Asset/ModifyDates.html
index 28e2c20..642471d 100755
--- a/html/Asset/ModifyDates.html
+++ b/html/Asset/ModifyDates.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/ModifyLinks.html b/html/Asset/ModifyLinks.html
index c066810..02f2e0b 100755
--- a/html/Asset/ModifyLinks.html
+++ b/html/Asset/ModifyLinks.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/ModifyPeople.html b/html/Asset/ModifyPeople.html
index 5de317f..334dde1 100755
--- a/html/Asset/ModifyPeople.html
+++ b/html/Asset/ModifyPeople.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Search/Bulk.html b/html/Asset/Search/Bulk.html
index fe7bcb4..61c12a8 100644
--- a/html/Asset/Search/Bulk.html
+++ b/html/Asset/Search/Bulk.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/Search/index.html b/html/Asset/Search/index.html
index 4c7bae4..fa1f9dc 100644
--- a/html/Asset/Search/index.html
+++ b/html/Asset/Search/index.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Asset/index.html b/html/Asset/index.html
index 12053d4..ebb2299 100644
--- a/html/Asset/index.html
+++ b/html/Asset/index.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/RT-Extension-Assets/Elements/AddLinks/ExtraLinkInstructions b/html/Callbacks/RT-Extension-Assets/Elements/AddLinks/ExtraLinkInstructions
index 191da8c..acdf074 100644
--- a/html/Callbacks/RT-Extension-Assets/Elements/AddLinks/ExtraLinkInstructions
+++ b/html/Callbacks/RT-Extension-Assets/Elements/AddLinks/ExtraLinkInstructions
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/RT-Extension-Assets/Elements/Tabs/Privileged b/html/Callbacks/RT-Extension-Assets/Elements/Tabs/Privileged
index c580072..37146de 100644
--- a/html/Callbacks/RT-Extension-Assets/Elements/Tabs/Privileged
+++ b/html/Callbacks/RT-Extension-Assets/Elements/Tabs/Privileged
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/RT-Extension-Assets/Elements/Tabs/SelfService b/html/Callbacks/RT-Extension-Assets/Elements/Tabs/SelfService
index 95e481c..329f46e 100644
--- a/html/Callbacks/RT-Extension-Assets/Elements/Tabs/SelfService
+++ b/html/Callbacks/RT-Extension-Assets/Elements/Tabs/SelfService
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/RT-Extension-Assets/SelfService/Display.html/BeforeShowHistory b/html/Callbacks/RT-Extension-Assets/SelfService/Display.html/BeforeShowHistory
index 756fb4f..11411db 100644
--- a/html/Callbacks/RT-Extension-Assets/SelfService/Display.html/BeforeShowHistory
+++ b/html/Callbacks/RT-Extension-Assets/SelfService/Display.html/BeforeShowHistory
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/RT-Extension-Assets/Ticket/Create.html/AfterBasics b/html/Callbacks/RT-Extension-Assets/Ticket/Create.html/AfterBasics
index 37d3f51..8c7acfa 100644
--- a/html/Callbacks/RT-Extension-Assets/Ticket/Create.html/AfterBasics
+++ b/html/Callbacks/RT-Extension-Assets/Ticket/Create.html/AfterBasics
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/RT-Extension-Assets/Ticket/Elements/ShowSummary/LinksExtra b/html/Callbacks/RT-Extension-Assets/Ticket/Elements/ShowSummary/LinksExtra
index 94e8451..7a0b5c1 100644
--- a/html/Callbacks/RT-Extension-Assets/Ticket/Elements/ShowSummary/LinksExtra
+++ b/html/Callbacks/RT-Extension-Assets/Ticket/Elements/ShowSummary/LinksExtra
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Elements/Assets/AddPeople b/html/Elements/Assets/AddPeople
index b0564c8..a069f21 100644
--- a/html/Elements/Assets/AddPeople
+++ b/html/Elements/Assets/AddPeople
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Elements/Assets/EditPeople b/html/Elements/Assets/EditPeople
index d7a9875..6f9ccdd 100644
--- a/html/Elements/Assets/EditPeople
+++ b/html/Elements/Assets/EditPeople
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Elements/Assets/EditRoleMembers b/html/Elements/Assets/EditRoleMembers
index 53f5458..30b6962 100644
--- a/html/Elements/Assets/EditRoleMembers
+++ b/html/Elements/Assets/EditRoleMembers
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Elements/Assets/Search b/html/Elements/Assets/Search
index 0abeecc..9750ef7 100644
--- a/html/Elements/Assets/Search
+++ b/html/Elements/Assets/Search
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Elements/Assets/SelectRoleType b/html/Elements/Assets/SelectRoleType
index 08ad9b5..a38e305 100644
--- a/html/Elements/Assets/SelectRoleType
+++ b/html/Elements/Assets/SelectRoleType
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Elements/FindAsset b/html/Elements/FindAsset
index d762b55..eb2e325 100644
--- a/html/Elements/FindAsset
+++ b/html/Elements/FindAsset
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Elements/MyAssets b/html/Elements/MyAssets
index a6000ec..615ffcf 100644
--- a/html/Elements/MyAssets
+++ b/html/Elements/MyAssets
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Elements/RT__Asset/ColumnMap b/html/Elements/RT__Asset/ColumnMap
index 99e7c44..ffc8b0e 100644
--- a/html/Elements/RT__Asset/ColumnMap
+++ b/html/Elements/RT__Asset/ColumnMap
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Elements/RT__Catalog/ColumnMap b/html/Elements/RT__Catalog/ColumnMap
index 4fcdd1f..8aa1bd6 100644
--- a/html/Elements/RT__Catalog/ColumnMap
+++ b/html/Elements/RT__Catalog/ColumnMap
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/SelfService/Asset/CreateLinkedTicket.html b/html/SelfService/Asset/CreateLinkedTicket.html
index dfe5982..ed4b8fd 100644
--- a/html/SelfService/Asset/CreateLinkedTicket.html
+++ b/html/SelfService/Asset/CreateLinkedTicket.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/SelfService/Asset/Display.html b/html/SelfService/Asset/Display.html
index 8c4e3b4..d105ced 100644
--- a/html/SelfService/Asset/Display.html
+++ b/html/SelfService/Asset/Display.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/SelfService/Asset/Helpers/CreateLinkedTicket b/html/SelfService/Asset/Helpers/CreateLinkedTicket
index 244a20e..6cc25f5 100644
--- a/html/SelfService/Asset/Helpers/CreateLinkedTicket
+++ b/html/SelfService/Asset/Helpers/CreateLinkedTicket
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/SelfService/Asset/History.html b/html/SelfService/Asset/History.html
index 5aa5b19..02f82e7 100644
--- a/html/SelfService/Asset/History.html
+++ b/html/SelfService/Asset/History.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/SelfService/Asset/index.html b/html/SelfService/Asset/index.html
index 06eb431..79016a8 100644
--- a/html/SelfService/Asset/index.html
+++ b/html/SelfService/Asset/index.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Ticket/Elements/ShowAssets b/html/Ticket/Elements/ShowAssets
index 970d180..945407a 100644
--- a/html/Ticket/Elements/ShowAssets
+++ b/html/Ticket/Elements/ShowAssets
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Ticket/Elements/ShowAssetsOnCreate b/html/Ticket/Elements/ShowAssetsOnCreate
index 1b359a6..a6f3bb4 100644
--- a/html/Ticket/Elements/ShowAssetsOnCreate
+++ b/html/Ticket/Elements/ShowAssetsOnCreate
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/User/Elements/AssetList b/html/User/Elements/AssetList
index 4df4c6c..ef5a6a9 100644
--- a/html/User/Elements/AssetList
+++ b/html/User/Elements/AssetList
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/User/Elements/Portlets/UserAssets b/html/User/Elements/Portlets/UserAssets
index 51919f1..8bec6b1 100644
--- a/html/User/Elements/Portlets/UserAssets
+++ b/html/User/Elements/Portlets/UserAssets
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/lib/RT/Asset.pm b/lib/RT/Asset.pm
index b4c0e23..7449038 100644
--- a/lib/RT/Asset.pm
+++ b/lib/RT/Asset.pm
@@ -2,7 +2,7 @@
#
# COPYRIGHT:
#
-# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
# <sales at bestpractical.com>
#
# (Except where explicitly superseded by other copyright notices)
diff --git a/lib/RT/Assets.pm b/lib/RT/Assets.pm
index 0315043..c91ab66 100644
--- a/lib/RT/Assets.pm
+++ b/lib/RT/Assets.pm
@@ -2,7 +2,7 @@
#
# COPYRIGHT:
#
-# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
# <sales at bestpractical.com>
#
# (Except where explicitly superseded by other copyright notices)
diff --git a/lib/RT/Catalog.pm b/lib/RT/Catalog.pm
index ba10822..fab5a0d 100644
--- a/lib/RT/Catalog.pm
+++ b/lib/RT/Catalog.pm
@@ -2,7 +2,7 @@
#
# COPYRIGHT:
#
-# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
# <sales at bestpractical.com>
#
# (Except where explicitly superseded by other copyright notices)
diff --git a/lib/RT/Catalogs.pm b/lib/RT/Catalogs.pm
index 9fc6495..6b4c380 100644
--- a/lib/RT/Catalogs.pm
+++ b/lib/RT/Catalogs.pm
@@ -2,7 +2,7 @@
#
# COPYRIGHT:
#
-# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
# <sales at bestpractical.com>
#
# (Except where explicitly superseded by other copyright notices)
diff --git a/lib/RT/Extension/Assets.pm b/lib/RT/Extension/Assets.pm
index 69dae4c..074bdde 100644
--- a/lib/RT/Extension/Assets.pm
+++ b/lib/RT/Extension/Assets.pm
@@ -2,7 +2,7 @@
#
# COPYRIGHT:
#
-# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
# <sales at bestpractical.com>
#
# (Except where explicitly superseded by other copyright notices)
@@ -674,20 +674,15 @@ OR'd with other L</LimitToCatalog> and C<LimitToGlobal> calls.
Note that this will cause the collection to only return asset CFs.
-=head1 AUTHOR
-
-Thomas Sibley <trs at bestpractical.com>
-
=head1 BUGS
-All bugs should be reported via
-L<http://rt.cpan.org/Public/Dist/Display.html?Name=RT-Extension-Assets>
-or bug-RT-Extension-Assets at rt.cpan.org.
-
+Please report bugs to assets-bugs at bestpractical.com; if you're not sure
+if what you've discovered is a bug, please discuss it on
+rt-users at lists.bestpractical.com before reporting it.
=head1 LICENSE AND COPYRIGHT
-This software is Copyright (c) 2013 by Best Practical Solutions
+This software is Copyright (c) 2014 by Best Practical Solutions
This is free software, licensed under:
diff --git a/lib/RT/Extension/Assets/Tutorial.pm b/lib/RT/Extension/Assets/Tutorial.pm
index 83f1cb2..ac10c41 100644
--- a/lib/RT/Extension/Assets/Tutorial.pm
+++ b/lib/RT/Extension/Assets/Tutorial.pm
@@ -1,3 +1,50 @@
+# BEGIN BPS TAGGED BLOCK {{{
+#
+# COPYRIGHT:
+#
+# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+# <sales at bestpractical.com>
+#
+# (Except where explicitly superseded by other copyright notices)
+#
+#
+# LICENSE:
+#
+# This work is made available to you under the terms of Version 2 of
+# the GNU General Public License. A copy of that license should have
+# been provided with this software, but in any event can be snarfed
+# from www.gnu.org.
+#
+# This work is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+# 02110-1301 or visit their web page on the internet at
+# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
+#
+#
+# CONTRIBUTION SUBMISSION POLICY:
+#
+# (The following paragraph is not intended to limit the rights granted
+# to you to modify and distribute this software under the terms of
+# the GNU General Public License and is only of importance to you if
+# you choose to contribute your changes and enhancements to the
+# community by submitting them to Best Practical Solutions, LLC.)
+#
+# By intentionally submitting any modifications, corrections or
+# derivatives to this work, or any other work intended for use with
+# Request Tracker, to Best Practical Solutions, LLC, you confirm that
+# you are the copyright holder for those contributions and you grant
+# Best Practical Solutions, LLC a nonexclusive, worldwide, irrevocable,
+# royalty-free, perpetual, license to use, copy, create derivative
+# works based on those contributions, and sublicense and distribute
+# those contributions and any derivatives thereof.
+#
+# END BPS TAGGED BLOCK }}}
=head1 Introduction
diff --git a/lib/RT/Lifecycle/Asset.pm b/lib/RT/Lifecycle/Asset.pm
index 5f49695..88f0c6b 100644
--- a/lib/RT/Lifecycle/Asset.pm
+++ b/lib/RT/Lifecycle/Asset.pm
@@ -2,7 +2,7 @@
#
# COPYRIGHT:
#
-# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
# <sales at bestpractical.com>
#
# (Except where explicitly superseded by other copyright notices)
diff --git a/lib/RT/URI/asset.pm b/lib/RT/URI/asset.pm
index 94a551b..06d880a 100644
--- a/lib/RT/URI/asset.pm
+++ b/lib/RT/URI/asset.pm
@@ -2,7 +2,7 @@
#
# COPYRIGHT:
#
-# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
+# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
# <sales at bestpractical.com>
#
# (Except where explicitly superseded by other copyright notices)
commit 0a65f7cdbb41378218a4565e79c393ba08064db6
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Feb 3 19:07:39 2014 -0500
Spellcheck POD
diff --git a/lib/RT/Asset.pm b/lib/RT/Asset.pm
index 7449038..7e4297c 100644
--- a/lib/RT/Asset.pm
+++ b/lib/RT/Asset.pm
@@ -446,12 +446,12 @@ returns undef.
=head2 HeldBy
Returns an L<RT::Group> object for this asset's I<HeldBy> role group. The object
-may be unloaded if permissions aren't satisified.
+may be unloaded if permissions aren't satisfied.
=head2 Contacts
Returns an L<RT::Group> object for this asset's I<Contact> role
-group. The object may be unloaded if permissions aren't satisified.
+group. The object may be unloaded if permissions aren't satisfied.
=cut
diff --git a/lib/RT/Catalog.pm b/lib/RT/Catalog.pm
index fab5a0d..89df80b 100644
--- a/lib/RT/Catalog.pm
+++ b/lib/RT/Catalog.pm
@@ -304,12 +304,12 @@ returns undef.
=head2 HeldBy
Returns an L<RT::Group> object for this catalog's I<HeldBy> role group. The object
-may be unloaded if permissions aren't satisified.
+may be unloaded if permissions aren't satisfied.
=head2 Contacts
Returns an L<RT::Group> object for this catalog's I<Contact> role
-group. The object may be unloaded if permissions aren't satisified.
+group. The object may be unloaded if permissions aren't satisfied.
=cut
diff --git a/lib/RT/Extension/Assets.pm b/lib/RT/Extension/Assets.pm
index 074bdde..2c31a81 100644
--- a/lib/RT/Extension/Assets.pm
+++ b/lib/RT/Extension/Assets.pm
@@ -424,7 +424,7 @@ RT_SiteConfig.pm and add UserAssets to the list.
=head2 C<$DefaultCatalog>
Use this to define the default catalog name that will be used when first
-searching for assets; thereafter, it will defaultto the last-searched
+searching for assets; thereafter, it will default to the last-searched
catalog. You may use either the catalog's name or its ID. This only
affects the catalog selection on the asset search interface.
@@ -448,7 +448,7 @@ searching.
=head2 Managing catalogs
-Catalogs are managed by RT adminstrators, or anyone with the L</AdminCatalog>
+Catalogs are managed by RT administrators, or anyone with the L</AdminCatalog>
right. You can find the list of catalogs, create new catalogs, and manage
existing ones under the Tools → Configuration → Assets → Catalogs menu.
commit 04c0cfaf130decd06988aff0b2dd9b4f82caf2e9
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Feb 3 19:15:07 2014 -0500
Mention RT::Extension::Assets::AppleGSX
diff --git a/lib/RT/Extension/Assets.pm b/lib/RT/Extension/Assets.pm
index 2c31a81..e3a389c 100644
--- a/lib/RT/Extension/Assets.pm
+++ b/lib/RT/Extension/Assets.pm
@@ -626,9 +626,11 @@ Global asset CFs may be intermixed with per-catalog CFs with ordering.
=head2 Importing existing data
-Another extension, L<RT::Extension::Assets::Import::CSV> provides tools to import
-new and update existing assets from a CSV dump. Its configuration lets you
-map the fields in the CSV to the asset fields you've already created in RT.
+Another extension, L<RT::Extension::Assets::Import::CSV> provides tools
+to import new and update existing assets from a CSV dump. Its
+configuration lets you map the fields in the CSV to the asset fields
+you've already created in RT. L<RT::Extension::Assets::AppleGSX> also
+provides tools for looking up data associated with an Apple product.
=head1 METHODS ADDED TO OTHER CLASSES
commit 627acafdc4b380c2d05e80eef5834c2002eb2f7f
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Feb 3 20:02:30 2014 -0500
Provide patch from 4.2/single-role-group-resolve
diff --git a/lib/RT/Extension/Assets.pm b/lib/RT/Extension/Assets.pm
index e3a389c..b121d55 100644
--- a/lib/RT/Extension/Assets.pm
+++ b/lib/RT/Extension/Assets.pm
@@ -372,6 +372,8 @@ RT->AddJavaScript("RTx-Assets.js");
=head1 INSTALLATION
+Assets requires version 4.2.1 or higher of RT.
+
=over
=item perl Makefile.PL
@@ -380,7 +382,16 @@ RT->AddJavaScript("RTx-Assets.js");
=item make install
-May need root permissions
+This step may require root permissions.
+
+=item Patch your RT
+
+Assets requires a small patch to work on versions of RT prior to 4.2.3.
+To patch RT, run:
+
+ patch -d /opt/rt4 -p1 < patches/rt-4.2.1-4.2.2.patch
+
+RT version 4.2.3 and above already contain this patch.
=item Edit your /opt/rt4/etc/RT_SiteConfig.pm
diff --git a/patches/rt-4.2.1-4.2.2.patch b/patches/rt-4.2.1-4.2.2.patch
new file mode 100644
index 0000000..aca898b
--- /dev/null
+++ b/patches/rt-4.2.1-4.2.2.patch
@@ -0,0 +1,55 @@
+From 07dab422cf5081ce970cf3cfcbfd461926d02349 Mon Sep 17 00:00:00 2001
+From: Alex Vandiver <alexmv at bestpractical.com>
+Date: Tue, 28 Jan 2014 18:35:52 -0500
+Subject: [PATCH 1/2] $user->PrincipalObj is _undef_ if the LoadByEmail failed
+
+This prevents runtime errors when assigning unknown users as
+single-member roles
+---
+ lib/RT/Record/Role/Roles.pm | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/lib/RT/Record/Role/Roles.pm b/lib/RT/Record/Role/Roles.pm
+index aad2673..5c78f51 100644
+--- a/lib/RT/Record/Role/Roles.pm
++++ b/lib/RT/Record/Role/Roles.pm
+@@ -524,9 +524,9 @@ sub _ResolveRoles {
+ $user->LoadByEmail( $value ) unless $user->id;
+ $roles->{$role} = $user->PrincipalObj;
+ }
+- unless ($roles->{$role}->id) {
++ unless ($roles->{$role} and $roles->{$role}->id) {
+ push @errors, $self->loc("Invalid value for [_1]",loc($role));
+- $roles->{$role} = RT->Nobody->PrincipalObj unless $roles->{$role}->id;
++ $roles->{$role} = RT->Nobody->PrincipalObj;
+ }
+ # For consistency, we always return an arrayref
+ $roles->{$role} = [ $roles->{$role} ];
+--
+1.8.5.2
+
+From a4070069ae2d21302e0dd1ec9c54e29c7ebdc97f Mon Sep 17 00:00:00 2001
+From: Alex Vandiver <alexmv at bestpractical.com>
+Date: Tue, 28 Jan 2014 18:36:19 -0500
+Subject: [PATCH 2/2] loc() is only in scope by way of $self->
+
+---
+ lib/RT/Record/Role/Roles.pm | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lib/RT/Record/Role/Roles.pm b/lib/RT/Record/Role/Roles.pm
+index 5c78f51..a6172b4 100644
+--- a/lib/RT/Record/Role/Roles.pm
++++ b/lib/RT/Record/Role/Roles.pm
+@@ -525,7 +525,7 @@ sub _ResolveRoles {
+ $roles->{$role} = $user->PrincipalObj;
+ }
+ unless ($roles->{$role} and $roles->{$role}->id) {
+- push @errors, $self->loc("Invalid value for [_1]",loc($role));
++ push @errors, $self->loc("Invalid value for [_1]",$self->loc($role));
+ $roles->{$role} = RT->Nobody->PrincipalObj;
+ }
+ # For consistency, we always return an arrayref
+--
+1.8.5.2
+
commit a042b31b1e7823af4d8b950583753a182c9d2553
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Feb 3 20:02:57 2014 -0500
Update generated files
diff --git a/META.yml b/META.yml
index 54baa9e..101c47b 100644
--- a/META.yml
+++ b/META.yml
@@ -1,7 +1,7 @@
---
abstract: 'RT Extension-Assets Extension'
author:
- - 'Thomas Sibley <trs at bestpractical.com>'
+ - 'Best Practical Solutions'
build_requires:
ExtUtils::MakeMaker: 6.59
Test::Warn: 0
diff --git a/README b/README
index f26dde9..f07e941 100644
--- a/README
+++ b/README
@@ -2,10 +2,20 @@ NAME
RT-Extension-Assets - Asset management for RT
INSTALLATION
+ Assets requires version 4.2.1 or higher of RT.
+
perl Makefile.PL
make
make install
- May need root permissions
+ This step may require root permissions.
+
+ Patch your RT
+ Assets requires a small patch to work on versions of RT prior to
+ 4.2.3. To patch RT, run:
+
+ patch -d /opt/rt4 -p1 < patches/rt-4.2.1-4.2.2.patch
+
+ RT version 4.2.3 and above already contain this patch.
Edit your /opt/rt4/etc/RT_SiteConfig.pm
Add this line:
@@ -39,7 +49,7 @@ INSTALLATION
CONFIGURATION
$DefaultCatalog
Use this to define the default catalog name that will be used when first
- searching for assets; thereafter, it will defaultto the last-searched
+ searching for assets; thereafter, it will default to the last-searched
catalog. You may use either the catalog's name or its ID. This only
affects the catalog selection on the asset search interface.
@@ -63,7 +73,7 @@ USAGE
other qualities for categorizing, sorting, and searching.
Managing catalogs
- Catalogs are managed by RT adminstrators, or anyone with the
+ Catalogs are managed by RT administrators, or anyone with the
"AdminCatalog" right. You can find the list of catalogs, create new
catalogs, and manage existing ones under the Tools → Configuration →
Assets → Catalogs menu.
@@ -233,7 +243,8 @@ USAGE
Another extension, RT::Extension::Assets::Import::CSV provides tools to
import new and update existing assets from a CSV dump. Its configuration
lets you map the fields in the CSV to the asset fields you've already
- created in RT.
+ created in RT. RT::Extension::Assets::AppleGSX also provides tools for
+ looking up data associated with an Apple product.
METHODS ADDED TO OTHER CLASSES
RT::CustomField
@@ -270,16 +281,13 @@ METHODS ADDED TO OTHER CLASSES
Note that this will cause the collection to only return asset CFs.
-AUTHOR
- Thomas Sibley <trs at bestpractical.com>
-
BUGS
- All bugs should be reported via
- <http://rt.cpan.org/Public/Dist/Display.html?Name=RT-Extension-Assets>
- or bug-RT-Extension-Assets at rt.cpan.org.
+ Please report bugs to assets-bugs at bestpractical.com; if you're not sure
+ if what you've discovered is a bug, please discuss it on
+ rt-users at lists.bestpractical.com before reporting it.
LICENSE AND COPYRIGHT
- This software is Copyright (c) 2013 by Best Practical Solutions
+ This software is Copyright (c) 2014 by Best Practical Solutions
This is free software, licensed under:
commit f253e14179e3129435ea6e4eb096ae19715287ef
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Wed Feb 5 16:11:29 2014 -0500
Update MANIFEST
diff --git a/MANIFEST b/MANIFEST
index e33775b..a9a0a27 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -106,6 +106,7 @@ Makefile.PL
MANIFEST This list of files
MANIFEST.SKIP
META.yml
+patches/rt-4.2.1-4.2.2.patch
po/assets.pot
po/en.po
README
-----------------------------------------------------------------------
More information about the Bps-public-commit
mailing list